George Bosilca
e5d316dba6
Coverty: fix issues with using a string once it get freed. The problem, is that the
...
mca_base_register_string don't set the result to NULL is an error occurs.
This commit was SVN r16108.
2007-09-12 18:16:53 +00:00
George Bosilca
7b3dcff267
Coverty: Limit the strcpy to the maximum length of the destination.
...
This commit was SVN r16107.
2007-09-12 18:03:53 +00:00
George Bosilca
bfb4ddc3e2
Coverty: remove dead code.
...
This commit was SVN r16106.
2007-09-12 17:56:33 +00:00
George Bosilca
05ae27c68b
Don't segfault if we receive a fragment for a non existing communicator.
...
Instead, drop it by now.
This commit was SVN r16105.
2007-09-12 17:52:02 +00:00
George Bosilca
c755938eb0
Coverty: release the temporary buffer on error.
...
This commit was SVN r16104.
2007-09-12 17:45:12 +00:00
George Bosilca
2b7ed6262b
Update the communicator lowest_free when we rebuild the communicator list.
...
This commit was SVN r16102.
2007-09-12 16:41:14 +00:00
Shiqing Fan
b1ea3e0054
- add more lines for static import declaration on windows.
...
This commit was SVN r16101.
2007-09-12 15:32:54 +00:00
Shiqing Fan
a0660f4deb
- Just some type casts.
...
This commit was SVN r16100.
2007-09-12 15:29:58 +00:00
Josh Hursey
b4735c9719
Remove an old workaround in which we had to 'mv' the checkpoint file after it
...
was taken form the $CWD to the storage directory. Now we just store directly
to the storage directory which can reduce NFS traffic if working in that mode.
A slight performance boost, but at the point you are using NFS you are paying
a penalty anyway. Now you just don't have to pay it twice :)
This commit was SVN r16099.
2007-09-12 15:03:21 +00:00
Ralph Castain
f80ea093a2
Ensure that the orteds do not directly respond to USR1/2 signals. Those signals are trapped by mpirun and propagated from there - at most, the orteds are involved in the propagation process, but should never do anything on their own.
...
This commit was SVN r16098.
2007-09-12 14:32:31 +00:00
Gleb Natapov
07c8fddeef
Fix scheduling of pending send request. It should be scheduled req_lock times.
...
This commit was SVN r16096.
2007-09-12 07:08:38 +00:00
George Bosilca
d8fed2cfa1
Set a default value so that some compilers stop complaining about
...
uninitialized values.
This commit was SVN r16094.
2007-09-11 18:00:53 +00:00
George Bosilca
2e46809995
Only release the comm_reg is we have one.
...
This commit was SVN r16093.
2007-09-11 17:59:40 +00:00
Shiqing Fan
548a4fe943
- Use IOVBASE_TYPE instead of char to avoid warnings on some systems.
...
This commit was SVN r16092.
2007-09-11 16:24:23 +00:00
Gleb Natapov
140dce7614
Fix ABA problem in atomic_lifo code. This is temporary solution for now. We
...
are looking for a better one.
This commit was SVN r16091.
2007-09-11 15:40:30 +00:00
Gleb Natapov
e82a6eec27
Restore check for lowest id. It prevents livelock situation if multiple threads
...
are inside the function and they failed to obtain new cid the first time around.
This commit was SVN r16090.
2007-09-11 15:32:46 +00:00
Gleb Natapov
58a018c16d
The code tries to prevent itself from running for more then one communicator
...
simultaneously, but is doing it incorrectly. If the function is running already
for one communicator and it is called from another thread for other communicator
with lower cid the check comm->c_contextid != ompi_comm_lowest_cid()
will fail and the function will be executed for two different communicators by
two threads simultaneously. There is nothing in the algorithm that prevent it
from been running simultaneously for different communicators as far as I can see,
but ompi_comm_unregister_cid() assumes that it is always called for a communicator
with the lowest cid and this is not always the case. This patch removes bogus
lowest cid check and fix ompi_comm_register_cid() to properly remove cid from
the list.
This commit was SVN r16088.
2007-09-11 13:23:46 +00:00
Shiqing Fan
c1065d8262
- Some more type casts.
...
This commit was SVN r16087.
2007-09-11 11:28:43 +00:00
Shiqing Fan
dcee7e4229
- Should not use ORTE_DECLSPEC with initialization.
...
This commit was SVN r16086.
2007-09-11 10:13:53 +00:00
Shiqing Fan
a389e61330
- Add some type casts, required by MS compiler.
...
This commit was SVN r16085.
2007-09-11 09:32:11 +00:00
George Bosilca
8659a864e9
This is the real fix for ticket 317 and ticket 1065 and ticket 278.
...
This commit was SVN r16084.
2007-09-10 22:27:59 +00:00
George Bosilca
8622beda54
This commit should fix the issues with ticket 1065. Now, we correctly
...
duplicate the MPI_UB and MPI_LB datatypes.
This commit was SVN r16083.
2007-09-10 22:13:42 +00:00
Ralph Castain
45767b038c
Ensure that no-daemonize is correctly set
...
This commit was SVN r16079.
2007-09-10 14:50:54 +00:00
Gleb Natapov
febdade113
Make non threaded OPAL_ATOMIC_CMPSET macros work correctly.
...
This commit was SVN r16071.
2007-09-09 08:00:16 +00:00
Pak Lui
e3fdfdbd9c
Fix some typos here and there.
...
This commit was SVN r16058.
2007-09-06 14:56:08 +00:00
Tim Prins
f677ef5c12
Fix build failure on BigRed
...
This commit was SVN r16054.
2007-09-06 12:10:11 +00:00
Pak Lui
3d7b5b306f
Fix a problem with OPAL_ALIGN that causes the upper bytes to get chopped
...
off and bogus addresses to show up for the requests, which in turns causes
message queues not showing up when debugging a 64 bit app on a 32 bit
tvd and dll on only Solaris SPARC.
This commit was SVN r16052.
2007-09-05 23:52:36 +00:00
Pak Lui
99ae2c1c44
Nothing relevent (yet). Just making debugging more enjoyable.
...
This commit was SVN r16051.
2007-09-05 23:21:58 +00:00
Gleb Natapov
b0614931f4
Remove mpool_tree_item from the mpool_tree before unregistering/freeing memory.
...
Otherwise a race exists if another thread allocates already freed memory
which is not removed from the mpool_tree yet.
This commit was SVN r16038.
2007-09-03 10:56:55 +00:00
Josh Hursey
447dc0e6cd
testing
...
This commit was SVN r16032.
2007-08-31 17:59:01 +00:00
Rainer Keller
a3b30749b0
- Only lock/unlock when using threads.
...
Basically revert this part of r16015.
This commit was SVN r16029.
The following SVN revision numbers were found above:
r16015 --> open-mpi/ompi@435e7d80e9
2007-08-31 12:34:48 +00:00
Rainer Keller
9c1c345c07
- head_lock is an opal_atomic_lock_t...
...
This commit was SVN r16028.
2007-08-31 12:20:21 +00:00
Pak Lui
bc34a46969
* complete the fix started in r15915, that is, to prevent negative tags
...
from showing up in the message queue graph. Tags are now casted to int
before the negative checks, since tags by the spec are stored as
mqs_tword_t, an unsigned long long.
This commit was SVN r16027.
The following SVN revision numbers were found above:
r15915 --> open-mpi/ompi@b9ea4c92e7
2007-08-31 03:02:24 +00:00
Shiqing Fan
b1250eba3a
- Some more to be exported.
...
This commit was SVN r16023.
2007-08-30 15:13:08 +00:00
Shiqing Fan
efdcfa3807
- "extern 'C'" has been set twice. Remove one.
...
This commit was SVN r16022.
2007-08-30 15:03:59 +00:00
Shiqing Fan
80fdd5e2a4
- Need to be exported.
...
This commit was SVN r16021.
2007-08-30 14:16:03 +00:00
Gleb Natapov
79011279e5
Remove debug output.
...
This commit was SVN r16016.
2007-08-30 13:29:41 +00:00
Gleb Natapov
435e7d80e9
Remove rc parameter from MCA_BTL_SM_FIFO_WRITE() macro. It cannot fail in
...
current implementation.
This commit was SVN r16015.
2007-08-30 13:21:52 +00:00
Gleb Natapov
690fb95bda
Cleanup send scheduling code.
...
This commit was SVN r16014.
2007-08-30 12:10:04 +00:00
Gleb Natapov
0b0f9d14aa
Mark send request complete on PML level only when absolutely sure there is
...
no more work associated with this request. No more outstanding completions or
packets and send scheduling isn't running in another thread.
This commit was SVN r16013.
2007-08-30 12:08:33 +00:00
Gleb Natapov
fe414047bd
registration may be freed inside mca_mpool_rdma_deregister().
...
This commit was SVN r16012.
2007-08-30 10:52:38 +00:00
Gleb Natapov
091862a25a
Protect access to mca_mpool_base_tree by a lock.
...
This commit was SVN r16011.
2007-08-30 10:51:02 +00:00
Brian Barrett
cfe737d1f9
Fix some mistaken error checks -- errors will be less than zero, not
...
greater than zero
This commit was SVN r16008.
2007-08-29 18:52:51 +00:00
Brian Barrett
f53b14bde5
George noted I had this logic completely backwards. Oops.
...
This commit was SVN r16005.
2007-08-29 16:18:04 +00:00
Gleb Natapov
eac2674f66
The inner voice tells me this is a typo.
...
This commit was SVN r16004.
2007-08-29 13:28:47 +00:00
Brian Barrett
f2d5d663cc
re-enable the disable-dlopen case
...
This commit was SVN r16003.
2007-08-29 03:28:29 +00:00
George Bosilca
756eee571e
Fix Coverty #24 . This test didn't make sense in this branch of the if.
...
This commit was SVN r16001.
2007-08-29 02:02:19 +00:00
Jeff Squyres
466394a878
We only care about the value of ret in the
...
!OMPI_ENABLE_PROGRESS_THREADS case. Reviewed by Brian.
This commit was SVN r16000.
2007-08-29 01:36:17 +00:00
Jeff Squyres
5628084fec
Fix Coverity CID 463: remove unused variable / dead code.
...
This commit was SVN r15999.
2007-08-29 01:30:15 +00:00
Jeff Squyres
8f10c285ef
Fix Coverity CID 466: remove unused variable / dead code.
...
This commit was SVN r15998.
2007-08-29 01:25:03 +00:00