Austen Lauria
dbc56758b6
Merge pull request #7802 from badgerious/mtl_ofi_cqread_break
...
mtl/ofi: break from progress loop when events are read
2020-07-06 09:20:07 -04:00
Jeff Squyres
a7ed13d74a
Merge pull request #7907 from cniethammer/null_pointer_arithmetic_fix
...
Fix null pointer arithmetic resulting in potential undefined behavior
2020-07-06 07:04:56 -04:00
Christoph Niethammer
a3483e4b71
Fix null pointer arithmetic resulting in potential undefined behavior
...
NULL pointer arithmetic is undefined behaviour in c.
The payload_ptr can be NULL in the moment when mpool is not initialized.
References from the c11 standard:
- 6.5.6 Additive operators
- 6.3.2.3 Pointers
Signed-off-by: Christoph Niethammer <niethammer@hlrs.de>
2020-07-03 22:18:17 +02:00
Jeff Squyres
e547e2d3ea
Merge pull request #7905 from cniethammer/integer_shift_fix
...
Fix shifting signed integer
2020-07-02 14:35:40 -04:00
Christoph Niethammer
8483ec41ab
Fix shifting signed integer
...
Shifting signed int will lead to undefined behavior in case of 1<<31 here
Signed-off-by: Christoph Niethammer niethammer@hlrs.de
2020-07-02 17:43:45 +02:00
Austen Lauria
d1a9c8a092
Merge pull request #7904 from cniethammer/delete_duplicate_cpuset_initializer
...
Fix initialization warning reported by clang-10
2020-07-02 11:13:18 -04:00
Christoph Niethammer
6ac111c6dc
Fix initialization warning reported by clang-10
...
Delete duplicate initializer for cpuset in opal_process_info.
Signed-off-by: Christoph Niethammer <niethammer@hlrs.de>
2020-07-02 15:15:54 +02:00
Austen Lauria
410596ee1c
Merge pull request #7680 from janjust/oshmem-default-nb-params
...
oshmem spml ucx: set default nonblocking put/get progress thresholds
2020-06-30 13:56:15 -04:00
Austen Lauria
9b86f1442a
Merge pull request #7823 from jsquyres/pr/put-osc-pt2pt-back
...
Fix typos in OSC RDMA BTL allowlist
2020-06-30 10:55:16 -04:00
Austen Lauria
b6b300d25d
Merge pull request #6784 from abouteiller/export/event-infloop
...
Address a race condition in libevent select.
2020-06-30 10:26:57 -04:00
Todd Kordenbrock
4358e75a75
Merge pull request #7866 from tkordenbrock/topic/master/portals4.fix-inappropriate-use-of-abort
...
portals4: fix inappropriate use of abort() in mtl-portals4 and coll-portals4 components
2020-06-30 08:46:03 -05:00
Austen Lauria
868eee31c1
Merge pull request #7883 from hoopoepg/topic/fixed-potential-deadlock-wpool
...
UCX/WPOOL: fixed potential deadlock
2020-06-29 17:21:39 -04:00
Austen Lauria
3ed466e629
Merge pull request #7800 from abouteiller/mpi-next/errors_abort
...
MPI4: Add ERRORS_ABORT infrastructure
2020-06-29 15:45:29 -04:00
Austen Lauria
a26e494953
Merge pull request #7882 from devreal/osc-rdma-noncontig-requests
...
osc rdma: check for outstanding fragments before completing a request (II)
2020-06-29 09:51:47 -04:00
Sergey Oblomov
a383312393
UCX/WPOOL: fixed potential deadlock
...
- fixed funcs:
opal_common_ucx_wpmem_putget
opal_common_ucx_wpmem_cmpswp
opal_common_ucx_wpmem_post
opal_common_ucx_wpmem_fetch
opal_common_ucx_wpmem_fetch_nb
Signed-off-by: Sergey Oblomov <sergeyo@mellanox.com>
2020-06-29 13:40:50 +03:00
Ralph Castain
f565ecf80a
Merge pull request #7886 from rhc54/topic/sync
...
Sync ot PMIx/PRRTE master branches
2020-06-27 19:59:01 -07:00
Ralph Castain
ba27fb79b5
Sync ot PMIx/PRRTE master branches
...
Signed-off-by: Ralph Castain <rhc@pmix.org>
2020-06-27 16:50:09 -07:00
Sergey Oblomov
34f2f6af84
UCX/WPOOL: fixed potential deadlock
...
- fixed potential deadlock in error processing
Signed-off-by: Sergey Oblomov <sergeyo@mellanox.com>
2020-06-27 15:19:01 +03:00
Joseph Schuchart
caed3b2eed
osc rdma: check for outstanding fragments before completing a request in ompi_osc_rdma_put_complete_flush as well
...
Signed-off-by: Joseph Schuchart <schuchart@hlrs.de>
2020-06-26 22:19:21 +02:00
Austen Lauria
5fa7ca7c15
Merge pull request #7858 from tkordenbrock/topic/master/portals4.call-pml-add_procs
...
mtl-portals4: use the active PML to call add_procs()
2020-06-26 14:56:57 -04:00
Christoph Niethammer
f0f206b247
Merge pull request #7673 from cniethammer/uct-supported-version-update
...
Accept UCX 1.8 in configure of btl/uct
2020-06-26 20:53:36 +02:00
Jeff Squyres
4c9c936e74
Merge pull request #7879 from jsquyres/pr/common-ofi-fix-debug
...
common_ofi: fix preprocessor macro typo
2020-06-26 11:31:39 -04:00
Jeff Squyres
f64c30e93c
common_ofi: fix preprocessor macro typo
...
Signed-off-by: Jeff Squyres <jsquyres@cisco.com>
2020-06-26 07:23:27 -07:00
Joseph Schuchart
2c36d37033
Merge pull request #7871 from devreal/osc-ucx-rget-rput-fetch-alignment
...
OSC UCX: make sure no-op fetch in rget/rput is properly aligned
2020-06-26 15:58:51 +02:00
Artem Polyakov
fdf704c7c1
Merge pull request #7875 from devreal/osc-ucx-stray-free
...
OSC UCX: Remove stale free from merge conflict
2020-06-25 21:05:52 -07:00
Joseph Schuchart
1314ef7668
OSC UCX: Remove stale free from merge conflict
...
Signed-off-by: Joseph Schuchart <schuchart@hlrs.de>
2020-06-25 19:01:53 +02:00
Joseph Schuchart
634f67b216
Merge pull request #7843 from devreal/clang-tidy-free
...
Some fixups for issues detected by clang-tidy
2020-06-25 17:30:04 +02:00
Artem Polyakov
907f4e196a
Merge pull request #6980 from devreal/ucx-acc-singel-intrinsics
...
UCX osc: add support for acc_single_intrinsic
2020-06-25 07:39:42 -07:00
Joseph Schuchart
c1f7776341
OSC UCX: make sure no-op fetch in rget/rput is properly aligned
...
Signed-off-by: Joseph Schuchart <schuchart@hlrs.de>
2020-06-25 16:16:58 +02:00
Austen Lauria
7814f4195c
Merge pull request #7845 from devreal/stack-fixes
...
Fix unexpected optimizations detected by STACK
2020-06-25 08:15:09 -04:00
Austen Lauria
910a030d1c
Merge pull request #7854 from devreal/remove-opal-dataype-get-pack
...
Remove stale datatype functions from opal header
2020-06-25 08:07:48 -04:00
Todd Kordenbrock
04b94637dd
mtl-portals4: replace abort() with ompi_rte_abort()
...
coll-portals4: replace abort() with ompi_rte_abort()
Signed-off-by: Todd Kordenbrock <thkgcode@gmail.com>
2020-06-24 11:31:26 -05:00
Austen Lauria
90c9a0aa3e
Merge pull request #7848 from cniethammer/ineffective_out_of_bound_check_fix
...
Fix wrongly placed bounds check; mark failure as unlikely
2020-06-23 11:09:59 -04:00
Joseph Schuchart
e3b417c776
Add missing copyright header
...
Signed-off-by: Joseph Schuchart <schuchart@hlrs.de>
2020-06-23 12:41:52 +02:00
Joseph Schuchart
e215eff43d
UCX osc: atomic fetch-and-op only on 32 and 64bit values
...
Signed-off-by: Joseph Schuchart <schuchart@hlrs.de>
2020-06-23 12:41:52 +02:00
Joseph Schuchart
434c9055ee
UCX osc: fall back to get-compare-put for unsupported datatypes
...
Signed-off-by: Joseph Schuchart <schuchart@hlrs.de>
2020-06-23 12:41:52 +02:00
Joseph Schuchart
7d5a6e3e8b
UCX osc: safely load/store 64bit integer from variable size pointer
...
Signed-off-by: Joseph Schuchart <schuchart@hlrs.de>
2020-06-23 12:41:52 +02:00
Joseph Schuchart
824afac483
UCX common: add non-blocking compare-and-swap
...
Signed-off-by: Joseph Schuchart <schuchart@hlrs.de>
2020-06-23 12:41:52 +02:00
Joseph Schuchart
5f786bcce4
UCX osc: make MPI_Fetch_and_op non-blocking if possible
...
Signed-off-by: Joseph Schuchart <schuchart@hlrs.de>
2020-06-23 12:41:52 +02:00
Joseph Schuchart
d8696aa8c4
UCX osc: centralize decision on whether to use AMOs
...
Signed-off-by: Joseph Schuchart <schuchart@hlrs.de>
2020-06-23 12:41:52 +02:00
Joseph Schuchart
427d4bd226
UCX osc: do not acquire accumulate lock if exclusive lock was taken
...
Signed-off-by: Joseph Schuchart <schuchart@hlrs.de>
2020-06-23 12:41:52 +02:00
Joseph Schuchart
471d76777a
UCX osc: fence active operations before releasing accumulate lock and free memory if required
...
Signed-off-by: Joseph Schuchart <schuchart@hlrs.de>
2020-06-23 12:41:52 +02:00
Joseph Schuchart
4d7a3856fa
UCX osc: Use accumulate for operations/datatypes that are not covered by UCX
...
Signed-off-by: Joseph Schuchart <schuchart@hlrs.de>
2020-06-23 12:41:52 +02:00
Joseph Schuchart
899f58cef5
UCX osc: simplify output address computation
...
Signed-off-by: Joseph Schuchart <schuchart@hlrs.de>
2020-06-23 12:41:52 +02:00
Joseph Schuchart
d888b4fd76
UCX osc: correctly handle MPI_NO_OP
...
Signed-off-by: Joseph Schuchart <schuchart@hlrs.de>
2020-06-23 12:41:52 +02:00
Joseph Schuchart
7cfc0e71da
UCX osc: allow to asynchronously compare-and-swap
...
Signed-off-by: Joseph Schuchart <schuchart@hlrs.de>
2020-06-23 12:41:52 +02:00
Joseph Schuchart
557ae80858
UCX osc: allow for overlap with (some) request-based atomic operations
...
Signed-off-by: Joseph Schuchart <schuchart@hlrs.de>
2020-06-23 12:41:52 +02:00
Joseph Schuchart
1a3c6bbf35
UCX osc: re-use value returned by cswap to save additional get
...
Signed-off-by: Joseph Schuchart <schuchart@hlrs.de>
2020-06-23 12:41:52 +02:00
Joseph Schuchart
8606a02b87
UCX osc: fix macro parameter name usage in OMPI_OSC_UCX_REQUEST_RETURN
...
Signed-off-by: Joseph Schuchart <schuchart@hlrs.de>
2020-06-23 12:41:52 +02:00
Joseph Schuchart
d448efd49c
UCX osc: properly clean up requests in case of errors
...
Signed-off-by: Joseph Schuchart <schuchart@hlrs.de>
2020-06-23 12:41:52 +02:00