1
1

31085 Коммитов

Автор SHA1 Сообщение Дата
Jeff Squyres
bd9d7f815f .gitignore: ignore sym linked F08 profile bindings
A recent commit made the use_mpi_f08 bindings sym link into their
profile directory (just like we do for C and other bindings) instead
of having standalone PMPI-ized copies of the bindings.  Make sure to
.gitignore the sym linked files.

Signed-off-by: Jeff Squyres <jsquyres@cisco.com>
2020-11-01 13:21:31 -05:00
Jeff Squyres
6f2a5b91cd
Merge pull request #8162 from Colton-K/pr/MPI_C_batch2
Converted batch 2 of MPI_C* (MPI_Comm_accept - MPI_Comm_dup_with_info)
2020-10-31 13:20:14 -04:00
Colton Kammes
ee3bd5859e Converted batch 2 of MPI_C* (MPI_Comm_accept - MPI_Comm_dup_with_info)
Signed-off-by: Colton Kammes <ckammes@nd.edu>
2020-10-31 10:02:37 -04:00
Jeff Squyres
fe03602d1f
Merge pull request #8163 from jsquyres/pr/keyval-parse-tweaks
Minor fix to keyval_parse
2020-10-31 09:42:12 -04:00
Jeff Squyres
c7b968ef20
Merge pull request #6903 from ggouaillardet/topic/use-mpi-f08-profile
fortran/use-mpi-f08: generates PMPI bindings from the MPI bindings
2020-10-31 09:41:49 -04:00
Jeff Squyres
8ed1d28fb4 keyval_parse.c: update whitespace/comments
Slightly improve comments and update some whitespace.

No code or logic changes.

Signed-off-by: Jeff Squyres <jsquyres@cisco.com>
2020-10-31 04:16:00 -07:00
Jeff Squyres
eac0ab5c3a keyval_parse.c: ensure to init values
Coverity complained about uninitialized variables; ensure that they
are initialized to 0 in all cases.

Signed-off-by: Jeff Squyres <jsquyres@cisco.com>
2020-10-31 04:11:49 -07:00
Jeff Squyres
400c005d04
Merge pull request #8161 from Fangcong-Yin/latest_pr
Convert MPI_Gather.3in - MPI_Get_version.3in to md
2020-10-30 21:13:54 -04:00
Jeff Squyres
b239715f93
Merge pull request #8158 from Colton-K/pr/MPI_C_first_half
Converted first half of MPI_C* (from MPI_Cancel to MPI_Close_port)
2020-10-30 21:13:42 -04:00
Fangcong-Yin
d85bf3ae1a Convert MPI_Gather.3in - MPI_Get_version.3in to md
Signed-off-by: Fangcong Yin (fyin2@nd.edu)
2020-10-30 20:03:59 -04:00
Colton Kammes
a08f8d30dd Converted first half of MPI_C* (from MPI_Cancel to MPI_Close_port)
Signed-off-by: Colton Kammes <ckammes@nd.edu>
2020-10-30 18:25:22 -04:00
Jeff Squyres
dca2058e2f
Merge pull request #8144 from devreal/fix_opal_add_to_env_str_alloc
OPAL: fix string buffer allocation for large env variables
2020-10-30 14:39:01 -04:00
Jeff Squyres
25e47411e0
Merge pull request #8159 from jsquyres/pr/fix-coll-and-adapt-warnings
coll/adapt and coll/han: fix trivial compiler warnings
2020-10-30 14:34:16 -04:00
Jeff Squyres
f813656d24
Merge pull request #8154 from Fangcong-Yin/latest_pr
Convert MPI_File_write_ordered.3in - MPI_Free_mem.3in to md
2020-10-30 10:44:23 -04:00
Jeff Squyres
ee405ccaa5 coll/adapt and coll/han: fix trivial compiler warnings
Signed-off-by: Jeff Squyres <jsquyres@cisco.com>
2020-10-30 10:41:14 -04:00
Jeff Squyres
548f5dbe47
Merge pull request #8135 from Colton-K/pr/all-MPI_B
Convert rest of the MPI_B* man pages to Markdown
2020-10-30 10:30:51 -04:00
Fangcong-Yin
82081118d6 Convert MPI_File_write_ordered.3in - MPI_Free_mem.3in to md
Signed-off-by: Fangcong Yin (fyin2@nd.edu)

Convert MPI_File_write_ordered.3in - MPI_Free_mem.3in to md
Signed-off-by: Fangcong Yin (fyin2@nd.edu)

Convert MPI_File_write_ordered.3in - MPI_Free_mem.3in to md
Signed-off_by: Fangcong Yin (fyin2@nd.edu)
2020-10-30 10:11:19 -04:00
Joseph Schuchart
320a9a1660 OPAL: fix string buffer allocation for large env variables
Signed-off-by: Joseph Schuchart <schuchart@icl.utk.edu>
2020-10-30 14:28:23 +01:00
Colton Kammes
cded23fe9b Finished converting MPI_B section into markdown files
Signed-off-by: Colton Kammes <ckammes@nd.edu>
2020-10-30 09:19:01 -04:00
Gilles Gouaillardet
8c2b916048 fortran/use-mpi-tkr: revamp PMPI_* declarations
only declare MPI_* bindings and use macros to deduce the PMPI_* bindings

Signed-off-by: Gilles Gouaillardet <gilles@rist.or.jp>
2020-10-30 14:00:42 +09:00
Gilles Gouaillardet
e981e46446 fortran/use-mpi-ignore-tkr: revamp PMPI_* declarations
only declare MPI_* bindings and use macros to deduce the PMPI_* bindings

Signed-off-by: Gilles Gouaillardet <gilles@rist.or.jp>
2020-10-30 14:00:42 +09:00
Gilles Gouaillardet
c2e3df6d3e fortran/use-mpi-f08: simplify mod/mpi-f08-interfaces.h
have this file generated at configure time and use the
@OMPI_FORTRAN_IGNORE_TKR_PREDECL@ and @OMPI_FORTRAN_IGNORE_TKR_TYPE@
variable for buffer definitions

Signed-off-by: Gilles Gouaillardet <gilles@rist.or.jp>
2020-10-30 13:58:48 +09:00
Gilles Gouaillardet
5219241d13 fortran/use-mpi-f08: generates PMPI bindings from the MPI bindings
- via the OMPI_BUILD_MPI_PROFILING macro, avoid the need to have two distinct
   source files for MPI_* and PMPI_* bindings.
 - move the PMPI bindings into ompi/mpi/fortran/use-mpi-f08/profile.
 - remove an useless dependency to mpi-f08.lo
 - share most of mod/[p]mpi-f08-interfaces.F90 code in a single mod/mpi-f08-interfaces.h

Signed-off-by: Gilles Gouaillardet <gilles@rist.or.jp>
2020-10-30 13:58:48 +09:00
Jeff Squyres
3ba35c97ce
Merge pull request #8152 from jsquyres/pr/macos-portability-fixes
MacOS portability fixes
2020-10-29 09:33:47 -04:00
Jeff Squyres
89920bac4c getdate.sh: make the date(1) usage more portable
There are several different flavors of date(1) out there.  Try a few
different CLI options for date(1) to see which one works.

Signed-off-by: Jeff Squyres <jsquyres@cisco.com>
2020-10-29 06:26:12 -04:00
Jeff Squyres
ddf216b0a3 configure.ac: Add workaround on MacOS for "readlink -f"
MacOS does not have "readlink -f" or "realpath", so use the
MacOS-provided Python, which we know has os.path.realpath().

Signed-off-by: Jeff Squyres <jsquyres@cisco.com>
2020-10-28 22:47:28 -04:00
bosilca
d330551547
Merge pull request #8146 from bosilca/fix/han_coverity
Fix HAN issues reported by Coverity.
2020-10-28 18:40:14 -04:00
George Bosilca
154117515a Fix HAN issues reported by Coverity.
Signed-off-by: George Bosilca <bosilca@icl.utk.edu>
2020-10-28 15:44:16 -04:00
Jeff Squyres
00ccc9d936
Merge pull request #8136 from bmwiedemann/date
configury: make build reproducible
2020-10-28 07:42:31 -04:00
Gilles Gouaillardet
7b4e8ba4aa configury: make build Reproducible
If defined, use SOURCE_DATE_EPOCH environment variable; make the build
Reproducible by forcing timestamps.  See
https://reproducible-builds.org/docs/source-date-epoch/ for more
information.

Thanks Bernhard M. Wiedemann for bringing this to our attention.

Fixes open-mpi/ompi#3759

Signed-off-by: Gilles Gouaillardet <gilles@rist.or.jp>
Signed-off-by: Bernhard M. Wiedemann <bwiedemann@suse.de>
Signed-off-by: Jeff Squyres <jsquyres@cisco.com>
2020-10-28 03:15:38 +01:00
Jeff Squyres
593a918379
Merge pull request #8133 from Fangcong-Yin/latest_pr
Convert MPI_Bcast.3in to markdown
2020-10-27 10:22:58 -04:00
Fangcong-Yin
c2ef4af7b6 Convert MPI_Bcast.3in to markdown
Signed-off-by: Fangcong Yin (fyin2@nd.edu)
2020-10-26 18:53:00 -04:00
Howard Pritchard
487bbf31ba
Merge pull request #8052 from hkuno/john.l.byrne/ofi_create_recv_tag_mask
use sync_send mask for ofi_create_recv_tag
2020-10-26 15:56:35 -06:00
Jeff Squyres
7c36b45847 opal_functions.m4: remove redundant code
This code was invoked twice.  Leave it solely in OPAL_CONFIGURE_SETUP,
which is invoked before OPAL_BASIC_SETUP.

Signed-off-by: Jeff Squyres <jsquyres@cisco.com>
2020-10-26 10:55:31 -07:00
Raghu Raja
2e5303f618
Merge pull request #8124 from rajachan/peek-probe-errorflow
mtl/ofi: Fix erroneous FI_PEEK/FI_CLAIM usage
2020-10-26 10:42:12 -07:00
bosilca
ce97090673
Merge pull request #7735 from bosilca/coll/han
A hierarchical, architecture-aware collective communication module
2020-10-26 00:07:03 -04:00
George Bosilca
cc6432b4a2 Fix partial packing of non data elements.
There was a bug allowing for partial packing of non-data elements (such as loop
and end_loop markers) during the exit condition of a pack/unpack call. This has
basically no meaning. Prevent this bug from happening by making sure the element
point to a data before trying to partially pack it.

Signed-off-by: George Bosilca <bosilca@icl.utk.edu>
2020-10-25 18:15:09 -04:00
George Bosilca
16b49dc5b3 A complete overhaul of the HAN code.
Among many other things:
- Fix an imbalance bug in MPI_allgather
- Accept more human readable configuration files. We can now specify
  the collective by name instead of a magic number, and the component
  we want to use also by name.
- Add the capability to have optional arguments in the collective
  communication configuration file. Right now the capability exists
  for segment lengths, but is yet to be connected with the algorithms.
- Redo the initialization of all HAN collectives.

Cleanup the fallback collective support.
- In case the module is unable to deliver the expected result, it will fallback
  executing the collective operation on another collective component. This change
  make the support for this fallback simpler to use.
- Implement a fallback allowing a HAN module to remove itself as
  potential active collective module, and instead fallback to the
  next module in line.
- Completely disable the HAN modules on error. From the moment an error is
  encountered they remove themselves from the communicator, and in case some
  other modules calls them simply behave as a pass-through.

Communicator: provide ompi_comm_split_with_info to split and provide info at the same time
Add ompi_comm_coll_preference info key to control collective component selection

COLL HAN: use info keys instead of component-level variable to communicate topology level between abstraction layers
- The info value is a comma-separated list of entries, which are chosen with
  decreasing priorities. This overrides the priority of the component,
  unless the component has disqualified itself.
  An entry prefixed with ^ starts the ignore-list. Any entry following this
  character will be ingnored during the collective component selection for the
  communicator.
  Example: "sm,libnbc,^han,adapt" gives sm the highest preference, followed
  by libnbc. The components han and adapt are ignored in the selection process.
- Allocate a temporary buffer for all lower-level leaders (length 2 segments)
- Fix the handling of MPI_IN_PLACE for gather and scatter.

COLL HAN: Fix topology handling
 - HAN should not rely on node names to determine the ordering of ranks.
   Instead, use the node leaders as identifiers and short-cut if the
   node-leaders agree that ranks are consecutive. Also, error out if
   the rank distribution is imbalanced for now.

Signed-off-by: Xi Luo <xluo12@vols.utk.edu>
Signed-off-by: Joseph Schuchart <schuchart@icl.utk.edu>
Signed-off-by: George Bosilca <bosilca@icl.utk.edu>
2020-10-25 18:13:16 -04:00
Jeff Squyres
6304c3f57c
Merge pull request #8131 from jsquyres/pr/include-mpi-man5-markdown-nroffed-pages
ompi/man5: include nroff-ified pages in tarball
2020-10-25 17:49:22 -04:00
Jeff Squyres
105636ceef
Merge pull request #8134 from Colton-K/pr/MPI_Barrier-to-md
Converted MPI_Barrier.3in to MPI_Barrier.md
2020-10-25 17:48:59 -04:00
Colton Kammes
f14a6c5089 Converted MPI_Barrier.3in to MPI_Barrier.md
Signed-off-by: Colton Kammes <ckammes@nd.edu>
2020-10-25 14:12:31 -04:00
Jeff Squyres
ca524134d4 ompi/man5: include nroff-ified pages in tarball
Add a line that was accidentally left out that includes the generated
nroff pages (from the Markdown pages) in the dist tarball.

The lack of these files in the dist tarball was causing configure to
fail a test and therefore conclude that we need to have pandoc
installed.  Put differently: it's a specific goal that we do not want
end users to have to have Pandoc installed -- all Markdown files must
generate their nroff equivalents and have those nroff files included
in the distribution tarball.

Signed-off-by: Jeff Squyres <jsquyres@cisco.com>
2020-10-24 10:39:50 -07:00
Jeff Squyres
d52bf35847
Merge pull request #8128 from jsquyres/pr/in-space-no-one-hears-you-scream
Check for spaces in prefix, srcdir, and builddir
2020-10-24 13:25:45 -04:00
Jeff Squyres
8841b12489 configure: abort if dirs with spaces are used
Abort early if the source directory, build directory, or prefix
contains spaces (either the supplied directory, or the canonicalized
version of the directory).  This prevents users from getting cryptic
errors later in configure and/or make.

Signed-off-by: Jeff Squyres <jsquyres@cisco.com>
2020-10-24 06:12:52 -07:00
Jeff Squyres
8f13c3b587 opal_get_version.m4: properly quote dir args
Make sure to surround directory variables with quotes so that they
function properly, even if there's spaces in the directory name.

While Open MPI doesn't generally support directory names with spaces,
this fix at least allows `autogen.pl` to complete successfully.

Signed-off-by: Jeff Squyres <jsquyres@cisco.com>
2020-10-24 06:11:34 -07:00
Raghu Raja
39f8a86b65 mtl/ofi: Fix erroneous FI_PEEK/FI_CLAIM usage
The current iprobe/improbe implementations merely checks the return
code on the posted receive operation to tell if there is a match or
not. This commit moves the check to the probe's error callback
instead. Per the semantics defined in libfabric, the peek operation is
asynchronous and the results are to be fetched from the completion
queue. If no message is found matching the tags specified in the peek
request, then a completion queue error entry with err field set to
FI_ENOMSG will be available.

Signed-off-by: Raghu Raja <craghun@amazon.com>
2020-10-23 17:07:16 +00:00
Brian Barrett
9afcb8e2ab
Merge pull request #8113 from rajachan/empty-error-cq
mtl/ofi: Do not fail if error CQ is empty
2020-10-21 15:38:00 -07:00
Raghu Raja
415dddb9af mtl/ofi: Do not fail if error CQ is empty
In multi-threaded scenarios, any thread that attempts to read a CQ
when there's a pending error CQ entry gets an -FI_EAVAIL. Without
any serialization here (which is okay, since libfabric will protect
access to critical CQ objects), all threads proceed to read from the
error CQ, but only one thread fetches the entry while others get
-FI_EAGAIN indicating an empty queue, which is not erroneous.

Signed-off-by: Raghu Raja <craghun@amazon.com>
2020-10-21 21:27:29 +00:00
Jeff Squyres
47c03bccd0
Merge pull request #8110 from bwbarrett/dist/master
Add UCX crash note from v4.0.x to master
2020-10-21 17:07:39 -04:00
Howard Pritchard
2a606fbde3 add blurb about issue 7968 to the README
related to #7968

Signed-off-by: Howard Pritchard <howardp@lanl.gov>
(cherry picked from commit 04f853d53d657b14f055c4d87a031829015a6929)
Signed-off-by: Brian Barrett <bbarrett@amazon.com>
2020-10-21 19:25:52 +00:00