Due to IF_NAMESIZE being a reused and conditionally defined macro,
issues could arise from macro mismatches. In particular, in cases where
opal/util/if.h is included, but net/if.h is not, IF_NAMESIZE will be 32.
If net/if.h is included on Linux systems, IF_NAMESIZE will be 16. This
can cause a mismatch when using the same macro on a system. Thus
different parts of the code can have differring ideas on the size of a
structure containing a char name[IF_NAMESIZE]. To avoid this error case,
we avoid reusing the IF_NAMESIZE macro and instead define our own as
OPAL_IF_NAMESIZE.
Signed-off-by: William Zhang <wilzhang@amazon.com>
Use linear with sync alltoall algorithm for certain message/comm size
ranges. Does not affect default fixed decision, unless HPCX (with its
custom parameters) is used or corresponding mca is set.
Signed-off-by: Mikhail Brinskii <mikhailb@mellanox.com>
In OMPI 2.1.2, buildrpm.sh could work with a value of rpmtopdir that was
set in the environment. In newer versions this is no longer true,
causing such values to be ignored. This patch adds a new argument to
buildrpm.sh, -R, which allows the user to specify where to build the
RPMs.
Signed-off-by: Michael Heinz <michael.william.heinz@intel.com>
make-authors.pl checks that .git exists and is a directory before
getting the git log - but when a repo is checked out as a submodule of a
larger repository, .git is not a directory, it's just a text file. This
can cause make-authors.pl to terminate inappropriately.
Author: Michael Heinz <michael.william.heinz@intel.com>
Signed-off-by: Michael Heinz <michael.william.heinz@intel.com>
The Open MPI code base assumed that asprintf always behaved like
the FreeBSD variant, where ptr is set to NULL on error. However,
the C standard (and Linux) only guarantee that the return code will
be -1 on error and leave ptr undefined. Rather than fix all the
usage in the code, we use opal_asprintf() wrapper instead, which
guarantees the BSD-like behavior of ptr always being set to NULL.
In addition to being correct, this will fix many, many warnings
in the Open MPI code base.
Signed-off-by: Brian Barrett <bbarrett@amazon.com>
The embedded PMIx Automake minimum version is already 1.13.4, so to
autogen.pl Open MPI successfully, you already have to have Autoamek
1.13.4. So we might as well make it official (i.e., bump Open MPI's
Automake minimum to match the Automake minimum in the embedded PMIx).
Signed-off-by: Jeff Squyres <jsquyres@cisco.com>
A race condition exists based on whether or not the userdata object attached to a hwloc_obj_t has been initialized. These objects are setup whenever we scan for resources under that location. You therefore must not set a variable to the pointer to the userdata object and then call a function that will initialize the data in it - you need to set the variable after the function call, and protect against a NULL pointer
Signed-off-by: Ralph Castain <rhc@open-mpi.org>
The html man page builder creates a web page for every
man page generated by our releases. We then check all
those pages into the ompi-www repo. Force the build
to skip case-conflicting pages (ie, mpiCC because it
conflicts with mpicc), even if building on Linux, so that
ompi-www continues to be sane when cloned onto MacOS.
Signed-off-by: Brian Barrett <bbarrett@amazon.com>
* check that the command succeeds when pre-positioning the file to ensure there isn't an error somewhere in the execution
* properly define srun cmd line options
* terminate the orte-dvm only when it is actually in operation so prun doesn't generate spurious error messages
Signed-off-by: Ralph Castain <rhc@open-mpi.org>
Forgot as part of #3970 to disable use of XRC
recv bufs by default in LANL platform config
file.
related to #4300
Signed-off-by: Howard Pritchard <howardp@lanl.gov>
The nightly tarball scripts have been moved to the ompi-scripts
repo (and rewritten), so are no longer needed in the ompi
repo. Clean up some bits to make life a bit less confusing.
Signed-off-by: Brian Barrett <bbarrett@amazon.com>
* This script will search for all of the `Makefile.am` files in each
of the project-level components. Then it adds the project-level
library to `mca_FRAMEWORK_COMPONENT_la_LIBADD`.
- If the library is already in the LIBADD list then it's skipped.
So it is safe to run multiple times on the same codebase.
Signed-off-by: Joshua Hursey <jhursey@us.ibm.com>
Per discussion at the Summer 2017 developers meeting, generate
the AUTHORS list at make dist time, rather than trying to
keep it up to date and merge on the branches by hand. While
most of the data is generated from git, the organization list
was maintained by hand. The general feeling at the meeting was
that the organization list was not adding value and there were
concrete cases where it involved much chasing by the RMs, so
it has been removed.
Signed-off-by: Brian Barrett <bbarrett@amazon.com>
Along with using git status and related commands to find a list of
modified files to update the copyright on, this adds the option of
using a manually created list from a file (one filename per line).
Signed-off-by: Mark Allen <markalle@us.ibm.com>
