Ralph Castain
885fcac488
Forward declaration must match eventual function - both must be static
...
Refs trac:3763
This commit was SVN r30082.
The following Trac tickets were found above:
Ticket 3763 --> https://svn.open-mpi.org/trac/ompi/ticket/3763
2013-12-25 02:28:22 +00:00
Ralph Castain
85f2429819
Ensure the ipv6 lists get initialized and finalized
...
cmr=v1.7.4:reviewer=jsquyres
This commit was SVN r30081.
2013-12-24 17:24:39 +00:00
Ralph Castain
2e08219cac
Silence the valgrind report from the OOB
...
Refs trac:4033
This commit was SVN r30080.
The following Trac tickets were found above:
Ticket 4033 --> https://svn.open-mpi.org/trac/ompi/ticket/4033
2013-12-24 17:06:45 +00:00
Ralph Castain
65654325ef
Continue the quest for valgrind silence - ensure that the db modules are given a chance to cleanup, and that the hash module releases all of its memory
...
cmr=v1.7.5:reviewer=jsquyres:subject=Silence db framework valgrind reports
This commit was SVN r30079.
2013-12-24 17:03:45 +00:00
Ralph Castain
81df8d09ca
Avoid use of PMI components when launched via mpirun as this is just unnecessary overhead that can cause confusion.
...
cmr=v1.7.4:reviewer=miked:subject=Avoid use of PMI components when launched via mpirun
This commit was SVN r30078.
2013-12-24 16:32:31 +00:00
Mike Dubman
cc4ab51b71
SHMEM: silence warning
...
Refs trac:3763
This commit was SVN r30077.
The following Trac tickets were found above:
Ticket 3763 --> https://svn.open-mpi.org/trac/ompi/ticket/3763
2013-12-24 16:18:48 +00:00
Ralph Castain
01ee5f380b
Remove debug - problem has been identified
...
Refs trac:4026
This commit was SVN r30075.
The following Trac tickets were found above:
Ticket 4026 --> https://svn.open-mpi.org/trac/ompi/ticket/4026
2013-12-24 15:22:18 +00:00
Jeff Squyres
12d23e9c92
Left out valid end-of-string comparison in r30073.
...
Refs trac:4031
This commit was SVN r30074.
The following SVN revision numbers were found above:
r30073 --> open-mpi/ompi@6003702a51
The following Trac tickets were found above:
Ticket 4031 --> https://svn.open-mpi.org/trac/ompi/ticket/4031
2013-12-24 12:07:56 +00:00
Jeff Squyres
6003702a51
Minor improvements to the usnic BTL:
...
1. Fix ompi_info memory leak in usnic BTL: do not allocate memory in
the component register function, because ompi_info only calls the
component register function and then dlclose's the component -- it
does not call component finalize. Instead, defer parsing the MCA
param (and alloc'ing memory) until the component init function so
that any allocated memory can be freed in the component close
function.
1. Also add a new check to ensure that we actually have some part
numbers to check. Add a show_help message if we don't find any
vendor part IDs to check.
1. Add a verbose output if usnic disqualifies itself from selection
because THREAD_MULTIPLE was specified.
cmr=v1.7.5:reviewer=dgoodell
This commit was SVN r30073.
2013-12-24 11:57:35 +00:00
Jeff Squyres
365ce2cd03
Fix minor MPI thread memory leak / fix valgrind still-reachable warning.
...
cmr=v1.7.5:reviewer=brbarret:subject=Fix minor MPI thread memory leak
This commit was SVN r30072.
2013-12-24 11:05:51 +00:00
Jeff Squyres
ce02002a5e
Free minor memory leak / squash valgrind still-reachable warning.
...
cmr=v1.7.5:reviewer=rhc
This commit was SVN r30071.
2013-12-24 11:04:38 +00:00
Jeff Squyres
bceaa347b1
Label what the GAP_TEST macro does. Print more meaningful output as
...
to what the test is doing (i.e., checking for gaps between struct fields).
This commit was SVN r30070.
2013-12-24 11:03:24 +00:00
Ralph Castain
38f46641ce
Ensure the recv handler has been initialized
...
Refs trac:4026
This commit was SVN r30068.
The following Trac tickets were found above:
Ticket 4026 --> https://svn.open-mpi.org/trac/ompi/ticket/4026
2013-12-24 06:09:45 +00:00
Ralph Castain
bb80625a8a
Add missing var initialization
...
cmr=v1.7.4:reviewer=ompi-gk1.7
This commit was SVN r30063.
2013-12-24 00:02:22 +00:00
Ralph Castain
65228d3571
Don't use "size_t" for the nbytes field in the header - use uint32_t to ensure that ntohl/htonl correctly match it
...
Refs trac:4026
This commit was SVN r30062.
The following Trac tickets were found above:
Ticket 4026 --> https://svn.open-mpi.org/trac/ompi/ticket/4026
2013-12-23 21:39:49 +00:00
Ralph Castain
6a432ca092
Per patch from Ashley Pittman, correct the name of the struct within which the code is looking for "mtc".
...
cmr=v1.7.4:reviewer=bosilca:subject=Correct name of struct
This commit was SVN r30061.
2013-12-23 21:32:16 +00:00
Ralph Castain
7d8c0459a4
Attempt to debug hang that is hitting some environments. Posting to 1.7.4 as a placeholder for the eventual solution
...
cmr=v1.7.4:reviewer=rhc
This commit was SVN r30060.
2013-12-23 19:57:05 +00:00
Ralph Castain
9eebb79d54
Cleanup a loop that couldn't possibly execute as the outer loop indexed was being reused by the inner loops, leaving the index at the cutoff point after the first iteration
...
cmr=v1.7.4:reviewer=edgar:subject=Cleanup loop in sharedfp
This commit was SVN r30059.
2013-12-23 18:34:34 +00:00
Nathan Hjelm
3be4536d9b
Cleanup various leaks in ompi_info reported by valgrind.
...
cmr=v1.7.4:reviewer=jsquyres
This commit was SVN r30058.
2013-12-23 17:47:43 +00:00
Ralph Castain
f329f170e4
Remove stale directories that were zero'd out by some prior patch, but not svn rm'd
...
This commit was SVN r30057.
2013-12-23 15:29:33 +00:00
Mike Dubman
2e138ddd05
OSHMEM: Use MPI calls for mkey exchange
...
fixed by Alex, reviewed by miked
Refs: 3763
This commit was SVN r30056.
2013-12-23 09:20:42 +00:00
Mike Dubman
80f4e02e0a
Several changes:
...
- Modifications to coll/hcoll component related to the changes in the libhcoll API.
Now, hcoll_destroy_context accepts one more parameter that indicates if the context was
really destroyed as a result of the call.
This new "non-blocking" context destruction fixes hang discovered in IMB with mcast enabled.
- Clean up all the left contexts (if any) on the comm_world destruction.
fixed by Val, reviewed by miked
cmr=v1.7.4:reviewer=ompi-rm1.7
This commit was SVN r30055.
2013-12-23 06:57:12 +00:00
Jeff Squyres
1448522d15
In an MPI_IBCAST, we cannot shortcut if there's only 1 process.
...
cmr=v1.7.4:reviewer=brbarret:subject=Fix IBCAST for COMM_SELF
-This line, and those below, will be ignored--
M c/ibcast.c
This commit was SVN r30054.
2013-12-22 22:55:58 +00:00
Jeff Squyres
71ec6c1617
Remove unnecessary "mpi.h"; move opal headers to the top.
...
This commit was SVN r30053.
2013-12-22 20:38:43 +00:00
George Bosilca
24879f9def
Code cleanup while chasing valgrind complaints.
...
This commit was SVN r30048.
2013-12-21 23:28:14 +00:00
George Bosilca
b324884375
This might explain the current difficulties with the mapping...
...
This commit was SVN r30047.
2013-12-21 23:26:13 +00:00
George Bosilca
5aa0837250
Init all fields (valgrind cleanup).
...
This commit was SVN r30046.
2013-12-21 23:24:29 +00:00
George Bosilca
38cbaeaa82
Try to impose a little bit of consistency on how we parse lists of
...
modules by enforcing the use of OPAL list accessors.
This commit was SVN r30045.
2013-12-21 23:23:33 +00:00
Ralph Castain
264150872b
Add a bunch of debug output to the OOB connection completion code so we can track down a handshake problem. Available in optimized builds as well as debug ones by setting -mca oob_base_verbose 10
...
No review will be required as this is just debug code for those helping us debug the 1.7.4 release candidates
cmr-=v1.7.4:reviewer=ompi-gk1.7
This commit was SVN r30043.
2013-12-21 16:09:26 +00:00
Ralph Castain
042ed95e4e
Remove an annoying warning. If the user excludes a non-existent interface, there is no reason to warn - the interface may simply not exist on that node.
...
cmr=v1.7.4:reviewer=jsquyres:subject=Remove an annoying warning
This commit was SVN r30042.
2013-12-21 01:51:11 +00:00
Ralph Castain
9c768df8b8
Resolve an unexpected behavior in hostfile allocations. Now that we filter allocations to determine what will be used for mapping, let the initial global pool be the union of nodes from all sources (default hostfile, hostfiles, and dash-hosts). Each app will filter down to only those specified for it using its own hostfile and dash-host options.
...
cmr=v1.7.4:reviewer=jsquyres:subject=Resolve an unexpected behavior in hostfile allocations
This commit was SVN r30040.
2013-12-21 01:38:27 +00:00
Jeff Squyres
6f6c3cc21c
Per http://www.open-mpi.org/community/lists/devel/2013/12/13532.php ,
...
r30016 was not enough to solve the issue.
So properly prefix all the shell variables used in opal_setup_java.m4
(one of them had an orte_ prefix -- oops!). Now we won't get any
conflicts.
Refs trac:4015
This commit was SVN r30037.
The following SVN revision numbers were found above:
r30016 --> open-mpi/ompi@35dfd26f9e
The following Trac tickets were found above:
Ticket 4015 --> https://svn.open-mpi.org/trac/ompi/ticket/4015
2013-12-20 22:42:49 +00:00
Adrian Reber
53a70fe87f
Trying to get the C/R code to compile again. (send_*_nb)
...
This patch changes all send/send_buffer occurrences in the C/R code
to send_nb/send_buffer_nb.
The new code compiles but does not work.
Changes from V1:
* #ifdef out the code (so it is preserved for later re-design)
* marked the broken C/R code with ENABLE_FT_FIXED
Changes from V2:
* just replace the blocking calls with the non-blocking calls
* all #ifdef's introduced in V1 are gone
* send_* returns error code or ORTE_SUCCESS (not the number of bytes)
This commit was SVN r30036.
2013-12-20 21:58:28 +00:00
Adrian Reber
a3813d37c7
Trying to get the C/R code to compile again. (recv_*_nb)
...
This patch changes all recv/recv_buffer occurrences in the C/R code
to recv_nb/recv_buffer_nb.
The old code is still there but disabled using ifdefs (ENABLE_FT_FIXED).
The new code compiles but does not work.
Changes from V1:
* #ifdef out the code (so it is preserved for later re-design)
* marked the broken C/R code with ENABLE_FT_FIXED
Changes from V2:
* only #ifdef out the code where the behaviour is changed
(used to be blocking; now non-blocking)
This commit was SVN r30035.
2013-12-20 21:05:40 +00:00
Rolf vandeVaart
695d854cd8
Fix return value.
...
This commit was SVN r30034.
2013-12-20 20:57:04 +00:00
Ralph Castain
31248c0985
Correctly add support for the "env" MPI_Info key during comm_spawn, update the "map-by", "rank-by", and "bind-to" Info key behaviors to match the new mapping/ranking/binding system, and update all docs and comments to match.
...
Fix comm_spawn on a single host - with the new default mapping scheme, we were incorrectly computing the number of procs to put on the node.
Refs trac:4003
This commit was SVN r30033.
The following Trac tickets were found above:
Ticket 4003 --> https://svn.open-mpi.org/trac/ompi/ticket/4003
2013-12-20 20:42:39 +00:00
Rolf vandeVaart
4cd1958deb
Fix so we do not get warnings when running on system without CUDA software installed and CUDA-aware compiled in.
...
This commit was SVN r30032.
2013-12-20 20:39:25 +00:00
Ralph Castain
0098f9f51a
Remove remaining stale references
...
Refs trac:4006
This commit was SVN r30027.
The following Trac tickets were found above:
Ticket 4006 --> https://svn.open-mpi.org/trac/ompi/ticket/4006
2013-12-20 17:48:28 +00:00
Dave Goodell
bd901a68ed
usnic: fix 'fls' warnings+errors
...
The old version caused compilation errors on Solaris. Thanks to Paul
Hargrove for testing and reporting the bug:
http://www.open-mpi.org/community/lists/devel/2013/12/13520.php
cmr=v1.7.4:reviewer=jsquyres
This commit was SVN r30025.
2013-12-20 17:37:22 +00:00
Mike Dubman
92fdbbd7b1
Implementing comment #1 from http://www.open-mpi.org/community/lists/devel/2013/12/13523.php
...
Refs trac:4011
This commit was SVN r30024.
The following Trac tickets were found above:
Ticket 4011 --> https://svn.open-mpi.org/trac/ompi/ticket/4011
2013-12-20 16:53:28 +00:00
Jeff Squyres
4cfb24069e
Update svn:ignore to ignore *.log and *.trs files generated by "make check"
...
This commit was SVN r30023.
2013-12-20 16:40:30 +00:00
Jeff Squyres
f026bdb68b
Remove unused variable
...
Refs trac:4004
This commit was SVN r30021.
The following Trac tickets were found above:
Ticket 4004 --> https://svn.open-mpi.org/trac/ompi/ticket/4004
2013-12-20 16:16:24 +00:00
George Bosilca
178c340992
rearrange the fields to remove a gap in the datatype.
...
This commit was SVN r30020.
2013-12-20 15:57:56 +00:00
George Bosilca
7178492dd5
Correctly initialize and finalize all the datatype classes. No memory leaks on the
...
datatype engine subsists.
This commit was SVN r30019.
2013-12-20 15:57:10 +00:00
George Bosilca
a85194ae96
Cleanup all the datatype test to avoid any memory leaks or RUI from valgrind.
...
This commit was SVN r30018.
2013-12-20 15:55:09 +00:00
Jeff Squyres
802c89680a
Protect hwloc/configure/m4's use of some temporary shell variables
...
Fix problem reported by Paul Hargrove:
http://www.open-mpi.org/community/lists/devel/2013/12/13519.php
cmr=v1.7.4:reviewer=brbarret
This commit was SVN r30013.
2013-12-20 14:48:40 +00:00
Ralph Castain
71b52fe861
Ensure that comm_spawn'd procs get user-specified forwarded envars
...
Thanks to Tim Miller for reporting the regression from the 1.6 series
cmr=v1.7.4:reviewer=jsquyres:subject=Ensure that comm_spawn'd procs get user-specified forwarded envars
This commit was SVN r30012.
2013-12-20 14:47:35 +00:00
Ralph Castain
7cf0fc5578
One more round of sys_limit fixes...sigh
...
Refs trac:4010
This commit was SVN r30011.
The following Trac tickets were found above:
Ticket 4010 --> https://svn.open-mpi.org/trac/ompi/ticket/4010
2013-12-20 14:44:51 +00:00
Ralph Castain
e49c16b975
Grrr....use #if instead of #ifdef
...
Refs trac:4010
This commit was SVN r30010.
The following Trac tickets were found above:
Ticket 4010 --> https://svn.open-mpi.org/trac/ompi/ticket/4010
2013-12-20 14:24:26 +00:00
Ralph Castain
6e6351959d
Check for all the RLIMIT_foo constants that we use, and update the limit checks to use the new #define values. Fix a bug where failure of some might lead to incorrect bracketing.
...
Refs trac:4010
This commit was SVN r30009.
The following Trac tickets were found above:
Ticket 4010 --> https://svn.open-mpi.org/trac/ompi/ticket/4010
2013-12-20 14:09:43 +00:00