Mikhail Kurnosov
82299a9c04
coll: reduce_scatter_block: add recursive halving algorithm
...
Signed-off-by: Mikhail Kurnosov <mkurnosov@gmail.com>
2018-05-15 08:20:32 +07:00
Jeff Squyres
93930a2853
Merge pull request #5160 from RandomDSdevel/fix-5015
...
config/opal_setup_java.m4: Fix #5015 .
2018-05-09 18:58:17 -04:00
Bryce Glover
4a05c7e29f
config/opal_setup_java.m4: Fix #5015 .
...
That PR accidentally changed Open MPI's build configuration infrastruc-
ture's Java toolchain detection logic so that it would, as reported by @bosilca
in https://github.com/open-mpi/ompi/pull/5001#issuecomment-387803012 and tracked down by me in https://github.com/open-mpi/ompi/pull/5001#issuecomment-387851005 , abort your entire
in-progress Open MPI build when it failed to find an OS X/macOS JDK instead of
simply falling back to checking for a JDK in locations where it would be found
on other platforms. _Oops…!_
Signed-off-by: Bryce Glover <RandomDSdevel@gmail.com>
2018-05-09 17:37:33 -04:00
Nathan Hjelm
6093f2dcb4
Merge pull request #5159 from hjelmn/osc_rdma_fx
...
osc/rdma: fix SEGV will null origin in FOP in debug build
2018-05-08 16:15:49 -06:00
Nathan Hjelm
cf585d725c
osc/rdma: fix SEGV will null origin in FOP in debug build
...
Signed-off-by: Nathan Hjelm <hjelmn@lanl.gov>
2018-05-08 14:10:20 -06:00
Jeff Squyres
b39bbfb3c0
Merge pull request #5142 from mkurnosov/base-reduce-remove-warnings
...
coll/base/reduce: remove warning identified by Coverity Scan
2018-05-07 15:49:56 -04:00
Gilles Gouaillardet
0e8b35b615
coll/tuned: use basic algo for reduce_scatter_block by default
...
Signed-off-by: Gilles Gouaillardet <gilles@rist.or.jp>
2018-05-07 16:11:44 +09:00
Gilles Gouaillardet
32095be0d6
coll/{base,basic}: move reduce_scatter_block from basic to base
...
Signed-off-by: Gilles Gouaillardet <gilles@rist.or.jp>
2018-05-07 16:11:38 +09:00
Howard Pritchard
db45d61dfa
Merge pull request #5147 from hppritcha/topic/plug_debug_hole_in_verbs
...
btl/openib: add conditional around an assert
2018-05-05 08:12:53 -06:00
Geoff Paulsen
a480e40d61
Merge pull request #5144 from gpaulsen/topic/fix_make_check_opal_fifo
...
Fixing 'make check' test opal_fifo.
2018-05-04 16:49:58 -05:00
Howard Pritchard
30eed9f035
btl/openib: addition conditional around an assert
...
A user trying to build Open MPI with explicit use
of CFLAGS on the make command line hit problems.
This fixes one of the problems.
https://www.mail-archive.com/users@lists.open-mpi.org//msg32241.html
Signed-off-by: Howard Pritchard <hppritcha@gmail.com>
2018-05-04 14:17:07 -06:00
Howard Pritchard
4e917b7692
Merge pull request #5087 from mkurnosov/base-reduce-scatter-block
...
coll/base: add recursive doubling algorithm for MPI_Reduce_scatter_block
2018-05-04 11:58:26 -06:00
Ralph Castain
ba40e2173d
Merge pull request #5146 from rhc54/topic/fin
...
Ensure pmix_cleanup finalizes the class system
2018-05-04 07:34:38 -07:00
Mikhail Kurnosov
ba968e4490
coll/base/reduce: Remove warning identified by Coverity Scan
...
Signed-off-by: Mikhail Kurnosov <mkurnosov@gmail.com>
2018-05-04 20:48:37 +07:00
Ralph Castain
4ff61450a4
Ensure pmix_cleanup finalizes the class system
...
Signed-off-by: Ralph Castain <rhc@open-mpi.org>
2018-05-04 06:22:36 -07:00
Geoffrey Paulsen
cc9f713d09
Fixing 'make check' test opal_fifo.
...
xlc on ppc64le complains about incompatible pointer types discards qualifiers.
This fix allows 'make check' to pass on ppc64le Power9 for master and v3.1.x.
> opal_fifo.c:110:26: warning: assigning to 'opal_list_item_t *' (aka 'struct opal_list_item_t *') from
> 'volatile opal_list_item_t *volatile' (aka 'volatile struct opal_list_item_t *volatile') discards qualifiers
> [-Wincompatible-pointer-types-discards-qualifiers]
> for (count = 0, item = fifo->opal_fifo_head.data.item ; item != &fifo->opal_fifo_ghost ;
> ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 1 warning generated.
Signed-off-by: Geoffrey Paulsen <gpaulsen@us.ibm.com>
2018-05-03 21:31:27 -05:00
Mikhail Kurnosov
8cf8553abd
Resolve merge conflicts
...
Signed-off-by: Mikhail Kurnosov <mkurnosov@gmail.com>
2018-05-03 07:28:32 +07:00
Nathan Hjelm
c22c485837
Merge pull request #5136 from hjelmn/mtl_fix
...
mtl: reset ompi_mtl_base_selected_component on framework close
2018-05-02 15:48:54 -06:00
Joshua Ladd
32ddc6af7e
Merge pull request #5094 from xinzhao3/topic/osc-win-fix-master
...
OMPI/OSC/UCX: fix issue in impl of MPI_Win_create_dynamic/MPI_Win_attach/MPI_Win_detach
2018-05-02 17:42:34 -04:00
Nathan Hjelm
f432d07844
mtl: reset ompi_mtl_base_selected_component on framework close
...
Signed-off-by: Nathan Hjelm <hjelmn@lanl.gov>
2018-05-02 14:53:34 -06:00
Xin Zhao
147299dedd
Merge pull request #5134 from xinzhao3/topic/osc-topic
...
OMPI/OSC/UCX: set priority to 0.
2018-05-02 13:22:17 -07:00
Xin Zhao
3f5ac97649
OMPI/OSC/UCX: set priority to 0.
...
Signed-off-by: Xin Zhao <xinz@mellanox.com>
2018-05-02 21:40:06 +03:00
Yossi Itigin
66d931b7c4
Merge pull request #5116 from yosefe/topic/ucx-connect-errs
...
ucx: improve error messages during connection establishment
2018-05-02 14:04:24 +03:00
Jeff Squyres
b2aaf28a67
Merge pull request #5113 from ThemosTsikas/patch-2
...
Use standard-conforming dummy names for Fortran bindings
2018-05-02 06:36:08 -04:00
Nathan Hjelm
1aa82c0e08
Merge pull request #5125 from hjelmn/romio_mpi3
...
io/romio314: fix two more MPI-3 compliance issues
2018-05-01 20:21:57 -06:00
Nathan Hjelm
0f565a734e
Merge pull request #5126 from hjelmn/ompitrace_mpi3
...
ompitrace: MPI_Address -> MPI_Get_address
2018-05-01 20:21:37 -06:00
Themos Tsikas
4d126c16fa
mpi/fortran: use conformant dummy names for Fortran bindings
...
The MPI spec defines that the "mpi" and "mpi_f08" module Fortran
bindings support passing by parameters by name. Hence, we need to use
the MPI-spec-defined parameter names ("dummy variables", in Fortran
parlance) for the "mpi" and "mpi_f08" modules.
Specifically, Fortran allows calls to procedures to be written with
keyword arguments, e.g., "call mpi_sizeof(x=x,size=rsize,ierror=ier)"
An "explicit interface" for the procedure must be in scope for this to
be allowed in a Fortran program unit. Therefore, the explicit
interface blocks we provide in the "mpi" and "mpi_f08" modules must
match the MPI published standard, including the names of the dummy
variables (i.e., parameter names), as that is how Fortran programs may
call them.
Note that we didn't find this issue previously because even though the
MPI spec *allows* for name-based parameter passing, not many people
actually use it. I suspect that we might have some more incorrect
parameter names -- we should probably do a full "mpi" / "mpi_f08"
module parameter name audit someday.
Thanks to Themos Tsikas for reporting the issue and supplying the
initial fix.
Signed-off-by: themos.tsikas@nag.co.uk
Signed-off-by: Jeff Squyres <jsquyres@cisco.com>
Signed-off-by: Gilles Gouaillardet <gilles@rist.or.jp>
2018-05-02 09:42:19 +09:00
Nathan Hjelm
c6475e572f
ompitrace: MPI_Address -> MPI_Get_address
...
Signed-off-by: Nathan Hjelm <hjelmn@lanl.gov>
2018-05-01 15:20:02 -06:00
Nathan Hjelm
ae17908f35
io/romio314: fix two more MPI-3 compliance issues
...
Signed-off-by: Nathan Hjelm <hjelmn@lanl.gov>
2018-05-01 15:18:18 -06:00
Jeff Squyres
72f2c3befe
Merge pull request #5121 from blegat/bl/cartcreatebracket
...
Remove brackets for ndims for c++ doc of Cart_create
2018-05-01 13:37:14 -04:00
Nathan Hjelm
bfd8ee7d57
Merge pull request #4898 from bosilca/topic/dist_graph
...
Allow MPI_PROC_NULL as neighbor.
2018-05-01 09:55:27 -06:00
Nathan Hjelm
85d1965a0f
Merge pull request #4828 from hppritcha/topic/update_lanl_toss_platform
...
lanl/platform: add new toss2/3 platform files
2018-05-01 09:52:14 -06:00
Nathan Hjelm
380dcb57de
Merge pull request #5072 from bosilca/topic/datatype_add_size_t
...
Allow OPAL DDT to receive size_t count argument.
2018-05-01 09:47:45 -06:00
Nathan Hjelm
e9ef7aa256
Merge pull request #4985 from mkurnosov/spacc-scan-exscan
...
coll/spacc: Add recursive doubling algorithm for Scan and Exscan
2018-05-01 09:21:23 -06:00
Benoît Legat
709c4f6646
Remove brackets for ndims for c++ doc of Cart_create
...
Signed-off-by: Benoît Legat <benoit.legat@gmail.com>
2018-05-01 12:00:55 +02:00
Geoff Paulsen
591b174434
Merge pull request #5003 from sam6258/shmem_free_fix
...
ompi/oshmem: fix shmem_free to perform no-op on null ptr
2018-04-30 12:03:24 -05:00
Yossi Itigin
385f38ab4e
ucx: improve error messages during connection establishment
...
Also, unite common code calling ucp_ep_create()
Signed-off-by: Yossi Itigin <yosefe@mellanox.com>
2018-04-30 15:45:05 +03:00
Ralph Castain
0552d12771
Merge pull request #5111 from rhc54/topic/silence
...
Silence warning
2018-04-27 08:57:32 -07:00
Ralph Castain
d2040497b8
Silence Coverity warning
...
Signed-off-by: Ralph Castain <rhc@open-mpi.org>
2018-04-27 07:30:00 -07:00
KAWASHIMA Takahiro
dc0f984743
Merge pull request #5015 from RandomDSdevel/fix-configure-OS-X-and-macOS-JDK-path-resolution
...
config/opal_setup_java.m4: Improve JDK Tool Path Resolution on OS X/macOS
2018-04-27 10:13:12 +09:00
bosilca
cdfb7fdc2b
Merge pull request #5110 from ninadkhanolkar/monitoring_update
...
Updated aggregate_profile.pl
2018-04-26 22:28:35 +01:00
Bryce Glover
8c32cd8970
config/opal_setup_java.m4: Improve JDK tool path resolution on OS X/macOS.
...
Also avoid picking up Apple's Java shims via the sym. links to them in
`/usr/bin` on systems where any one of them could possibly exhibit behavior
that is erratic and, to some extent, likely to be incorrect nowadays (cf.:
- https://www.mail-archive.com/devel@lists.open-mpi.org/msg20551.html
- https://github.com/open-mpi/ompi/pull/5015#issuecomment-379324639
- the last part of
https://github.com/open-mpi/ompi/pull/5015#discussion_r184187064
- https://github.com/open-mpi/ompi/pull/5015#issuecomment-384136871
for more detailed context.)
Works alongside #5001 to close #5000 .
Signed-off-by: Bryce Glover <RandomDSdevel@gmail.com>
2018-04-26 17:14:07 -04:00
Ralph Castain
1e8add52d7
Silence warning
...
Signed-off-by: Ralph Castain <rhc@open-mpi.org>
2018-04-26 11:45:25 -07:00
Ninad Prabhukhanolkar
1518d7e003
Updated aggregate_profile.pl
...
The files array was also storing $phase.prof. This was leading to
$phase.prof's output getting dumped into itself again and again. Updated
code to initialise files array with files other than $phase.prof.
Signed-off-by: Ninad Prabhukhanolkar <ninadchess96@gmail.com>
2018-04-26 20:34:24 +05:30
Ralph Castain
bf09156d12
Merge pull request #5108 from rhc54/topic/rank
...
Fix rank-by option and improve npernode/skt
2018-04-26 05:50:35 -07:00
Ralph Castain
9ae80596f6
Fix rank-by option and improve npernode/skt
...
This fixes a problem reported by @bgoglin where rank-by was incorrectly generating values when ranking by a type of object (e.g., socket). It also corrects the handling of the pernode, npernode, and npersocket options - these should only set the #procs and the default mapping pattern. They specifically should not prohibit the user from requesting a different mapping.
Thus, the following should be valid:
mpirun -npernode 2 --map-by socket ...
should put 2 procs on each node, mapping them by-socket on each node.
Signed-off-by: Ralph Castain <rhc@open-mpi.org>
2018-04-25 20:35:43 -07:00
Gilles Gouaillardet
edb8fe8e4b
pmix/ext1x: fix index handling when populating an info array
...
Signed-off-by: Gilles Gouaillardet <gilles@rist.or.jp>
2018-04-26 11:06:43 +09:00
Ralph Castain
2c508d0d92
Merge pull request #5103 from rhc54/topic/hack
...
Fix external PMIx v1.2.5 support
2018-04-25 15:02:42 -07:00
Ralph Castain
f424aa367e
Fix external PMIx v1.2.5 support
...
As @hjelmn and I discussed, this is a little hacky. However, it is the only solution that can be done solely from the OMPI side.
Signed-off-by: Ralph Castain <rhc@open-mpi.org>
2018-04-25 13:42:36 -07:00
Edgar Gabriel
300c61f2df
Merge pull request #5093 from edgargabriel/topic/io-configury
...
Topic/io configury
2018-04-25 15:26:37 -05:00