1
1
Граф коммитов

8041 Коммитов

Автор SHA1 Сообщение Дата
George Bosilca
47e6e15e02 Typo in a rebase. 2015-02-26 15:54:19 -05:00
George Bosilca
d126c2e6f8 Fix few COVERITY reported issues. 2015-02-26 15:53:42 -05:00
George Bosilca
44d590b8fd Fix a small problem with the handling of requests in MPI_Alltoall. 2015-02-26 15:52:44 -05:00
George Bosilca
3f757bc8cb Add a constructor for mca_coll_base_comm_t. 2015-02-26 15:52:36 -05:00
George Bosilca
d6e69ecab3 Do not preallocate any requests. They are instead automatically
preallocated on the first collective that needs them.
Remove the ompi_coll_tuned_preallocate_memory_comm_size_limit MCA
parameter.
2015-02-26 15:52:27 -05:00
George Bosilca
0445670bb9 Fix the automatic handling of communicator associated requests.
If the array doesn't exist, or if it's size is not adequate then
we reallocate it. Otherwise just keep using the same array of requests.
2015-02-26 15:52:18 -05:00
George Bosilca
67d01bd8cd Redirect most of the basic module functions to base. 2015-02-26 15:52:00 -05:00
George Bosilca
211f05fb09 Complete the dismantle of the tuned module. 2015-02-26 15:50:55 -05:00
George Bosilca
aa019e239e Rename the base header file containing the prototypes of the collective
functions.
2015-02-26 15:50:29 -05:00
George Bosilca
8fbcdf685d Split the tuned framework in two. Move all the functions down in the
base, so that they can now be used by all modules. Keep the decision
functions in tuned.
2015-02-26 15:46:13 -05:00
George Bosilca
004f65a865 Fix issue with the error reporting as suggested by Gilles. 2015-02-26 13:01:13 -05:00
Todd Kordenbrock
0cf45df1a0 osc-portals4: fix incomplete free list conversion 2015-02-26 10:53:45 -06:00
Todd Kordenbrock
b2696edeef mtl-portals4: fix incomplete free list conversion 2015-02-26 10:53:45 -06:00
Todd Kordenbrock
c73e4fd98b coll-portals4: fix incomplete free list conversion 2015-02-26 10:53:45 -06:00
Howard Pritchard
918540dd06 Merge pull request #430 from ggouaillardet/issue/404
romio: always set err_ status in MPIO_DATATYPE_ISCOMMITTED
2015-02-26 09:02:34 -07:00
Gilles Gouaillardet
05140df1e6 coll/tuned: regression fix
fix the regression introduced in open-mpi/ompi@004160f8da
2015-02-26 13:58:06 +09:00
Gilles Gouaillardet
74a46863ca romio: always set err_ status in MPIO_DATATYPE_ISCOMMITTED
from the ROMIO sources :
/* Any MPI implementation that wishes to follow the thread-safety and
   error reporting features provided by MPICH must implement these
   four functions.  Defining these as empty should not change the behavior
   of correct programs */
the MPIO_DATATYPE_ISCOMMITTED macro now always set err_=0
this is an optimistic approach for Open MPI, but it is likely other upper
layers already checked the datatype was committed.
not setting err_ is incorrect since it can lead to some use of uninitialized
variable.

Fixes open-mpi/ompi#404
2015-02-26 13:39:05 +09:00
Jeff Squyres
8d38ac3cee java MPI bindings: use strdup() 2015-02-25 14:21:42 -08:00
Howard Pritchard
309dfd6d3d Merge pull request #427 from roblatham00/romio-extended-greq-fix
fix build error if greq extensions not available
2015-02-25 10:49:00 -07:00
Mike Dubman
a0afb7d96e Merge pull request #424 from miked-mellanox/topic/master_fix_yalla
fixes issue #414
2015-02-25 19:01:47 +02:00
Rob Latham
24a6f14257 fix build error if greq extensions not available
Fall back to immediately completing the non-blocking request if we are
unable to use the extended generalized request routines.
2015-02-25 10:52:22 -06:00
Jeff Squyres
c3381150de ob1: fix another PERUSE compile error 2015-02-25 05:53:12 -08:00
yosefe
0332ab4d8b Initialize pml_yalla bsend request status. 2015-02-25 15:33:26 +02:00
Nysal Jan K.A
ded408f485 Fix a crash while closing libnbc
If the free list initialization fails in libnbc_open()
mca_coll_libnbc_component.active_requests remain uninitialized,
resulting in a crash while closing the component
2015-02-25 17:26:28 +05:30
Nathan Hjelm
0ac2f08460 pml/ob1: fix peruse compile error
Fixes #416
2015-02-24 15:39:46 -07:00
Jeff Squyres
a85a392896 Merge pull request #422 from jsquyres/topic/coverity-fixes
Some Coverity fixes
2015-02-24 17:00:10 -05:00
Jeff Squyres
bd99b741d2 java: update to new mpool API 2015-02-24 13:31:23 -08:00
Jeff Squyres
1c3cf068a4 nbc ireduce_scatter: ensure to check the correct return code
This was CID 1196644 and 1196621
2015-02-24 15:24:11 -05:00
Jeff Squyres
e9980654a8 nbc ireduce_scatter_block: ensure to check the correct return code
This was CID 1196643 and 1196615
2015-02-24 15:24:11 -05:00
Jeff Squyres
657d2cf77b io_ompi: check the correct returned value
This was CID 731273
2015-02-24 15:24:11 -05:00
Jeff Squyres
b35eb6fe10 nbc ireduce_scatter_block: ensure to check the correct return code
This was CID 709594 and 709592
2015-02-24 15:24:10 -05:00
Jeff Squyres
b0acef6f2d nbc_ireduce_scatter: ensure to check the proper return code
This was CID 709229 and 709224.
2015-02-24 15:24:10 -05:00
Jeff Squyres
fd815bba22 bcol basesmuma allreduce: remove redundant assignment
This was CID 1196655 and 1196656
2015-02-24 15:24:10 -05:00
Jeff Squyres
10b93e3f6f cart_rank: protect against (cart==NULL) possibilities
This was CID 1041230
2015-02-24 15:24:09 -05:00
Jeff Squyres
3758e3a242 topo base: ensure topo is != NULL before acting on it
This was CID 1041229
2015-02-24 15:24:09 -05:00
Jeff Squyres
1cf197d771 coll_basic_barrier: guard against opal_hibit() returning -1
This was CID 1196606 and 1196607
2015-02-24 15:24:08 -05:00
Nathan Hjelm
6dcdb3daf7 mtl/mxm: fix typo from opal_free_list_t update 2015-02-24 11:43:15 -07:00
igor-ivanov
0f44cdd779 Merge pull request #421 from igor-ivanov/pr/fix-oshmem-coverity
oshmem: Fix set of coverity issues
2015-02-24 21:40:06 +04:00
Nathan Hjelm
5ef24000c7 pml/yalla: fix typo in PML_YALLA_FREELIST_INIT 2015-02-24 10:08:54 -07:00
Nathan Hjelm
4443a79af8 mtl/mxm: fix opal_free_list_wait usage error 2015-02-24 10:05:45 -07:00
Nathan Hjelm
5f1254d710 Update code base to use the new opal_free_list_t
Use of the old ompi_free_list_t and ompi_free_list_item_t is
deprecated. These classes will be removed in a future commit.

This commit updates the entire code base to use opal_free_list_t and
opal_free_list_item_t.

Notes:

OMPI_FREE_LIST_*_MT -> opal_free_list_* (uses opal_using_threads ())

Signed-off-by: Nathan Hjelm <hjelmn@lanl.gov>
2015-02-24 10:05:45 -07:00
Nathan Hjelm
ed78553512 Update opal_free_list_t usage to reflect new class interface.
Please verify your components have been updated correctly. Keep in
mind that in terms of threading:

OPAL_FREE_LIST_GET -> opal_free_list_get_st
OPAL_FREE_LIST_RETURN -> opal_free_list_return_st

I used the opal_using_threads() variant anytime it appeared multiple
threads could be operating on the free list. If this is not the case
update to _st. If multiple threads are always in use change to _mt.
2015-02-24 10:05:44 -07:00
Igor Ivanov
3e2dd782ea oshmem: Fix set of coverity issues
Signed-off-by: Igor Ivanov <Igor.Ivanov@itseez.com>
2015-02-24 19:03:10 +02:00
Jeff Squyres
b70fa3e2cb osc_sm: Fix valgrind warning
Many thanks to Lisandro Dalcin for contributing this patch.

Fixes open-mpi/ompi#202.
2015-02-24 03:36:17 -08:00
Jeff Squyres
c7d8563d8d fcoll_two_phase: fix trivial compiler warning 2015-02-23 08:58:43 -08:00
Howard Pritchard
c9e81b54fb Merge pull request #412 from hppritcha/topic/owner_files
add owner files to opa/ompi/orte mca directories
2015-02-23 09:48:20 -07:00
Howard Pritchard
61fb62499a hcoll belongs to MLNX and is active 2015-02-23 09:14:03 -07:00
Mike Dubman
e02121af6f Merge pull request #411 from miked-mellanox/topic/fix_cov
coverity fixes for yalla
2015-02-23 12:01:05 +02:00
Mike Dubman
5b3b04b26e mxm: revert coverity fixes
mxm fails on this commit: 780c93ee57
2015-02-23 07:52:28 +02:00
Gilles Gouaillardet
004160f8da coll/tuned: silence CID 1269934 2015-02-23 13:45:23 +09:00
Howard Pritchard
bf89131f9e add owner files to opa/ompi/orte mca directories
This commit adds an owner file in each of the component directories
for each framework.  This allows for a simple script to parse
the contents of the files and generate, among other things, tables
to be used on the project's wiki page.  Currently there are two
"fields" in the file, an owner and a status.  A tool to parse
the files and generate tables for the wiki page will be added
in a subsequent commit.
2015-02-22 15:10:23 -07:00
Mike Dubman
00d416ba9d yalla: fix coverity errors
dead code fix
2015-02-22 13:57:45 +02:00
Jeff Squyres
4c91bdfb0c MPI_Barrier.3in: fix prototypes
Also fix MPI_Ibarrier.3in to .so to the right MPI_Barrier.3 page.

Thanks to Maximilian for bringing the issue to our attention.
2015-02-21 06:47:12 -08:00
Jeff Squyres
9b716d946e wrappers: fix errant @{libdir} reference in pkg-config files
The RPATH support added a @{libdir} token into
<package>_WRAPPER_EXTRA_LDFLAGS.  However, these flags are also
substituted into the pkg-config data files, and they don't understand
the @{foo} notation.  So convert @{libdir} into ${libdir}, which
pkg-config *does* understand.

Thanks to Christoph Junghans (@junghans) for notifying us of the issue.

Fixes #406.
2015-02-20 08:43:19 -08:00
Jeff Squyres
ae5424c18b MPI_Intercomm_merge: fix typo in man page
Thanks to Harald Servat for noticing and sending a patch.
2015-02-20 07:13:55 -08:00
Igor Ivanov
010dce307a Fix set of coverity issues
List of CIDs (scan.coverity.com):
oshmem:
1269787, 1269907, 1270161, 1270162, 1270977, 1270978
ompi:
1270170, 1270172, 1270173

Signed-off-by: Igor Ivanov <Igor.Ivanov@itseez.com>
2015-02-20 17:45:46 +04:00
Ralph Castain
8b625c2756 Ensure the provider name isn't NULL before trying to strdup it 2015-02-19 08:38:23 -08:00
Jeff Squyres
6098b84294 libfabric: pass the appropriate LDFLAGS to libfabric components
When compiling against an external libfabric, ensure to also pass the
appropriate -L flags so that the compiler/linker can find it.
2015-02-19 05:35:38 -08:00
Rolf vandeVaart
dbd0064713 Fix bug in CUDA-aware and GDR introduced by refactoring 2015-02-18 17:44:28 -05:00
Gilles Gouaillardet
5db3065d63 fortran: fix misc memory leak in lookup_name
as reported by Coverity with CID 1269897
2015-02-18 16:41:56 +09:00
Gilles Gouaillardet
bda8058f39 coll/tuned: fix memory leaks and misc issues
as reported by Coverity with CIDs
70132, 70265, 70267, 70268, 70322, 70400, 70580, 70615,
1269934, 1269944, 1269968, 1269982, 1269983
2015-02-18 16:29:42 +09:00
Nathan Hjelm
030e9bc714 mtl/ofi: fix mca variable usage error
The fi_fabric function appears to free the provider string passed in
in the fabric_attr. This causes MCA to free an invalid pointer when
the parameter is freed.

References #374
2015-02-17 12:15:31 -07:00
Gilles Gouaillardet
7dabc7b3ab bml/r2: fix a typo
reported by Coverity as CID 1270228
2015-02-17 14:28:17 +09:00
Jeff Squyres
0bb1dfeca9 osc_base_obj_convert: remove unnecessary MEMCHECKER line
Commit open-mpi/ompi@1a3597aam changed the type of the `convertor`
variable from `ompi_osc_base_convertor_t` (which contained an
`opal_convertor_t`) to an `opal_convertor_t`.  Hence, using memchecker
to ensure that the inner convertor of the `ompi_osc_base_convertor_t`
is considered initialized is now unnecessary.
2015-02-16 07:27:44 -08:00
Gilles Gouaillardet
02da8bfa93 ompi/java: fix misc bugs
as reported by Coverity with CIDs 1270187, 1270189 and 1270190
2015-02-16 15:19:53 +09:00
Gilles Gouaillardet
0d560ddf77 osc: fix typo
this typo caused build failure when configure'd with --enable-memchecker
see http://mtt.open-mpi.org/index.php?do_redir=2234
2015-02-16 10:09:08 +09:00
George Bosilca
a7a4d6335e Various cleanups. 2015-02-15 11:39:09 -05:00
Jeff Squyres
5da123da7c ofi: change mtl_ofi_provider to level 4
Seems more appropriate; this is a variable that a tuner might want to
actually set.
2015-02-13 14:46:05 -08:00
Nathan Hjelm
4bf7a207e9 bml/r2: add all rdma btls even if another btl has higher exclusivity
Background: In order to support atomics each btl needs to provide support
for communicating with self unless the btl module can guarantee global
atomicity. Before this commit bml/r2 discarded any BTL with lower
exclusivity than an existing send btl. This would cause the BML to
discard any btl other than self.

The new behavior is as follows:

 - If an exisiting send btl has higher exclusivity then the btl will not be
   added to the send btl list for the endpoint.

 - If a btl provides RDMA support then it is always added to the rdma btl
   list.

 - bml_btl weight for send btls is now calculated across all send btls.

 - bml_btl weight for rdma btls is now calculated across all rdma btls.

With this change self should still win as the only send btl for loopback
without disqualifying other btls (ugni, openib) for atomic operations.

Signed-off-by: Nathan Hjelm <hjelmn@lanl.gov>
2015-02-13 11:46:37 -07:00
Nathan Hjelm
3847025540 pml/ob1: when using btl_get try to register the entire region before attempting to break the get into multiple rdma fragments
A little background. Historically ob1 always registered the entire memory
region when the RGET protocol was in use. This changed when Mellanox
added support to fragment RGET using the btl_prepare_dst function. Now
that the BTL layer has changed to split out the limits of get/put there
is explicit fragmentation code in ob1. Before this commit the registration
was still done per RGET fragment.

This commit will attempt to register the entire region before creating
RGET fragments. If the registration is successfull then all RGET
fragments will use this registration otherwise they will each attempt
to register their own segment of the receive buffer. If that fails
enough times each fragment will give up and fall back on send/recv.

Signed-off-by: Nathan Hjelm <hjelmn@lanl.gov>
2015-02-13 11:46:37 -07:00
Nathan Hjelm
868e10caf2 pml/bfo: ompi ignore until updated for BTL 3.0 interface
Signed-off-by: Nathan Hjelm <hjelmn@lanl.gov>
2015-02-13 11:46:37 -07:00
Nathan Hjelm
c4a0e02261 pml/ob1: update for BTL 3.0 interface
Signed-off-by: Nathan Hjelm <hjelmn@lanl.gov>
2015-02-13 11:46:37 -07:00
Nathan Hjelm
9285e2c356 bml: update for BTL 3.0 interface
This commit brings the bml framework up to date with BTL 3.0 interface.

Signed-off-by: Nathan Hjelm <hjelmn@lanl.gov>
2015-02-13 11:46:37 -07:00
Gilles Gouaillardet
b68e1cd579 ompio: fix memory leaks reported by Coverity scan
and silence CID 72195
2015-02-13 13:18:44 +09:00
Nathan Hjelm
0e822e03f7 osc/sm: always release the lock on MPI_Unlock
When a lock was obtained with MPI_MODE_NOCHECK it was not correctly
release on unlock. This is an error.

Signed-off-by: Nathan Hjelm <hjelmn@lanl.gov>
2015-02-12 18:54:22 -07:00
Nathan Hjelm
dd8aaca295 Merge pull request #389 from hjelmn/osc_datatype_fix
osc/base: fix accumulate on derived datatypes
2015-02-12 12:01:05 -07:00
Jeff Squyres
27a783b1c3 coll_sm_barrier: remove dead code
This was CID 1269978.
2015-02-12 10:24:02 -08:00
Jeff Squyres
bea0efe59c info.c: fix minor memory leak in error condition
This was CID 1269851.
2015-02-12 10:24:02 -08:00
Jeff Squyres
2ca4bf4777 cart_rank_f.c: make sure MPI_Cartdim_get succeeded
This was CID 1269686.
2015-02-12 10:24:02 -08:00
Jeff Squyres
20465badcb dims_create.c: fix minor error leak in error condition
This was CID 70278.
2015-02-12 10:24:02 -08:00
Jeff Squyres
1e58920b4d *info param.c: use stack string buffers
Coverity identified that we treated the possibility that one of the
message buffers could be NULL in some places (because strdup() could
fail), but not in others.

So just use stack buffers that will never be NULL.

This was CID 1269914.
2015-02-12 10:24:02 -08:00
Rolf vandeVaart
1f749b0224 Bump priority of coll cuda component so it is higher than self.
Otherwise, get some odd interactions with coll self in CUDA-aware
builds.
2015-02-12 12:29:03 -05:00
Jeff Squyres
fe8bc4e7eb debuggers: make the test safe to build without dlopen
This is a bit of overkill, but I'm cleaning out a bunch of other
libltdl-support assumptions, so I might as well do this one, too.  The
test isn't built if we don't have libltdl support, but it had
half-hearted #if protection in it to make it safe to build even if we
didn't have libltdl support.  This commit finishes that half-hearted
support.
2015-02-11 12:25:20 -08:00
Jeff Squyres
3ac1d0dae5 *-info: add "lt_dladvise support" lines 2015-02-11 12:25:20 -08:00
Nathan Hjelm
1a3597aa93 osc/base: fix accumulate on derived datatypes
With certain datatypes the opal_datatype_unpack method for performing
the accumulate operation does not work. This commit modifies the
accumulate code in the osc base to use opal_convertor_raw instead.

Fixes #385
2015-02-11 12:36:30 -07:00
Nathan Hjelm
a2bdfd99a2 osc/pt2pt: do not set active_incoming_frag_signal_count to 0 on fence completion 2015-02-11 12:34:04 -07:00
Jeff Squyres
c368699bde configury: whitespace cleanup
No code changes.
2015-02-09 20:49:04 -08:00
Jeff Squyres
0acdf34044 configury: --enable-dist ceased being useful long ago
The --enable-dist flag is a relic from a prior iteration of the build
system.  It isn't necessary any more.
2015-02-09 20:49:04 -08:00
Jeff Squyres
f38f2a159b pml_base: whitespace cleanup; no code changes 2015-02-06 11:27:50 -08:00
Jeff Squyres
46a1722dfc pml_base: fix errant show_help message 2015-02-06 11:27:50 -08:00
Howard Pritchard
45e7c7fd60 Merge pull request #378 from hppritcha/topic/mtl_query_cast_fix
mtl/query: squash compiler warning
2015-02-06 12:23:33 -07:00
Todd Kordenbrock
b5a0f3d347 osc-portals4: rename OPAL_ASSEMBLY_ARCH values from OMPI_* to OPAL_* 2015-02-04 16:08:55 -06:00
Todd Kordenbrock
762b05bcda mtl-portals4: fix mismatch between format and type-size 2015-02-04 15:35:03 -06:00
Todd Kordenbrock
87759a1b1e mtl-portals4: fix signedness mismatch warning 2015-02-04 15:35:03 -06:00
Todd Kordenbrock
5ddce1acbc mtl-portals4: add "unused" attribute to rc to prevent compiler warning 2015-02-04 15:35:03 -06:00
Howard Pritchard
69d2b818f7 mtl/query: squash compiler warning
Squash compiler warnings now showing up in the
query methods for the mtls.  Cast pointers to the different
mtl module specific types to the mca_base_module_t.

Also, fix up a missing extern in mtl_psm_types.h.
This was causing "multiple definition" errors when building
the mca_mtl_psm.so shared library.
2015-02-04 14:15:54 -07:00
Jeff Squyres
1261fb6a12 dpm_orte: fix uninitialized variable
(yay clang compiler warnings!)
2015-02-04 15:53:38 -05:00
Todd Kordenbrock
b8b07d2d62 mtl-portals4: Fix initialization of the Portals4 MTL component
Swap close and query methods in the initialization of the Portals4
MTL component.

Fixes #373
2015-02-04 13:29:13 -06:00
Jeff Squyres
5392b331a3 mtl_ofi_types.h: add "extern" to the mca_mtl_ofi_component declaration
Otherwise, it fails the gcc -fno-common test.
2015-02-04 10:40:56 -08:00
Yohann Burette
2762ef870d mtl/ofi: Use FI_ADDR_UNSPEC. 2015-02-04 08:32:09 -08:00
Yohann Burette
60496742b2 mtl/ofi: fix ep_name exchange 2015-02-04 08:32:04 -08:00
Jeff Squyres
1c535eee98 Just like coll/ml: We're .opal_ignore these days, not .ompi_ignore. :-) 2015-02-03 14:29:34 -08:00
Jeff Squyres
a1c521f968 We're .opal_ignore these days, not .ompi_ignore. :-) 2015-02-03 13:56:53 -08:00
rhc54
95660822b9 Merge pull request #370 from rhc54/topic/dvm
Enable a persistent DVM
2015-02-01 17:37:10 -08:00
Ralph Castain
4dba298e6e Update orte-submit manpage, add the ompi-* versions of orte-dvm and orte-submit manpages 2015-02-01 15:46:40 -08:00
Howard Pritchard
ed537ddca0 copyright updates for commit eb977de5
I really should start using Jeff's script..
2015-01-31 13:50:32 -07:00
Jeff Squyres
30f05bc966 Makefiles: remove unused macros 2015-01-31 04:51:25 -08:00
Edgar Gabriel
03c2adf3b1 part 2 of the cleaning up of info handling in ompio. The set_info interface
in the fs modules does not make sense and was not used. Remove them.
2015-01-30 16:48:41 -06:00
Edgar Gabriel
62282a0f06 part 1 of cleaning up the info handling in the ompio component. 2015-01-30 16:13:15 -06:00
Howard Pritchard
bb18bd2eec Merge pull request #363 from hppritcha/topic/mtl_query
mtl: add query method to mtl components
2015-01-29 12:31:41 -07:00
Jeff Squyres
8ae2c6a599 Merge pull request #365 from jsquyres/topic/mpi-extension-symbols
MPI extensions: rules of thumb about symbol names
2015-01-29 10:34:16 -06:00
Edgar Gabriel
5d58ce2113 handle the situation where you have an upper liomit on the simultanious number of pending aio operations. 2015-01-29 10:23:36 -06:00
Howard Pritchard
eb977de5e9 mtl: add query method to mtl components
Switch to using the query/priority method for selecting
MTLs.  This switch was motivated by the fact that now
on some platforms, its possible for multiple MTLs to
be initializable, but only one MTL should be selected.

In addition, there is a complication with the PSM and
IFO (with PSM provider) MTLs owing to the fact that
they cannot both intialize the underlying PSM context,
i.e. only one call to psm_init is allowed per process.

The mxm component has not been compiled as the author
doesn't currently have access to a system with a recent
enough mxm installed to allow for a compile.

The portals4, ofi, and psm components have been checked
for compilation.  The ofi and psm components have been
checked for runtime correctness on a intel/qlogic system
with up to date PSM installed.
2015-01-29 09:02:52 -07:00
Edgar Gabriel
2d79963cb3 mark the request as an IO request 2015-01-29 08:41:24 -06:00
Jeff Squyres
e855b19ba2 MPI extensions: rules of thumb about symbol names
This document is the result of a George Bosilca/Jeff Squyres
discussion at the developer meeting in Dallas in January of 2015.  It
attempts to provide some rules of thumb / guidance for naming
conventions of symbols in MPI extensions.
2015-01-29 06:39:44 -06:00
Edgar Gabriel
4a5d3e705b remove an unecessary comm_dup in case the internal file_open function is called from a sharedfp component. 2015-01-28 16:13:50 -06:00
Howard Pritchard
928bf977b2 Merge pull request #361 from hppritcha/topic/psm_cancel
mtl/psm: fix problem with cancel sends
2015-01-28 13:58:29 -07:00
Edgar Gabriel
51cee4a083 call the actual backend functions for file_get_position_shared and file_seek_shared. The sharedfp components
do provide the implementations, we just did not invoke them yet.
2015-01-28 13:47:54 -06:00
Howard Pritchard
4637b49bf4 Merge pull request #362 from hppritcha/topic/mtl_grammar_fix
mtl: minor grammar fix in comments
2015-01-28 05:35:24 -07:00
Howard Pritchard
e177dfc226 mtl: minor grammar fix in comments 2015-01-28 04:51:42 -07:00
Howard Pritchard
4643110c5e mtl/psm: fix problem with cancel sends
incorporate patch from @afriedle-intel to fix
problem with psm mtl cancel of sends.

Sorry for the delay in getting to this.

Fixes 347
2015-01-27 20:02:05 -07:00
George Bosilca
7adf74c617 As discussed on the devel mailing list in
http://www.open-mpi.org/community/lists/devel/2015/01/16820.php,
coll ML has two pending issues: a deadlock and a performance critical
on every communicator creation. After confirmation over IM from
Pasha, the ML collective module will be disabled until it is
fixed. Token to Pasha.
2015-01-27 16:27:12 -05:00
Jeff Squyres
2d5b92157f hierarch: with Edgar's blessing, remove the coll hierarch module 2015-01-27 13:25:27 -06:00
Yohann Burette
a741c44035 mtl/ofi: fix compiler warnings. 2015-01-27 11:14:40 -08:00
Ralph Castain
fcec24b2a4 Minor cleanups to handle comm_spawn and singletons 2015-01-27 09:29:42 -06:00
Devendar Bureddy
036e687d9c HCOLL: Do not block hcoll progress in finalize 2015-01-27 17:01:00 +02:00
Yohann Burette
a4c1faae37 mtl/ofi: Add OFI provider option.
The user can now specify which OFI provider to use with the MTL.
e.g. --mca mtl ofi --mca mtl_ofi_provider psm
2015-01-26 08:38:11 -08:00
Edgar Gabriel
ea8051f8e0 add code for the named semaphores. Configure logic to decide whether to use named or unnamed semaphores still missing. 2015-01-26 10:27:28 -06:00
Nathan Hjelm
ff7be586dd Merge pull request #355 from ggouaillardet/topic/mpi_get_hang_in_fence
osc/pt2pt: invoke ompi_osc_signal_outgoing only once per fragment
2015-01-23 18:33:14 -06:00
George Bosilca
438b6e136b Edgar noticed that the commit 3960817 broke the MPI_Type_create_resized.
So, I revert it until I figure out a better way.
2015-01-23 18:12:26 -05:00
Yohann Burette
3c06fd77db mtl/ofi: remove unneeded FI_REMOTE_COMPLETE flag. 2015-01-23 10:55:03 -08:00
Yohann Burette
b88708bf68 mtl/ofi: use fi_ep_bind(). 2015-01-23 10:50:10 -08:00
Bert Wesarg
92f976bdf1 Remove the actual VampirTrace sources. 2015-01-22 08:08:53 +01:00
Bert Wesarg
0d0a754c42 Remove VampirTrace. 2015-01-22 08:08:07 +01:00
Gilles Gouaillardet
9be4dfb152 osc/pt2pt: invoke ompi_osc_signal_outgoing only once per fragment 2015-01-22 13:43:44 +09:00
Yohann Burette
1ad188206b Add OFI MTL to CM PML.
This allows the CM PML to be picked when the OFI MTL is selected.
2015-01-20 10:50:14 -08:00
George Bosilca
ded4cbf20f Correctly set the upper and lower bound for the subarray and darray. 2015-01-19 02:26:14 -05:00
George Bosilca
39608176db If we want the resized data to have the correct LB and UB (both
soft and hard markers) we should force an add instead of
relying on the OPAL datatype resize operation.
2015-01-19 02:24:36 -05:00
George Bosilca
df0512550e The extent of the datatype is irrelevant for deciding to do an immediate
send as long as we have to pack.
2015-01-19 02:23:12 -05:00
Gilles Gouaillardet
d14daf40d0 ob1: correctly handle types in which size > extent
do not send inline if extent*count *OR* size*count are greater than 256
2015-01-19 14:07:23 +09:00
George Bosilca
19c96465f3 Fix the use of hard markers MPI_LB and MPI_UB in the creation of
subarray and darray. Thanks to Gus Correa for pointing to the
MPICH bug report.
2015-01-17 23:11:07 -05:00
Gilles Gouaillardet
661c35ca67 cleanup dead code caused by the removal of the --with-threads configure option 2015-01-16 19:13:59 +09:00
Jeff Squyres
9cc60b9e12 ofi mtl: update to new libfabric constant name 2015-01-15 07:12:39 -08:00
Yohann Burette
bc93e04604 Fixed code around fi_av_insert(). 2015-01-14 08:43:57 -08:00
Gilles Gouaillardet
6d84afc660 romio: update configure for Solaris 10 build 2015-01-14 18:25:55 +09:00
Gilles Gouaillardet
8c1698ae4a coll/libnbc: enhance fix for MPI_Ireduce_scatter on single task communicator
this improves open-mpi/ompi@b9349d2eb9
2015-01-09 13:44:01 +09:00
mjbhaskar
39f9880759 Fixed the data type argument in an all reduce operation to fix a bug
seen on 32 bit machines.
2015-01-08 14:18:54 -06:00
Gilles Gouaillardet
b746a8f584 romio: compile openmpi mpi-io glue 2015-01-08 14:08:46 +09:00
Ralph Castain
4e592ac434 Fix the tarball by providing the correct list of headers in the Makefile.am 2015-01-07 18:37:26 -08:00
mjbhaskar
2d33b0a745 A fix for memory corruption seen on 32 bit machines 2015-01-07 14:41:44 -06:00
Nathan Hjelm
81dc3a5db9 Merge pull request #335 from hjelmn/osc_updates
Osc updates
2015-01-07 11:16:55 -06:00
Ralph Castain
e0927895db Grrr...how many files did they forget? 2015-01-06 19:40:18 -08:00
Ralph Castain
84c41429e9 Add missing file 2015-01-06 18:41:11 -08:00
Nathan Hjelm
e68ed2876c osc/pt2pt: threading fixes and code cleanup 2015-01-06 13:39:16 -07:00
Nathan Hjelm
3d79806805 add more internal RMA error codes 2015-01-06 13:39:04 -07:00
Nathan Hjelm
9eba7b9d35 Rename the OSC "rdma" component to pt2p to better reflect that it does not actually use btl rdma 2015-01-06 13:38:55 -07:00
Jeff Squyres
cab1379dfb Fortran: only emit real16 and complex32 if supported
This is the master version of @ggouaillardet's patch from
open-mpi/ompi-release#148 (there was a minor conflict to fix and
several fuzzings of line numbers).
2015-01-06 09:47:26 -08:00
Howard Pritchard
ec632001b1 Merge pull request #329 from ggouaillardet/topic/romio_refresh
refresh ROMIO based on v3.2a2-84-gef1cf14
2015-01-06 10:27:20 -07:00
Gilles Gouaillardet
0914de9eae refresh ROMIO based on v3.2a2-84-gef1cf14 2015-01-06 19:43:58 +09:00
Yohann Burette
f01dd429df Reset pointer to NULL to prevent double-freeing. 2015-01-05 17:01:37 -08:00
Yohann Burette
1e24da90fe Fix fi_av_insert return code test. 2015-01-05 17:01:37 -08:00
Yohann Burette
5944c294ad Add return code testing for fi_mr_reg. 2015-01-05 17:01:37 -08:00
Howard Pritchard
c857cc926c Merge pull request #327 from hppritcha/topic/async_progress
Topic/async progress
2015-01-05 16:20:44 -07:00
Jeff Squyres
ce2008aa88 man pages: update non-blocking send descriptions
As noted by Alexander Pozdneev, non-blocking sends are now able to
*access* buffers in pending non-blocking send operations; the buffers
just can't be *modified*.
2015-01-05 15:44:27 -05:00
Devendar Bureddy
e732152304 HCOLL: Fix hcoll supported datatype checks corretcly 2015-01-02 21:18:12 +02:00
Gilles Gouaillardet
e8d084e6b9 fix ABI fix
Fix an undeleted line in open-mpi/ompi@24df0ed039
Thanks to Nick Papior Andersen for pointing this.
2014-12-28 18:07:51 +09:00
Gilles Gouaillardet
24df0ed039 MPI_Comm_split_type: fix ABI compatibility
ABI compatibility was previously broken in
open-mpi/ompi@3deda3dc82
2014-12-25 19:43:58 +09:00
Howard Pritchard
3fc7b389ff initial async progress changes for gni 2014-12-24 11:50:23 -07:00
Howard Pritchard
65c4f8d18e Merge pull request #326 from zerothi/master
Enabled COMM_TYPE_SPLIT dependent on locality
2014-12-24 09:13:04 -07:00
Nick Papior Andersen
3deda3dc82 Added several new COMM_TYPE_<> splits
Using the underlying hardware identification to split
communicators based on locality has been enabled using
the MPI_Comm_Split_Type function.

Currently implemented split's are:
  HWTHREAD
  CORE
  L1CACHE
  L2CACHE
  L3CACHE
  SOCKET
  NUMA
  NODE
  BOARD
  HOST
  CU
  CLUSTER

However only NODE is defined in the standard which is why the
remaning splits are referred to using the OMPI_ prefix instead
of the standard MPI_ prefix.

I have tested this using --without-hwloc and --with-hwloc=<path>
which both give the same output.

NOTE: I think something fishy is going on in the locality operators.
In my test-program I couldn't get the correct split on these requests:
  NUMA, SOCKET, L3CACHE
where I suspected a full communicator but only got one.
2014-12-24 11:21:35 +00:00
Gilles Gouaillardet
b9349d2eb9 coll/libnbc: fix MPI_Ireduce_scatter for single task communicator
when MPI_IN_PLACE is not used.

that commit fixes a regression introduced
open-mpi/ompi@49e79a9ade
2014-12-24 12:12:58 +09:00
Devendar Bureddy
e398ad6619 HCOLL: Fix OMPI to HCOLL predefined datatypes, Ops mapping 2014-12-23 22:30:29 +02:00
Jeff Squyres
9144517ad4 man: update a bunch of attribute-related man pages
Per discussion starting
http://www.open-mpi.org/community/lists/users/2014/12/26018.php, at
least note that OMPI does not allow adding or deleting attributes in
an attribute copy or delete callback (or any of its children) on the
same object on which the callback was invoked.
2014-12-19 11:45:58 -08:00
Jeff Squyres
c621d1e622 libfabric: don't LIBADD the common library in the static case
Adding the libfabric common library in the --disable-dlopen case will
result in duplicate symbols.
2014-12-18 11:04:08 -08:00
Rolf vandeVaart
3ec9685ee0 Add missing file to sources. Without this, tarball build does not work 2014-12-18 07:17:28 -08:00
George Bosilca
4d55ae838d Prevent deadlocks on recursive calls (deleting communicators with
attributes from an attribute callback).
2014-12-17 23:12:33 -05:00
Jeff Squyres
d6f059f538 configury: add some descriptive output messages in configure
Ensure that the ofi MTL and the usnic BTL have good descriptive output
messages in configure.
2014-12-17 13:36:01 -08:00
Jeff Squyres
4dcb92ab0b ofi: remove use of non-existent macros 2014-12-17 13:36:01 -08:00
Jeff Squyres
9d1d34c0c0 Fortran: do not dist mpif-h/sizeof_f.f90; it is generated 2014-12-17 10:24:31 -08:00
Gilles Gouaillardet
27aec2ef5b configury: disable f08 fortran bindings if the compiler does
not support c_funloc with TS 29113 subclause 8.1 aka
removed restrictions on ISO_C_BINDING module procedures.
2014-12-17 17:35:45 +09:00
Jeff Squyres
f3be0a5882 ofi: ensure that null_addr is initialized to NULL
And when null_addr is freed, set it back to NULL so that we don't try
to free it again in the error: label.
2014-12-16 17:32:15 -08:00
Jeff Squyres
8c7b6d266e ofi: add "unused" attribute to rc to prevent compiler warning 2014-12-16 17:30:46 -08:00
Yohann Burette
58a7a1e4ac Adding an Open Fabrics Interfaces (OFI) MTL.
This MTL implementation uses the OFIWG libfabric's tag messaging capabilities.
2014-12-16 15:43:39 -08:00
Mangala Jyothi Bhaskar
68d78fd718 Aggregator selection logic Part 2 and reorganized Part1 2014-12-16 15:48:40 -06:00
Mangala Jyothi Bhaskar
2bd52cc410 Initialize req variable to fix a warning 2014-12-16 13:24:28 -06:00
Jeff Squyres
1b63129de3 fortran: ensure to specify the shared library version 2014-12-16 11:16:46 -08:00
Artem Polyakov
01601f3284 Merge pull request #305 from artpol84/timing
Timing framework improvement
2014-12-16 15:13:48 +06:00
George Bosilca
3430714989 Correctly propagate the requested level of thread support during the
component init calls.
2014-12-13 02:36:21 -05:00
Artem Polyakov
8ffad75a0a Introduce timing interval measurement facility in timing framework 2014-12-10 16:47:49 +06:00
Ralph Castain
06e49d0e92 Per contribution from Pascal Deveze of Bull: move opal_set_using_threads earlier in MPI_Init (before datatype init) so the value gets set in time to be properly used. 2014-12-09 00:37:57 -08:00
Jeff Squyres
a71b5dd5c7 debuggers: update warning messages when types not found
Fixes #302.
2014-12-04 03:01:51 -08:00
Jeff Squyres
1dd68d48a8 MPI_Wtime.3: give further explanation about high-res timers 2014-12-03 17:07:42 -08:00
Nadezhda Kogteva
315a240899 Timing framework: pack timing scripts to tarball always 2014-12-02 12:22:46 +02:00
Edgar Gabriel
7e41e0e62b fix a segfault in the two-phase I/O algorithm for fileviews of 0 byte size. 2014-12-01 15:59:00 -06:00
yosefe
3f152733bf Add yalla to the list of default PMLs 2014-12-01 13:11:28 +02:00
Edgar Gabriel
0758d7570e part 1 of the fix to get rid of the missing symbols that prevent the sub-modules to be loaded. 2014-11-29 20:01:36 -06:00
George Bosilca
dee243c58d ompi_proc_finalize has an interesting side effect. A proc is
inserted in the ompi_proc_list as soon as it is created and it
is removed only upon the call to the destructor. In ompi_proc_finalize
we loop over all procs in ompi_proc_finalize and release them once.
However, as a proc is not removed from this list right away, we
decrease the ref count for each proc until it reach zero and the
proc is finally removed. Thus, we cannot clean the BML/BTL after
the call the ompi_proc_finalize.
A quick fix is to delay the call to ompi_proc_finalize until all
other frameworks have been finalized, and then the behavior
depicted above will give the expected outcome.
2014-11-28 18:26:36 -05:00
Nadezhda Kogteva
45ed55afd7 Adding of missed time measurement scripts in tarball 2014-11-28 12:15:30 +02:00
George Bosilca
43901fa15a Merge branch 'master' of github.com:open-mpi/ompi 2014-11-24 22:54:41 -05:00
Ralph Castain
48f702827e First part of memory leak cleanups from Gilles 2014-11-24 16:53:33 -08:00