Use type(c_funptr) to "cast" the fortran function pointers to
arbitrary C pointers. In C, we then pick up the appropriate function
pointer type.
Tested with ifort 14.0.2 and gfortran 4.9 snapshot (which is what
identified that the previous method of passing function pointers was
not Fortran'08-compliant).
Refs trac:4157
This commit was SVN r31371.
The following Trac tickets were found above:
Ticket 4157 --> https://svn.open-mpi.org/trac/ompi/ticket/4157
Junchao Zhang pointed out to me that we had the wrong parameter name
and string length specification for the "version" parameter. This
matters because Fortran allows passing by parameter name
(vs. parameter ordering). Specifically, we had the interface as:
{{{
subroutine MPI_Get_library_version_f08(name,resultlen,ierror)
character(len=MPI_MAX_PROCESSOR_NAME), intent(out) :: name
...etc.
}}}
but it should be:
{{{
subroutine MPI_Get_library_version_f08(version,resultlen,ierror)
character(len=MPI_MAX_LIBRARY_VERSION_STRING), intent(out) :: version
...etc.
}}}
Thankfully, MPI_MAX_PROCESSOR_NAME and MPI_MAX_LIBRARY_VERSION_STRING
are both 255 in OMPI, so there's no ABI issue caused by changing the
length from MMPN --> MMLVS.
The ABI is also unaffected by the parameter name change: if you
compile/link an MPI application calling MPI_GET_LIBRARY_VERSION with
1.8, it'll still run-time link with this change.
However, if an MPI program compiled using parameter name passing with
the old/incorrect parameter name ("name"), it won't be able to compile
with the new/correct parameter name ("version"). But this will only
happen for an incorrect MPI application (because the MPI-3 mandated
parameter name is "version", not "name"), so they deserve what they
get.
cmr=v1.8.1:reviewer=dgoodell
This commit was SVN r31365.
(i.e., the script that fires via cron every 15 mins to "git pull" from
the github ompi-www repo).
This commit moves the mercurial mirroring script to the
"infrastructure" directory.
This commit was SVN r31360.
really "nightly" scripting.
Also, the crontab files were already moved to the infrastructure
directory; forgot to commit their removals from the "nightly"
directory.
This commit was SVN r31359.
While testing one-sided on LANL systems I found a couple more OSC
bugs that were not caught during the initial testing:
- In the passive target code we read the read lock count as a
char instead of the intended uint32_t. This causes lock to
lockup when using shared locks after 127 iterations.
- The post code used the wrong group when trying to increment post
counters. This causes a segmentation fault.
- Both the post and wait code used the wrong check in the inner
loop leading to an infinite loop.
cmr=v1.8.1:reviewer=jsquyres
This commit was SVN r31354.
There was a typo in the ompi_osc_gacc_long_start that was causing a
segmentation fault when executing long get accumulate operations.
cmr=v1.8.1:reviewer=jsquyres
This commit was SVN r31353.
newer
This commit adds a workaround for messages printed by the Cray PMI library
when launching using mpirun. We are still talking with Cray to find a
better fix but this will silence the warnings for now.
cmr=v1.8.1:reviewer=manjugv
This commit was SVN r31352.
See the ticket for more details.
cmr=v1.8.1:reviewer=rhc:ticket=4489
This commit was SVN r31351.
The following Trac tickets were found above:
Ticket 4489 --> https://svn.open-mpi.org/trac/ompi/ticket/4489
completion from _arguments instead of treating it as a state
cmr=v1.8.1:ticket=trac:4500
This commit was SVN r31350.
The following Trac tickets were found above:
Ticket 4500 --> https://svn.open-mpi.org/trac/ompi/ticket/4500
completion
_normal forces completion to be done on the subcommand. This gives us two
things:
- Completion of an executable for the first command argument
- Completion of options for that executable if any exist. If not it
will use normal completion rules (_files).
cmr=v1.8.1:reviewer=jsquyres
This commit was SVN r31346.
set default memheap start address to use one returned from memallocator
on 32bit system kernel may have issue because of this:
CONFIG_STRICT_DEVMEM kernel option which "prevents user space access to physical memory above 1MB"
fixed by Roman, reviewed by Igor/Miked
cmr=v1.8.1:reviewer=ompi-rm1.8
This commit was SVN r31331.
Cray moved the apstat command on CLE 5.x to /opt/cray/alps/../bin and
moved a configuration file. This commit adds support for both of these
changes.
cmr=v1.8.1
This commit was SVN r31329.
Aside from comments, these help files are empty -- so just remove
them. Also remove a few inclusions of show_help.h, since it isn't
used in those source files.
This commit was SVN r31328.
The contents of this file were superceded by mca-help-var.txt.
Indeed, this file was already removed from Makefile.am; it looks like
it was accidentally left in SVN.
This commit was SVN r31327.
Also:
* fix formatting error at top (make the emacs format line begin
with a comment character)
* Remove blank lines between topics and replace them with empty
comment lines (so that the help messages are not displayed with a
trailing blank line)
This commit was SVN r31324.
Also, add missing ORTE_ERROR_LOG in the other case where this error
message is used (i.e., ORTE_ERROR_LOG was used in the one place, so
let's also use it in the other place).
This commit was SVN r31321.
This type of help message is now handled by the MCA var system itself
(via the MCA_BASE_VAR_FLAG_ENVIRONMENT_ONLY flag at var_register
time).
This commit was SVN r31318.
This script can be run from any sub-tree in the OMPI code base. It
does several things:
* Find all help-*txt files and index all the topics found in the
sub-tree.
* Find all C/C++ source files (.c, .cc, .h) in the sub-tree, and look
for various flavors of the opal_show_help() function (e.g.,
including orte_show_help()) and search for hard-coded filenames and
topics.
* Also look for special tokens (in comments) in the source code for
help topics that are not necessarily hard-coded (e.g., topics that
are snprintf'ed).
* For each filename/topic found, output a warning if a) the file does
not exist, or b) that the topic does not exist in that file.
* Output a warning for any topic that is not referenced in the source
code (i.e., orphaned/now-unused help messages).
* Output a warning for any help file that appears to be empty.
* Output a warning for any help file that appears to be unused (i.e.,
no topics in the help file are referenced in code).
This commit was SVN r31311.