Igor Ivanov
426d1ce146
oshmem: Fix set of coverity issues
...
List of CIDs (scan.coverity.com):
1269721, 1269725, 1269787, 1269907, 1269909, 1269910, 1269911, 1269912,
1269959, 1269960, 1269984, 1269985, 1270136, 1270157, 1269845, 1269875,
1269876, 1269877, 1269878, 1269884, 1269885, 1270161, 1270162, 1270175,
1269734, 1269739, 1269742, 1269743
Signed-off-by: Igor Ivanov <Igor.Ivanov@itseez.com>
2015-02-19 23:00:17 +04:00
Ralph Castain
8b625c2756
Ensure the provider name isn't NULL before trying to strdup it
2015-02-19 08:38:23 -08:00
Jeff Squyres
4872b0fc28
openmpi-nightly-tarball: move the OMPI token file
...
Also put the coverity params up top, with all other params.
2015-02-19 09:24:36 -05:00
Jeff Squyres
6098b84294
libfabric: pass the appropriate LDFLAGS to libfabric components
...
When compiling against an external libfabric, ensure to also pass the
appropriate -L flags so that the compiler/linker can find it.
2015-02-19 05:35:38 -08:00
Jeff Squyres
2d636147e3
reachable netlink: fix the component symbol name
2015-02-19 04:25:15 -08:00
Ralph Castain
008755ab17
Remove stale file reference
2015-02-18 18:36:08 -08:00
Rolf vandeVaart
dbd0064713
Fix bug in CUDA-aware and GDR introduced by refactoring
2015-02-18 17:44:28 -05:00
Nathan Hjelm
0e09b9298a
mca/base: add framework flag indicating a framework does not have
...
dso components
This flag is needed for a special case framework: dl. The framework is
needed before any dl components can be used.
2015-02-18 14:03:51 -07:00
rhc54
ae16a168ec
Merge pull request #401 from rhc54/reachable
...
Add reachable framework for determining TCP connections
2015-02-18 08:22:48 -08:00
Jeff Squyres
b66fc3aed9
opal_check_visibility.m4: remove extraneous sym link
...
The sym link to this m4 is not necessary down in the component.
2015-02-18 03:40:25 -08:00
Jeff Squyres
f040ef09ff
libfabric: properly define HAVE_ALIAS_ATTRIBUTE
...
@ggouaillardet identified that HAVE_ALIAS_ATTRIBUTE was not properly
being defined in the embedded libfabric. This is because the
embedded configury missed the test for it (i.e., the real configure.ac
for libfabric always defines HAVE_ALIAS_ATTRIBUTE to 0 or 1 -- we
didn't emulate that properly here in libfabric's configure.m4).
Also, fix some grammar and properly escape another AC_MSG_CHECKING
message in libfabric's configure.m4.
2015-02-18 03:26:34 -08:00
Gilles Gouaillardet
28714b60cb
btl/sm: fix misc errors
...
as reported by Coverity as CIDs 711636 and 1269847
2015-02-18 17:05:19 +09:00
Gilles Gouaillardet
5db3065d63
fortran: fix misc memory leak in lookup_name
...
as reported by Coverity with CID 1269897
2015-02-18 16:41:56 +09:00
Gilles Gouaillardet
bda8058f39
coll/tuned: fix memory leaks and misc issues
...
as reported by Coverity with CIDs
70132, 70265, 70267, 70268, 70322, 70400, 70580, 70615,
1269934, 1269944, 1269968, 1269982, 1269983
2015-02-18 16:29:42 +09:00
Ralph Castain
9ef523c152
Add reachable framework for determining TCP connections
2015-02-17 21:47:09 -08:00
Ralph Castain
f7c28ea706
Fix bad test - opal_buffer and opal_ptr can support NULL locations
2015-02-17 21:46:23 -08:00
Ralph Castain
852fbca020
Shut coverity up
2015-02-17 21:17:23 -08:00
Ralph Castain
c1282d5b99
The opal_buffer type also generates its own alloc, so need to let it pass thru the check
2015-02-17 21:06:19 -08:00
Ralph Castain
207cc74f87
Correct name of help file
2015-02-17 16:03:20 -08:00
Ralph Castain
624b16e070
Protect the unload attribute function
2015-02-17 14:21:23 -08:00
Ralph Castain
78245e8a33
Continue massaging of the notifier framework. Convert it to an event-driven interface. Add the ability to report job state if requested. Cleanup object declarations.
2015-02-17 12:51:11 -08:00
Nathan Hjelm
298f238096
opal_lifo: add missing memory barrier to 64/32-bit atomic lifo
...
implementation
Need to ensure the head write is complete before updating the item's
next pointer.
References #371
2015-02-17 12:23:13 -07:00
Nathan Hjelm
030e9bc714
mtl/ofi: fix mca variable usage error
...
The fi_fabric function appears to free the provider string passed in
in the fabric_attr. This causes MCA to free an invalid pointer when
the parameter is freed.
References #374
2015-02-17 12:15:31 -07:00
Jeff Squyres
9cb047c1ee
libfabric: don't install the osd.h headers
...
When configured --with-devel-headers, there's now 2 "osd.h" header
files in libfabric (in different dirs). Automake's "install" target
didn't like this, and errored out.
Since embedding libfabric is a temporary measure, just avoid the
problem by not installing any libfabric headers.
2015-02-17 07:10:12 -08:00
Gilles Gouaillardet
8dc4f30fae
orte/tools: fix NULL pointer dereference
...
as reported by Coverity with CIDs 1196671 and 1196824
2015-02-17 15:45:06 +09:00
Gilles Gouaillardet
7dabc7b3ab
bml/r2: fix a typo
...
reported by Coverity as CID 1270228
2015-02-17 14:28:17 +09:00
Gilles Gouaillardet
55948f2a6d
hwloc: fix misc memory leak
...
as reported by Coverity with CID 1270441
(previous commit open-mpi/ompi@c25185f3a9 did not fully fix that one)
2015-02-17 14:06:15 +09:00
Gilles Gouaillardet
b762766969
orte/util: fix misc memory leaks
...
as reported by Coverity with CIDS 70314, 710653-710657 and 1196741-1196744
2015-02-17 12:27:23 +09:00
Ralph Castain
22f1d29b82
Re-introduce the ORTE notifier framework for logging errors that would otherwise result in abort for persistent systems. Thanks to L. Rajeshnarayanan of Intel for the contribution
...
Subsequent commits will integrate this capability with the state and errmgr frameworks.
2015-02-16 12:46:58 -08:00
Jeff Squyres
0bb1dfeca9
osc_base_obj_convert: remove unnecessary MEMCHECKER line
...
Commit open-mpi/ompi@1a3597aam changed the type of the `convertor`
variable from `ompi_osc_base_convertor_t` (which contained an
`opal_convertor_t`) to an `opal_convertor_t`. Hence, using memchecker
to ensure that the inner convertor of the `ompi_osc_base_convertor_t`
is considered initialized is now unnecessary.
2015-02-16 07:27:44 -08:00
Jeff Squyres
9d7171e8f1
convert: remove unnecessary/unused opal_size2int() function
...
The comments in the file even said "This file will hopefully not last
long in the tree...".
2015-02-16 07:17:33 -08:00
Jeff Squyres
4e318c9df1
coverity: Coverity updated the project name OpenMPI -> Open MPI
...
Therefore, we must update the URLs the match the "new" project name. :-)
2015-02-16 10:12:54 -05:00
Gilles Gouaillardet
02da8bfa93
ompi/java: fix misc bugs
...
as reported by Coverity with CIDs 1270187, 1270189 and 1270190
2015-02-16 15:19:53 +09:00
Gilles Gouaillardet
16c8af6725
opal/dss: correctly handle incorrect parameter in opal_value_unload
...
this fixes previous commit open-mpi/ompi@f9b3fb442e
Thanks Ralph for the review !
2015-02-16 14:53:35 +09:00
Gilles Gouaillardet
f9b3fb442e
opal/dss: correctly handle data==NULL in opal_value_unload
2015-02-16 14:40:42 +09:00
Gilles Gouaillardet
da7ffb6448
btl/vader: fix memory leak
...
as reported by Coverity with CID 1269904
2015-02-16 13:51:05 +09:00
Gilles Gouaillardet
c25185f3a9
opal/hwloc: fix misc memory leaks
...
as reported by Coverity with CIDS 710631-710638, 1196705,
1196716, 1196717, 1196752, 1196753
2015-02-16 12:23:37 +09:00
Gilles Gouaillardet
8dd77c692e
opal/hwloc: fix misc bugs
...
as reported by Coverity with CIDs 72224, 703566,
1196821, 1196842, 1196657 and 1196658
2015-02-16 11:59:48 +09:00
Gilles Gouaillardet
0ce59f2d29
pmix: fix misc memory leaks
...
as reported by Coverity as CID 1269843, 1269854, 1269856, 1269857 and 1269858
2015-02-16 11:19:43 +09:00
Gilles Gouaillardet
ccbdf64de4
opal/util: fix memory leak in opal_util_init_sys_limits
...
as reported by Coverity with CID 996174
previous commit (open-mpi/ompi@ca3a275823 )
dit not fix this CID
2015-02-16 11:05:35 +09:00
Gilles Gouaillardet
8fe8079080
Fix a build failure when configure'd with --without-hwloc
...
see http://mtt.open-mpi.org/index.php?do_redir=2235
2015-02-16 10:31:09 +09:00
Gilles Gouaillardet
0d560ddf77
osc: fix typo
...
this typo caused build failure when configure'd with --enable-memchecker
see http://mtt.open-mpi.org/index.php?do_redir=2234
2015-02-16 10:09:08 +09:00
George Bosilca
a7a4d6335e
Various cleanups.
2015-02-15 11:39:09 -05:00
George Bosilca
a4aa74d4b9
Fix the SM BTL.
2015-02-15 11:38:45 -05:00
George Bosilca
84994c7438
This comment seems to contradict with the compilers opportunities to
...
optimize the unused data out.
2015-02-15 11:37:22 -05:00
Jeff Squyres
7d3708d3b8
openmpi-nightly-coverity: ensure the argument is defined
2015-02-15 07:25:53 -05:00
Jeff Squyres
b207736170
openmpi-nightly-coverity: use far simpler version of safe_system()
...
The previous safe_system() is quite thorough, but much more than we
really need in this script. Use a far simpler version that is
significantly easier to maintain.
Also log some of the critical steps that a human can examine the
output upon a failure (e.g., when the failure happens when launched
via cron).
Finally, set the version number to not include "openmpi-", because
Coverity has a limited-width display of the version number.
2015-02-14 10:12:51 -05:00
Jeff Squyres
b27ba475ef
oshmem java: really abort in bad situations
...
The previous condition just called assert(), which is a no-op in
non-debug builds. Change it to print a message and then call abort()
to really actually above.
This was CID 1270155.
2015-02-14 07:07:01 -08:00
Jeff Squyres
dfd21e465d
openmpi-nightly-tarball.sh: only coverity analyze master (for now)
2015-02-14 08:39:55 -05:00
Jeff Squyres
2ca14acaf0
libfabric: add missing files into Makefile.am
2015-02-14 05:01:29 -08:00
