Jeff Squyres
3efb5f56ae
dl dlopen: ensure dirs is not NULL
...
opal_argv_split() may have returned NULL.
This was Coverity CID 1288088
2015-03-10 07:43:20 -07:00
Jeff Squyres
86968dcdda
dl dlopen: fix resource leak
...
closedir() was one block higher than it should have been.
This was Coverity CID 1288087.
2015-03-10 07:43:20 -07:00
Jeff Squyres
546ad3f060
dl dlopen: free resources upon error
...
Ensure to take the right path out upon errors (that will free any
pending resources).
This was Coverity CID 1288086
2015-03-10 07:43:19 -07:00
Rolf vandeVaart
49b5eb6c91
Fix missing initialization of variable
2015-03-10 10:33:27 -04:00
Jeff Squyres
4b2cba46f4
usnic: fix bootstrap error paths
...
Fix previously-unfinished error paths during startup/bootstrapping.
Instead of just blindly continuing on when an fi_* function call
fails, opal_show_help and skip that device.
Also, only check the usnic config minimums once. They're VIC-wide and
won't change on a per-device basis -- we only need to check them once.
Fixes CSCut19179.
2015-03-09 16:57:41 -07:00
Jeff Squyres
1995f6beba
cuda: convert to opal_dl interface
2015-03-09 08:18:13 -07:00
Jeff Squyres
a9d86129c6
mca base: convert to opal_dl interface
2015-03-09 08:16:55 -07:00
Jeff Squyres
39364d315c
libltdl: dl component based on libltdl
...
Works on any system that libltdl supports and has ltdl.h and libltdl
available.
2015-03-09 08:16:55 -07:00
Jeff Squyres
7d340c0c26
dlopen: simple dl component based on POSIX dlopen
...
Works on systems with dlopen (e.g., Linux and OS X). It requires
dlfcn.h and libdl, which many systems have installed by default.
2015-03-09 08:16:55 -07:00
Jeff Squyres
e81c070ef0
dl framework: new dynamic loader framework
...
Embedding libltdl without the use of Libtool bootstrapping has
proven... difficult. Instead, create a new simple "dl" framework. It
only provides 4 functions:
- open a DSO (very similar to lt_dlopenadvise())
- lookup a symbol in a previously-opened DSO (very similar to lt_dlsym())
- close a previously-opened DSO (very similar to lt_dlclose())
- iterate over all files in a directory (very similar to ld_dlforeachfile())
There will be follow-on commits with a simple dlopen-based component
(nowhere near as complete/functional as libltdl, but good enough for
Linux and OS X), and a libltdl-based component for all other
platforms.
The intent is that the dlopen-based component can be built by default
in almost all cases. But if libltdl is available, that component will
be built. End result: we still get DSO-based functionality by default
in (almost?) all cases. Without embedding libltdl. Which is what we
want.
2015-03-09 08:16:55 -07:00
Gilles Gouaillardet
2789d782ab
timer/linux: fix insecure data handling
...
as reported by Coverity with CID 1269923
2015-03-09 19:14:56 +09:00
Rolf vandeVaart
237c268a09
Add extra check during cleanup to make sure we really should clean up the CUDA resources.
2015-03-06 13:12:19 -05:00
Gilles Gouaillardet
da90ed4483
opal/compress: remove misc dead code
...
as reported by Coverity with CIDs 71856,
1269714, 1269715, 1269717, 1269718, 1269723, 1269724
2015-03-06 15:34:08 +09:00
Gilles Gouaillardet
521317341d
btl/openib: fix a double free
...
as reported by Coverity with CID 1287033
2015-03-06 14:58:11 +09:00
George Bosilca
75479c0f17
Fix some typos.
2015-03-05 12:59:58 -05:00
Alina Sklarevich
1560ed9761
initialize opal_common_verbs_want_fork_support to -1.
...
This way, if the call to ibv_fork_init() fails, the job will still
continue.
2015-03-05 14:29:09 +02:00
Gilles Gouaillardet
e1cc931e1b
btl/tcp: silence CID 710616
2015-03-05 14:20:08 +09:00
Gilles Gouaillardet
852dbafd51
mca/base: fix misc memory leaks
...
as reported by Coverity with CIDs 710628, 1196713 and 1269855
2015-03-05 14:06:18 +09:00
Gilles Gouaillardet
134c866aa9
btl/openib: fix misc memory leaks
...
as reported by Coverity with CIDs 1269848, 1269852 and 1269862
2015-03-05 14:06:18 +09:00
Gilles Gouaillardet
d1b2f043ff
fix misc memory leaks
...
as already reported by Coverity with CIDs
71818, 71819, 72250, 715767, 1196749 and 1274002
2015-03-05 13:58:05 +09:00
Mike Dubman
171d674ca4
Merge pull request #441 from open-mpi/revert-438-topic/use_opal_common_verbs_want_fork_support
...
Revert "create the opal_common_verbs_want_fork_support parameter."
2015-03-04 10:13:00 +02:00
Gilles Gouaillardet
f43b5b46ee
btl/openib: fix heterogeneous support
...
Thanks @bosilca for the pointer
2015-03-04 13:53:05 +09:00
Gilles Gouaillardet
81b0444ef2
btl/openib: fix comment syntax, no code change
...
and silence gcc warning about nested comments
2015-03-04 11:24:14 +09:00
Rolf vandeVaart
edf58eb549
Implement CUDA-aware workaround while fork support worked out
2015-03-03 09:50:01 -05:00
Mike Dubman
98503b56e0
Revert "create the opal_common_verbs_want_fork_support parameter."
2015-03-03 14:28:31 +02:00
Mike Dubman
cc7caf699e
Merge pull request #438 from alinask/topic/use_opal_common_verbs_want_fork_support
...
create the opal_common_verbs_want_fork_support parameter.
2015-03-02 07:43:37 +02:00
Gilles Gouaillardet
04a0438b56
sec/munge: send NULL terminated strings
2015-03-02 12:19:46 +09:00
Alina Sklarevich
8fe42f1bc1
create the opal_common_verbs_want_fork_support parameter.
...
call the opal_common_verbs_mca_register function to make sure that
opal_common_verbs_want_fork_support mca parameter is created and therefore
can be used to control the fork support.
2015-03-01 17:40:49 +02:00
Ralph Castain
d81c372ea2
Remove the "forwarding" of envars when direct launched - there aren't any envars we can forward under that use-case
2015-02-27 12:19:48 -08:00
Rolf vandeVaart
e48bc77342
Fix the coverity fix
2015-02-27 12:49:44 -05:00
Rolf vandeVaart
cfe91d4d0f
Fix compile error for CUDA-aware by using new fork MCA parameter.
2015-02-27 10:00:46 -05:00
Gilles Gouaillardet
e0026224e7
pstat linux: close the files
...
as reported by Coverity with CID 71983
2015-02-27 19:48:01 +09:00
Gilles Gouaillardet
f33cd58ee9
btl/tcp: fix misc memory leaks
...
as reported by Coverity with CIDs 710615, 710616 and 710618
2015-02-27 19:16:22 +09:00
Gilles Gouaillardet
60404d1953
btl/base: fix misc memory leaks
...
as reported by Coverity as CIDs 71818 71819
2015-02-27 19:06:06 +09:00
George Bosilca
455b465329
Reflect in the naming the location of the variable.
2015-02-26 18:22:23 -05:00
Jeff Squyres
5215dc0db3
shmem base: do not allow framework selection to occur twice
...
Both opal_shmem_base_select() and
opal_shmem_base_best_runnable_component_name() and were calling
opal_shmem_base_runtime_query(), which would do component selection
(and closing of losing components) twice.
Put protection in opal_shmem_base_runtime_query() to return the cached
results the second time. Additionally, make
opal_shmem_base_runtime_query() "own" the cached results
(vs. opal_shmem_base_select).
2015-02-26 14:56:46 -08:00
Jeff Squyres
312b0afb67
shmem base: make these the version-less struct names
...
Minor style commit; no substantive code change.
2015-02-26 14:56:46 -08:00
Jeff Squyres
90a2c3cd99
shmem base: this function had no purpose being public
...
Make it static to the base, and move it up higher in the file so that
multiple functions beneath it can call it.
2015-02-26 14:56:46 -08:00
Jeff Squyres
9666884cf1
shmem: make the base_module_t a real mca_base_module_t
...
This allows the opal_shmem_base_module_t to be properly cast to an
mca_base_module_t.
(this commit is the rationale for the previous shmem C99 .member
initialization commit)
2015-02-26 14:56:46 -08:00
Jeff Squyres
62259a74f5
shmem: use C99 struct initialization
...
Use .member=foo initialization for the shmem framework and components
and modules.
2015-02-26 14:56:46 -08:00
George Bosilca
778ba0317e
Revert "Minor cleanups."
...
This reverts commit 3b4da0bda4c3a29e4b20639825ce1642df157b2a.
2015-02-26 17:53:58 -05:00
George Bosilca
2c60c18e6f
A better fix for the want_fork_support issue. I noticed a naming
...
conflict where ompi was used down in OPAL. I correctly renamd the
MCA parameter, and created a deprecated synomym for the old
name.
2015-02-26 17:35:54 -05:00
George Bosilca
5c3ce3a737
Merge branch 'master' of github.com:open-mpi/ompi
2015-02-26 17:10:18 -05:00
George Bosilca
aeace0468e
A more sensible fix, move the MCA variable in the verbs common area.
2015-02-26 16:51:09 -05:00
Nathan Hjelm
855d422e62
Merge pull request #408 from hjelmn/btl_3_0_mod
...
btl: expose local registration thresholds
2015-02-26 12:57:43 -07:00
Mike Dubman
dbc15009b6
Merge pull request #415 from alinask/topic/fix_fork_support_flow
...
Fix the calls to ibv_fork_init and remove btl_openib_want_fork_support.
2015-02-26 21:50:11 +02:00
Rolf vandeVaart
bbdcf9ff33
Fix missing cast change from opal_free_list_changes. Fixes warning
2015-02-26 11:24:49 -05:00
Gilles Gouaillardet
b888768ca3
btl/scif: fix a typo
...
this is likely a typo introduced by open-mpi/ompi@5f1254d710
@hjelmn could you please double check this ?
2015-02-26 13:45:51 +09:00
Nathan Hjelm
8a17e69067
btl/ugni: fix typos introduced by free list update
2015-02-25 12:43:05 -07:00
George Bosilca
f3b58006c8
Merge branch 'master' of github.com:open-mpi/ompi
2015-02-25 12:01:35 -05:00
