George Bosilca
170b9c344e
Mea culpa. I forget to initialize the max_data before the call to the
...
convertor.
This commit was SVN r18651.
2008-06-12 17:24:39 +00:00
Pavel Shamis
dc3f14736d
Fixing QP initialization stuff.
...
This commit was SVN r18650.
2008-06-11 16:31:39 +00:00
Ralph Castain
a87aa442e3
Remove last remaining reference to iof_flush - it was #if'd out anyway. The existing flush code appears to have several critical problems. Given the impending rework of the IOF subsystem, there is no point in trying to fix it here.
...
This commit was SVN r18649.
2008-06-11 16:25:46 +00:00
Ralph Castain
1beb3df065
Let threads exist in these platforms...
...
This commit was SVN r18648.
2008-06-11 16:24:34 +00:00
Ralph Castain
1f41069ac9
Fix CID 752 - if we can't find the daemon job object, we have to ensure we exit without attempting to dereference it
...
This commit was SVN r18647.
2008-06-11 14:49:58 +00:00
Ralph Castain
13ea4e4673
Be consistent - since we don't strdup the other values for param, don't strdup this one.
...
This allows r18645 to fix the memory corruption issue, but also allows us to resolve the memory leaks cited by CID 1039
This commit was SVN r18646.
The following SVN revision numbers were found above:
r18645 --> open-mpi/ompi@53d83ba1c5
2008-06-11 14:42:47 +00:00
Pak Lui
53d83ba1c5
Take out a couple of free's.
...
This commit fixes trac:1343
This commit was SVN r18645.
The following Trac tickets were found above:
Ticket 1343 --> https://svn.open-mpi.org/trac/ompi/ticket/1343
2008-06-11 14:02:49 +00:00
Ralph Castain
d61fe87d04
Use the opal_show_help system if orte_show_help has not been initialized
...
This fixes ticket #1342
This commit was SVN r18644.
2008-06-11 12:50:40 +00:00
Ralph Castain
f9d809748c
Glad someone found that last error - caused me to review the code and find a couple of other cleanups! Nothing major, but just ensure that things flow smoothly since we had a "shadowed" variable.
...
This commit was SVN r18643.
2008-06-10 19:15:59 +00:00
Camille Coti
67cd1849f7
*map was still NULL in the else statement, inducing a segmentation fault when a field of the structure was accessed to.
...
This commit was SVN r18642.
2008-06-10 19:00:57 +00:00
Ralph Castain
1a422995ae
Fix two Coverity complaints CID 813 (value defined and not used) and 1039 (resource leak). While doing so, found and fixed another less obvious memory leak.
...
This commit was SVN r18641.
2008-06-10 17:53:28 +00:00
Tim Mattox
4493ec7d7d
Resync the trunk's NEWS file with v1.2.7 NEWS file.
...
This commit was SVN r18640.
2008-06-10 17:46:31 +00:00
Matthias Jurenz
a9ff2b84f2
Bugfix (Ticket #1318 ): Implemented copy-contructor of 'FiltHandlerArgument' in 'vt_filthandler.cc' instead of the header file 'vt_filthandler.h'
...
This commit was SVN r18637.
2008-06-10 09:03:21 +00:00
Galen Shipman
a239877b78
revert my previous boneheadedness
...
This commit was SVN r18634.
2008-06-10 01:19:04 +00:00
George Bosilca
dc0ab0d0a8
Enable the sendi path.
...
This commit was SVN r18633.
2008-06-09 23:03:56 +00:00
Brian Barrett
4127bd0dcc
fix two other mistakes in the cnos ess
...
This commit was SVN r18632.
2008-06-09 22:28:26 +00:00
George Bosilca
f72ab90b16
Allow xgrid to compile again.
...
This commit was SVN r18631.
2008-06-09 21:51:41 +00:00
Brian Barrett
11cd3a7cba
Fix problem where local rank always had different architecture than remote
...
ranks on Red Storm
This commit was SVN r18630.
2008-06-09 21:46:03 +00:00
Ralph Castain
8d9ff44134
Add visibility required for some environments and configs
...
This commit was SVN r18629.
2008-06-09 21:28:19 +00:00
Galen Shipman
4ef4a9520f
remove showhelp..
...
This commit was SVN r18628.
2008-06-09 20:53:01 +00:00
Aurelien Bouteiller
ebe6df4c06
Moving the pml_v_output global variable inside the pml_v structure. This should avoid one of the missing symbols when visibility is enabled.
...
This commit was SVN r18627.
2008-06-09 20:38:44 +00:00
Ralph Castain
03ab4f5c64
Make the ifdef name mirror the change in filename
...
This commit was SVN r18626.
2008-06-09 20:36:55 +00:00
Ralph Castain
c13cadc3c7
Refs trac:1255
...
This commit repairs the debugger initialization procedure. I am not closing the ticket, however, pending Jeff's review of how it interfaces to the ompi_debugger code he implemented. There were duplicate symbols being created in that code, but not used anywhere. I replaced them with the ORTE-created symbols instead. However, since they aren't used anywhere, I have no way of checking to ensure I didn't break something.
So the ticket can be checked by Jeff when he returns from vacation... :-)
This commit was SVN r18625.
The following Trac tickets were found above:
Ticket 1255 --> https://svn.open-mpi.org/trac/ompi/ticket/1255
2008-06-09 20:34:14 +00:00
Galen Shipman
9efbec0383
fix normal send path
...
remove unneeded checks
This commit was SVN r18624.
2008-06-09 20:25:27 +00:00
Galen Shipman
dbd282fcad
doh.. fix GET protocol..
...
This commit was SVN r18623.
2008-06-09 19:45:44 +00:00
Ralph Castain
2cc8b2c51f
Add yet another test, this one for proper error behavior when someone call an MPI function after calling MPI_Finalize.
...
Add a minor debug that outputs the orterun exit status to stderr when orte_debug is set.
This commit was SVN r18622.
2008-06-09 19:21:20 +00:00
Ralph Castain
bf5c34d10a
The rsh launcher is one place where multi-word MCA params would have to be passed via the orted cmd line. In such a case, we have to explicitly include quote marks about the param value. Add that capability here.
...
This commit fixes trac:1200
This commit was SVN r18621.
The following Trac tickets were found above:
Ticket 1200 --> https://svn.open-mpi.org/trac/ompi/ticket/1200
2008-06-09 19:07:19 +00:00
Ralph Castain
11692ca98e
Update tests to flag that these are non-MPI apps
...
This commit was SVN r18620.
2008-06-09 18:48:21 +00:00
Ralph Castain
9613b3176c
Effectively revert the orte_output system and return to direct use of opal_output at all levels. Retain the orte_show_help subsystem to allow aggregation of show_help messages at the HNP.
...
After much work by Jeff and myself, and quite a lot of discussion, it has become clear that we simply cannot resolve the infinite loops caused by RML-involved subsystems calling orte_output. The original rationale for the change to orte_output has also been reduced by shifting the output of XML-formatted vs human readable messages to an alternative approach.
I have globally replaced the orte_output/ORTE_OUTPUT calls in the code base, as well as the corresponding .h file name. I have test compiled and run this on the various environments within my reach, so hopefully this will prove minimally disruptive.
This commit was SVN r18619.
2008-06-09 14:53:58 +00:00
Ralph Castain
83dd3d8c6f
Restore the ability to forcibly terminate by providing multiple ctrl-c's
...
This commit was SVN r18618.
2008-06-09 13:08:54 +00:00
Ralph Castain
e1e224b81a
Silence a couple of minor compiler warnings
...
This commit was SVN r18617.
2008-06-09 12:57:41 +00:00
Jeff Squyres
c087b4cd4f
* Revert r18067
...
* Add specific comments about why we're not setting MPI_ERROR here
This commit was SVN r18616.
The following SVN revision numbers were found above:
r18067 --> open-mpi/ompi@58e31d767e
2008-06-07 02:44:10 +00:00
Pak Lui
caac0e0182
Add in a couple missing ones from r18611 for all tm users out there...
...
This commit was SVN r18615.
The following SVN revision numbers were found above:
r18611 --> open-mpi/ompi@7bee71aa59
2008-06-06 22:53:43 +00:00
Ralph Castain
b65eb54ea2
Cut out a new iof pull - that capability isn't ready yet for the trunk, but will be coming shortly
...
Thanks to Pak for letting me know...
This commit was SVN r18614.
2008-06-06 21:24:15 +00:00
Pak Lui
7f7777a538
Check for NULL in prefix_dir.
...
This commit fixes trac:1337.
This commit was SVN r18612.
The following Trac tickets were found above:
Ticket 1337 --> https://svn.open-mpi.org/trac/ompi/ticket/1337
2008-06-06 19:55:01 +00:00
Ralph Castain
7bee71aa59
Fix a potential, albeit perhaps esoteric, race condition that can occur for fast HNP's, slow orteds, and fast apps. Under those conditions, it is possible for the orted to be caught in its original send of contact info back to the HNP, and thus for the progress stack never to recover back to a high level. In those circumstances, the orted can "hang" when trying to exit.
...
Add a new function to opal_progress that tells us our recursion depth to support that solution.
Yes, I know this sounds picky, but good ol' Jeff managed to make it happen by driving his cluster near to death...
Also ensure that we declare "failed" for the daemon job when daemons fail instead of the application job. This is important so that orte knows that it cannot use xcast to tell daemons to "exit", nor should it expect all daemons to respond. Otherwise, it is possible to hang.
After lots of testing, decide to default (again) to slurm detecting failed orteds. This proved necessary to avoid rather annoying hangs that were difficult to recover from. There are conditions where slurm will fail to launch all daemons (slurm folks are working on it), and yet again, good ol' Jeff managed to find both of them.
Thanks you Jeff! :-/
This commit was SVN r18611.
2008-06-06 19:36:27 +00:00
George Bosilca
2aec094d56
The PML V is a component so it should use OMPI_MODULE_DECLSPEC.
...
This commit was SVN r18610.
2008-06-06 17:43:57 +00:00
George Bosilca
b2aa751c28
Remove a race condition in the threaded mode. As a callback is allowed
...
to modify the callback array (add or remove), make sure we don't call
the same callback twice if it get remove in another thread.
This commit was SVN r18608.
2008-06-06 15:54:40 +00:00
George Bosilca
ae7bca2f4a
Update the MPI_ERROR field as well.
...
This commit was SVN r18607.
2008-06-06 15:53:17 +00:00
Josh Hursey
1de50b523c
Fix some Coverity 'Event set_but_not_used' highlights.
...
Thanks to Jeff for bringing them to my attention.
This commit was SVN r18606.
2008-06-06 14:38:41 +00:00
Terry Dontje
e8c8d0c03b
This commit fixes trac:1336.
...
This commit was SVN r18605.
The following Trac tickets were found above:
Ticket 1336 --> https://svn.open-mpi.org/trac/ompi/ticket/1336
2008-06-06 12:56:45 +00:00
Jeff Squyres
1f226b5898
Adjust the comment to be correct, per
...
http://www.open-mpi.org/community/lists/devel/2008/06/4095.php .
This commit was SVN r18604.
2008-06-06 01:23:58 +00:00
Jeff Squyres
12a3fe57e1
As pointed out by Ralf
...
W. (http://www.open-mpi.org/community/lists/devel/2008/06/4095.php ),
these dependencies don't need to be here.
This commit was SVN r18603.
2008-06-06 01:20:47 +00:00
Jeff Squyres
b123629e6a
Fix CIDs 458, 716, 717: ensure that strings are long enough to always
...
be properly \0 terminated.
This commit was SVN r18602.
2008-06-06 00:59:08 +00:00
Jeff Squyres
85834b22e6
Change the default to not enable heterogeneous builds; we detect at run-time if a heterogeneous job was started and will barf appropriately if OMPI was not compiled with heterogeneous support
...
This commit was SVN r18601.
2008-06-06 00:00:37 +00:00
Jeff Squyres
e2b08aaca4
Fix bad free's found in CID 707 and CID 708.
...
This commit was SVN r18600.
2008-06-05 20:49:33 +00:00
Jeff Squyres
1a748bc7be
First cut at the NetEffect NE020 NIC.
...
This commit was SVN r18599.
2008-06-05 20:24:24 +00:00
Jeff Squyres
d3795d7a34
Fix CID 987: remove unused variable.
...
This commit was SVN r18598.
2008-06-05 20:17:02 +00:00
Jeff Squyres
9109f7126a
Per CID 988, free some memory that would be leaked in an error condition.
...
This commit was SVN r18597.
2008-06-05 20:04:38 +00:00
Jeff Squyres
f0d465c30a
Slightly simplify the code and remove a compiler warning.
...
This commit was SVN r18596.
2008-06-05 19:08:08 +00:00