Jeff Squyres
0d1e177453
Remove 2 extraneous ORTE_ERROR_LOGs and 1 extraneous opal_output.
...
This commit was SVN r22071.
2009-10-07 20:12:37 +00:00
Jeff Squyres
d317ce0367
Fix CID 1381: don't bother checking for (NULL == p); it's overkill.
...
posix_memalign() will either return 0 or not, indicating success. And
if posix_memalign() fails, it's not always going to be due to
out-of-memory -- just return ERR_IN_ERRNO.
This commit was SVN r22070.
2009-10-07 20:01:50 +00:00
Jeff Squyres
7900451e4e
Fix CID 1326: for the (unlikely) case where
...
opal_paffinity_base_get_processor_info() returns failure.
This commit was SVN r22069.
2009-10-07 19:52:08 +00:00
Jeff Squyres
5c1af9c2ba
Fix CID 1355: ensure that mca_base_param_reg_int() actually
...
succeeded.
This commit was SVN r22068.
2009-10-07 19:43:35 +00:00
Jeff Squyres
d56b8d9183
Fix CID 1369: minor memory leak.
...
This commit was SVN r22067.
2009-10-07 19:40:00 +00:00
Jeff Squyres
de59a24593
Fix CID 1384. Also remove some opal_output(0,...)'s in favor of
...
ORTE_ERROR_LOG.
This commit was SVN r22066.
2009-10-07 18:58:58 +00:00
Jeff Squyres
ec71acf7ca
Fix CID 1385: fix an over-aggressive use of close, munmap, etc. in the
...
error case. Also check for MAP_FAILED (instead of -1) from mmap().
This commit was SVN r22065.
2009-10-07 18:43:37 +00:00
Jeff Squyres
5ec86e5fe5
Fix CID 1386: fd can't be valid here, so don't bother to close/unlink.
...
This commit was SVN r22064.
2009-10-07 18:30:26 +00:00
Jeff Squyres
3b4f695009
MAP_FAILED is more POSIX-ly correct than ((void*)-1).
...
This commit was SVN r22063.
2009-10-07 14:20:18 +00:00
Jeff Squyres
d7db5f4c32
mmap(2) says that you must call mmap() with either MAP_SHARED or
...
MAP_PRIVATE. We didn't catch this because we checked for a NULL
return, not a -1 return. Doh! Thanks again to Julian Seward for
continuing to track this down.
This commit was SVN r22062.
2009-10-07 12:39:01 +00:00
Jeff Squyres
977574bd45
Fix a problem noted by Julian Seward: MAKE_MEM_UNDEFINED is not the
...
opposite of MAKE_MEM_DEFINED. Also add in a call to NOACCESS to
(mostly) reverse the effects of MAKE_MEM_DEFINED (technically, page 0
was accessible before this, even though it's a Bad Idea to access it).
This commit was SVN r22056.
2009-10-06 17:55:49 +00:00
Jeff Squyres
932b43be04
Check to ensure that the mmap succeeded. Thanks to Julia Seward for
...
pointing out the problem and suggesting the fix.
This commit was SVN r22055.
2009-10-06 17:44:14 +00:00
Shiqing Fan
14e6952482
Update two CMake find modules.
...
This commit was SVN r22054.
2009-10-06 08:01:37 +00:00
Shiqing Fan
7dff65cbc9
Clean up a little bit.
...
Add an option for setting up the job name.
This commit was SVN r22053.
2009-10-06 07:52:43 +00:00
George Bosilca
01bb4dafe0
Add a comment.
...
This commit was SVN r22052.
2009-10-05 17:36:11 +00:00
Jeff Squyres
0f8ac9223f
Refs trac:2023, #2027 .
...
This commit does a bunch of things:
* Address all remaining code review items from CMR #2023 :
* Defer mmap setup to be lazy; only set it up the first time we
invoke a collective. In this way, we don't penalize apps that
make lots of communicators but don't invoke collectives on them
(per #2027 ).
* Remove the extra assignments of mca_coll_sm_one (fixing a
convertor count setup that was the real problem).
* Remove another extra/unnecessary assignment.
* Increase libevent polling frequency when using the RML to
bootstrap mmap'ed memory.
* Fix a minor procs-related memory leak in btl_sm.
* Commit a datatype fix that George and I discovered along the way to
fixing the coll sm.
* Improve error messages when mmap fails, potentially trying to
de-alloc any allocated memory when that happens.
* Fix a previously-unnoticed confusion between extent and true_extent
in coll sm reduce.
This commit was SVN r22049.
The following Trac tickets were found above:
Ticket 2023 --> https://svn.open-mpi.org/trac/ompi/ticket/2023
2009-10-02 17:13:56 +00:00
Ralph Castain
dcab61ad83
Restore the prior default rank assignment scheme for round-robin mappers. Ensure that each app_context has sequential vpids.
...
This commit was SVN r22048.
2009-10-02 03:16:18 +00:00
Jeff Squyres
c8c3132605
Also check for posix_memalign.
...
This commit was SVN r22045.
2009-10-01 23:51:48 +00:00
George Bosilca
cf9f38eb56
Instead of just complaining about a version mismatch, clearly lists the versions
...
available locally.
This commit was SVN r22044.
2009-10-01 14:06:41 +00:00
George Bosilca
16c6370b73
A little bit of cleanup, the main logic is still the same.
...
This commit was SVN r22043.
2009-10-01 14:05:25 +00:00
Ralph Castain
a15c58c583
Fix the proc assignment into the job data object during assignment of vpids as comm_spawned procs were being overwritten by their parents with the same vpid.
...
Add a little debug output when updating proc state
This commit was SVN r22042.
2009-10-01 13:44:34 +00:00
George Bosilca
b04a42ba3b
Add the format to the opal_output call.
...
This commit was SVN r22041.
2009-09-30 23:33:12 +00:00
Ralph Castain
51f64aaf96
Add a new ras module to support bootstrap operations. Additional functionality may eventually be required in the component, but for now all it does is provide a mechanism for ensuring that other allocations don't confuse the system.
...
Only active if specifically directed to use it
This commit was SVN r22040.
2009-09-30 23:30:24 +00:00
Ralph Castain
358528309e
Per the RFC, disable IPv6 support unless specifically requested to enable it, even if the underlying system has the required include headers.
...
NOTE: the IPv6 support is currently marginally working and has problems when IPv6 headers are present but the interfaces are not configured to use that protocol, per several reports from users. It is unclear that anyone is willing/able to support this capability. Should that situation change, this change can be reconsidered.
This commit was SVN r22039.
2009-09-30 23:27:11 +00:00
Shiqing Fan
21f6a1cb7c
Update the corresponding part of mmap for Windows.
...
This commit was SVN r22038.
2009-09-30 14:50:17 +00:00
Ralph Castain
1d7ab97c84
Update the multicast framework to allow specification of different message scopes per various RFCs. Redefine the API a little to utilize channel numbers without worrying about the specifics of their addressing
...
This commit was SVN r22037.
2009-09-30 14:40:43 +00:00
Ralph Castain
84a45fea0a
Add a convenience macro for assembling network addresses
...
This commit was SVN r22036.
2009-09-30 14:38:52 +00:00
Ralph Castain
19a13039aa
Strange - remove duplicated comment
...
This commit was SVN r22035.
2009-09-30 14:38:13 +00:00
Shiqing Fan
96e9ffa016
Fix a type cast.
...
This commit was SVN r22034.
2009-09-30 14:02:47 +00:00
Ralph Castain
105ef7eeaf
Turn off a debug by properly setting the verbosity value
...
This commit was SVN r22033.
2009-09-30 06:47:48 +00:00
George Bosilca
a6a6df0c48
MPIR_Breakpoint should be externally visible in order to allow the
...
debugger to find the symbol in our libs.
This commit was SVN r22032.
2009-09-30 04:07:55 +00:00
Rainer Keller
a88b97f89f
- Add the uncrustify source code beautification for Open MPI.
...
This commit was SVN r22031.
2009-09-29 16:10:01 +00:00
Ralph Castain
47285fe221
Have ompi_info output a better error message when a requested framework cannot be found, either because it doesn't exist or support wasn't configured into OMPI.
...
This commit was SVN r22030.
2009-09-29 13:56:14 +00:00
Ralph Castain
5673b230d7
Update ompi_info to support new sensor, fddp, and rmcast frameworks if OMPI was configured to include them
...
This commit was SVN r22029.
2009-09-29 13:14:39 +00:00
Ralph Castain
5a24d6f60e
Remove an option that the orteds don't actually support...
...
This commit was SVN r22027.
2009-09-29 02:08:27 +00:00
Ralph Castain
176fdd3a83
Add a new API to the show_help system that allows external users (e.g., libraries built upon OMPI) to define their own locations for show_help files. This allows such users to exploit the rather nice features of the OPAL show_help system -without- interfering with the ability of the ORTE and OMPI layers to use show_help themselves.
...
Reviewed by Jeff to protect toes...and to get some good comments :-)
This commit was SVN r22026.
2009-09-29 02:07:46 +00:00
George Bosilca
163c64cb4d
Add a comment.
...
This commit was SVN r22025.
2009-09-28 17:28:01 +00:00
Jeff Squyres
7145b95bd8
Refs trac:2032. Add comment explaining why we have MPI_LOGICALx datatypes
...
in fortran.
This commit was SVN r22024.
The following Trac tickets were found above:
Ticket 2032 --> https://svn.open-mpi.org/trac/ompi/ticket/2032
2009-09-28 15:45:57 +00:00
Samuel Gutierrez
5182617321
Update LANL's rr-class platform files.
...
This commit was SVN r22023.
2009-09-28 14:10:11 +00:00
Ralph Castain
c749fefbd0
Instead of an odls-base mca param, make report_bindings a global param so that we can (a) detect it was set in the plm, and then (b) ensure it gets passed along to remote orteds so they will comply with the request.
...
This commit was SVN r22021.
2009-09-28 03:17:15 +00:00
Ralph Castain
47c9a5409e
Ensure that tools init the multicast channel correctly
...
This commit was SVN r22020.
2009-09-28 03:15:51 +00:00
Ralph Castain
ef0fd8b8d1
Return an error code if the job failed to start
...
This commit was SVN r22019.
2009-09-26 03:34:58 +00:00
Ralph Castain
e337fa686e
Correct handling of pointer array indexing
...
This commit was SVN r22018.
2009-09-26 03:33:55 +00:00
Ralph Castain
6fa2e81491
Correct handling of pointer array indexing
...
This commit was SVN r22017.
2009-09-26 03:33:26 +00:00
Jeff Squyres
bc3060d668
Fixes trac:2028. George and I found this via some collaborative debugging
...
(yay cisco webex!). Make sure we only go up to OPAL max datatype, not
OMPI max datatype.
This commit was SVN r22016.
The following Trac tickets were found above:
Ticket 2028 --> https://svn.open-mpi.org/trac/ompi/ticket/2028
2009-09-25 21:52:42 +00:00
Ethan Mallove
e9014ff20e
Adjust comment according to r22014
...
This commit was SVN r22015.
The following SVN revision numbers were found above:
r22014 --> open-mpi/ompi@9e951ce664
2009-09-25 19:53:16 +00:00
Ethan Mallove
9e951ce664
Remove static
from MPIR_Breakpoint
so Intel compilers will not inline it
...
This commit was SVN r22014.
2009-09-25 19:14:19 +00:00
Jeff Squyres
1886d5a004
Remove the libopenmpi_malloc library; it is only necessary for
...
backwards compatibility in the v1.3 series.
This commit was SVN r22013.
2009-09-25 17:09:54 +00:00
Ralph Castain
709b36efb4
Cleanup auto-wireup and enable tools to "discover" the HNP via multicast
...
This commit was SVN r22012.
2009-09-25 01:00:09 +00:00
Abhishek Kulkarni
2af7657db1
A few changes to the FTB notifier interface:
...
- add an orte ftb notifier help file for more verbose error messages
- check if we can connect to the FTB during component->query and close
the component, if we cannot.
- make the ftb component interface methods static.
- add mca parameters to set override the default subscription style and
priority.
This commit was SVN r22011.
2009-09-24 23:56:41 +00:00