1
1
Граф коммитов

2532 Коммитов

Автор SHA1 Сообщение Дата
Joshua Ladd
057370364d Opal: Add a new MCA variable type "version_string". Also add a
new flag to ompi_info that allows a user to print all MCA variables of a specific type.  

 --type version_string

This command will print all MCA variables of type version_string.

This feature was developed by Elena Shipunova and was reviewed by Josh Ladd.

This commit was SVN r32166.
2014-07-09 01:37:23 +00:00
Joshua Ladd
30da6d3a17 Opal: add a new MCA parameter that allows the user to specify a list of environment variables. This parameter will become the standard mechanism by which environment variables are set for OMPI applications replacing the -x option.
mpirun ... -x env_foo1=val1 -x env_foo2 -x env_foo3=val3  should now be expressed as

mpirun ... -mca mca_base_env_list env_foo1=val1+env_foo2+env_foo3=val3. 

The motivation for doing this is so that a list of environment variables may be set via standard MCA mechanisms such as mca parameter files, amca lists, etc. 

This feature was developed by Elena Shipunova and was reviewed by Josh Ladd.

This commit was SVN r32163.
2014-07-09 00:38:25 +00:00
Jeff Squyres
86f747c627 mca_base_var: use ERR_NOT_FOUND when var is inactive
After discussion with Nathan, change the ERR_VALUE_OUT_OF_BOUNDS to be
ERR_NOT_FOUND, for two reasons:

1. It's consistent with other uses of ERR_NOT_FOUND in the code.
1. In this case, we could have just looked up a variable that is
   basically a "hole" -- e.g., var indexes 0, 1, 2 are valid, and 4,
   5, and 5 are valid, but 3 is invalid (e.g., 3 was de-registered --
   remember that MPI_T explicitly does not allow re-using indexes).
   So returning ERR_OUT_OF_BOUNDS seems weird -- returning
   ERR_NOT_FOUND seems a bit more natural.

cmr=v1.8.2:ticket=trac:4587

This commit was SVN r32158.

The following Trac tickets were found above:
  Ticket 4587 --> https://svn.open-mpi.org/trac/ompi/ticket/4587
2014-07-08 20:00:18 +00:00
Ralph Castain
1d5f8297c8 In case someone wants to use the pstat framework, we need to have the usual open/close functions that were lost in the conversion to the new framework system
This commit was SVN r32150.
2014-07-07 13:53:29 +00:00
Ralph Castain
b85471ac13 Add support for "double" to the DSS
This commit was SVN r32149.
2014-07-07 13:51:58 +00:00
Ralph Castain
832fa4a028 Ensure that the progress thread tracker properly cleans up the blocking event, if set. Also, use the blocking event to help wake up the progress thread for quick shutdown as some threads can be blocked in a long-running call to select.
This commit was SVN r32141.
2014-07-04 14:55:51 +00:00
Ralph Castain
f6d4b4c11b As discussed at the OMPI developer's meeting, add functions to start, stop, and restart libevent-driven progress threads. Critical NOTE: if you don't have a file descriptor event defined for your progress thread, it will spin hard! Accordingly, the "start progress thread" function has a boolean parameter you can use to request that the function automatically create one for you.
This commit was SVN r32137.
2014-07-03 18:56:46 +00:00
Nathan Hjelm
563eaf0726 Fix support for Cray alps
The alps ras and plm components were broken by recent changes in ORTE. This
commit resolves those issues.

Changes:

 - Define PMI2_SUCCESS if it isn't defined. This fixes a problem with Cray's
   PMI implementation which does not define (for some reason) PMI2_SUCCESS. We
   had previously just used PMI_SUCCESS.

 - Add missing definition and a typo in pml_alps_module.

 - launch_id is no longer available in the orte_node_t structure. Use the
   attribute lookup to get the value.

 - Do not use an O(n^2) sorting algorithm when putting alps nodes in order. Use
   opal_list_sort instead (O(nlogn)).

This commit was SVN r32076.
2014-06-24 21:29:04 +00:00
Ralph Castain
20535bca19 Reorder the var release so a debugger can still see the var name that caused a segfault, thus helping to identify the var in question
cmr=v1.8.2:reviewer=hjelmn

This commit was SVN r32068.
2014-06-24 13:51:31 +00:00
Ralph Castain
2aade28259 Protect against NULL return from malloc
This commit was SVN r32056.
2014-06-19 20:57:56 +00:00
Ralph Castain
1a53d541ab Cleanup memory leak
cmr=v1.8.2:reviewer=hjelmn

This commit was SVN r32051.
2014-06-19 18:56:57 +00:00
Ralph Castain
b5a2ceaa7c Minor cleanup to node_stat packing routine
This commit was SVN r32049.
2014-06-19 18:46:27 +00:00
Ralph Castain
3f04d50cb0 Per the ticket, resolve our handling of overload conditions to provide a more consistent response. If we are overloaded (i.e., attempting to bind more processes to a location than the number of cpus under that location), then we consider the following conditions:
(a) default binding policy is in effect. In this case, we will emit a
warning and default to not binding unless the user provided the
"oversubscribe" or "overload" modifier to the "bind-to" option.

(b) user-specified binding policy is in effect. In this case, we will
error out unless the user provided the "oversubscribe" or "overload"
modifier to the "bind-to" option as we cannot meet the directive.

Either "bind-to" modifier (oversubscribe or overload) will be accepted for
now - in 1.9, we will deprecate the "overload" term in favor of
"oversubscribe".

Also added the ability to accept a --bind-to modifier without specifying the binding policy itself so a user can specify overload-allowed with the default policy.

Closes trac:4345

cmr=v1.8.2:reviewer=rhc:subject=resolve handling of overload conditions

This commit was SVN r32005.

The following Trac tickets were found above:
  Ticket 4345 --> https://svn.open-mpi.org/trac/ompi/ticket/4345
2014-06-14 15:38:32 +00:00
Ralph Castain
811f3d0665 Remove unused vars and actually test the indexed array member in the bitmap class
This commit was SVN r32004.
2014-06-14 03:18:24 +00:00
George Bosilca
13252206ad Correctly handle the case where we restrict the size to INT_MAX.
This commit was SVN r32003.
2014-06-13 21:32:46 +00:00
George Bosilca
fbe69808f2 A faster implementation of the OPAL_BITMAP. The corresponding
test has also been updated.

This commit was SVN r32001.
2014-06-13 21:15:35 +00:00
Ralph Castain
06dbfa3098 Make the cpus-per-proc equivalent a little more intuitive:
* allow users to specify just a modifier for map-by instead of requiring that they also specify a policy. Thus, we now accept --map-by :pe=3 as indicating that we should use the default mapping policy, but bind 3 cpus/proc.

* if users specify a pe's/proc but no policy, default to --map-by NUMA to ensure we have access to multiple cpus for the request. This won't guarantee we have access to enough to meet the request, but gives us a chance. In addition, we know that binding a proc to multiple cpus will work best if those cpus are all in the same NUMA, so this provides some degree of optimized behavior.

Per a request from Jeff, define "oversubscribe" for binding as a synonym for the "overload" modifier.

cmr=v1.8.2:reviewer=rhc

This commit was SVN r31967.
2014-06-08 20:26:59 +00:00
Ralph Castain
f197af530c Add print support for more of the opal_value_t values
This commit was SVN r31961.
2014-06-06 17:28:00 +00:00
Ralph Castain
ae5eec3e2f Minor tweaks to the pack/unpack routines
This commit was SVN r31954.
2014-06-05 14:49:37 +00:00
Ralph Castain
8736a1c138 Per RFC:
http://www.open-mpi.org/community/lists/devel/2014/05/14822.php

Revamp the ORTE global data structures to reduce memory footprint and add new features. Add ability to control/set cpu frequency, though this can only be done if the sys admin has setup the system to support it (or you run as root).

This commit was SVN r31916.
2014-06-01 16:14:10 +00:00
Ralph Castain
304fe06e1b Don't spew warnings if PMI_FD isn't present - it isn't an error.
This commit was SVN r31911.
2014-06-01 13:40:12 +00:00
Mike Dubman
e85e0e926d PMI: hotfix for PMI1 support
Based on thread: http://www.open-mpi.org/community/lists/devel/2014/06/index.php

This commit was SVN r31909.
2014-06-01 06:43:05 +00:00
Ralph Castain
1107f9099e Per the RFC issued here:
http://www.open-mpi.org/community/lists/devel/2014/05/14827.php

Refactor PMI support

This commit was SVN r31907.
2014-06-01 04:28:17 +00:00
George Bosilca
6290f6cc58 Correctly deal with partially converted datatypes both
during the unpack and during the positioning.

Fixes trac:4610.

This commit was SVN r31904.

The following Trac tickets were found above:
  Ticket 4610 --> https://svn.open-mpi.org/trac/ompi/ticket/4610
2014-05-29 21:53:44 +00:00
Ralph Castain
7480a680e3 Turns out that valgrind has issues with strings that don't fall on nice 4-byte alignments with some optimized builds. So make the default security credential a nice 7-characters (so we get 8-bytes with the NULL terminator) to make valgrind shut up.
Thanks to Walter Spector for reporting this.

cmr=v1.8.2:reviewer=jsquyres:subject=align the default sec credential

This commit was SVN r31873.
2014-05-22 00:36:25 +00:00
Jeff Squyres
e532ab3020 atomic_impl.h: fix trivial typos in comments
cmr=v1.8.2:ticket=trac:4664

This commit was SVN r31858.

The following Trac tickets were found above:
  Ticket 4664 --> https://svn.open-mpi.org/trac/ompi/ticket/4664
2014-05-21 17:18:18 +00:00
George Bosilca
7ca7b54718 Removes few unreacheable warnings. This is somehow related to the
ticket #2645.

cmr=v1.8.2:reviewer=jsquyres

This commit was SVN r31845.
2014-05-21 00:06:04 +00:00
Nathan Hjelm
1d1cef76df opal: fix leaks
Two leaks are fixed by this commit:

 - opal_dss.lookup_data_type returns an allocated string. Free it.

 - opal_ifaddrtokindex was leaking a struct addrinfo. Ensure that is
   released before returning.

cmr=v1.8.2:reviewer=rhc

This commit was SVN r31777.
2014-05-15 15:59:41 +00:00
Ralph Castain
7b4afe7efe Revert r31765 as it causes segfaults in all orte tools. We aren't getting all the events off of the event base in those tools prior to opal calling event_base_free, and that means there are stale memory references that libevent is trying to release.
Either we need to ensure that all events are deleted (which may prove difficult), or find another way to release the base memory.

This commit was SVN r31775.

The following SVN revision numbers were found above:
  r31765 --> open-mpi/ompi@75fb6dbba9
2014-05-15 14:02:16 +00:00
Nathan Hjelm
0ef6baffd3 Fix bug in r31764
Need to remove the items of the list to avoid an assert in debug builds.

cmr=v1.8.2:ticket=trac:4628

This commit was SVN r31769.

The following SVN revision numbers were found above:
  r31764 --> open-mpi/ompi@13fd6ae774

The following Trac tickets were found above:
  Ticket 4628 --> https://svn.open-mpi.org/trac/ompi/ticket/4628
2014-05-14 23:45:50 +00:00
Nathan Hjelm
75fb6dbba9 opal/event: release the opal event context when closing the event base
This fixes a series of leaks identified by valgrind. Since
opal_event_base_open was creating the event base it follows that
opal_event_base_close should release the event base.

cmr=v1.8.2:reviewer=rhc

This commit was SVN r31765.
2014-05-14 21:15:27 +00:00
Nathan Hjelm
13fd6ae774 opal_free_list: destruct free lists items when destructing the free
list

This commit updates the behavior of opal_free_list_t to match the
behavior of ompi_free_list_t. opal_free_list_t constructed items
placed on the free list but never destructed them.

cmr=v1.8.2:reviewer=jsquyres

This commit was SVN r31764.
2014-05-14 21:15:19 +00:00
Rolf vandeVaart
71998ad67b Change one argument to use const. Matches better how function is called.
This commit was SVN r31741.
2014-05-13 18:55:41 +00:00
Ralph Castain
5602156a1c Use the correct abstraction layer name for the data dirs
This commit was SVN r31684.
2014-05-08 14:32:24 +00:00
Jeff Squyres
81afb4e18a hwloc: commit minor bug fix from hwloc git
Bring down 3aa0ed6 from the hwloc v1.7 branch: Stevens says we should
GETFD before we SETFD, so we do

cmr=v1.8.2:reviewer=rhc

This commit was SVN r31683.
2014-05-08 14:29:10 +00:00
Ralph Castain
11faab1091 The final step of the RFC: convert the <foo>libdir and friends to fit their respective code areas, and equate them all at the top. Note that we can't entirely separate things as the opal_install_dirs framework can't handle separated locations for the various trees.
This commit was SVN r31679.
2014-05-08 02:01:35 +00:00
Ralph Castain
a8e2d6c3a6 The bulk of the remaining renaming changes, in one final glorious "blob". Thanks to Jeff for some help chasing down a few spots. Per chat with Jeff, we decided to cleanup a few things that were historical in nature:
top_ompi_srcdir  ->  OMPI_TOP_SRCDIR
top_ompi_builddir -> OMPI_TOP_BUILDDIR

We also split the srcdir/builddir flags according to their local tree (e.g., OPAL_TOP_SRCDIR), and tied them all together in configure.ac. Renamed ompi_ignore and ompi_unignore to be opal_<foo> as these are agnostic markers.

Only thing left is ompilibdir being treated similar to what we dif for srcdir/builddir. Coming soon.

This commit was SVN r31678.
2014-05-07 21:48:53 +00:00
Ralph Castain
74983c9002 Continue the renaming, fix ompi_show_subsubtitle
This commit was SVN r31674.
2014-05-07 15:45:47 +00:00
Ralph Castain
f4c31cae9b Per RFC, another round in the renaming game - nearly complete
This commit was SVN r31668.
2014-05-07 03:01:47 +00:00
Ralph Castain
a54dbb17d2 Per RFC, continue renaming project
This commit was SVN r31667.
2014-05-07 01:00:06 +00:00
Ralph Castain
2b7a3ae601 Per RFC, continue pecking away at the build system renaming
OMPI_CONFIG_SUBDIR  -> OPAL_CONFIG_SUBDIR
   OMPI_CONFIG_SUBDIR_ARGS  ->  OPAL_CONFIG_SUBDIR_ARGS

This commit was SVN r31647.
2014-05-06 16:27:38 +00:00
Ralph Castain
390d29733f Per RFC, continue renaming of build tools:
ompi_c_vendor  ->  opal_c_vendor
ompi_cv_c_compiler_vendor  ->  opal_cv_c_compiler_vendor

This commit was SVN r31646.
2014-05-06 15:01:34 +00:00
Ralph Castain
a1ae20fddb Per RFC: OMPI_CFLAGS_BEFORE_PICKY -> OPAL_CFLAGS_BEFORE_PICKY
- This line, and those below, will be ignored--

M    opal/mca/event/libevent2021/configure.m4
M    opal/mca/hwloc/hwloc172/configure.m4
M    configure.ac
M    config/opal_setup_libltdl.m4
M    config/opal_check_visibility.m4
M    config/opal_setup_cc.m4

This commit was SVN r31637.
2014-05-05 22:22:33 +00:00
George Bosilca
8a8218349a Datatype with count of zero do not generate traffic in the type map, nor
have any impact on the type signature.

Fixes trac:4597.
cmr=v1.8.2:reviewer=ompi-rm1.8

This commit was SVN r31635.

The following Trac tickets were found above:
  Ticket 4597 --> https://svn.open-mpi.org/trac/ompi/ticket/4597
2014-05-05 21:49:18 +00:00
Ralph Castain
4def94900a Per RFC: OMPI_INSTALL_BINARIES -> OPAL_INSTALL_BINARIES
This commit was SVN r31634.
2014-05-05 21:43:05 +00:00
Ralph Castain
f9d892b7a4 As Nathan pointed out, C99 reserves all _foo identifiers, so rename _WORD_MASK as OPAL_CRC_WORD_MASK
This commit was SVN r31615.
2014-05-02 17:21:28 +00:00
Ralph Castain
87b6c1cf99 Add some protection to ensure that dstore doesn't segfault if uninitialized
This commit was SVN r31606.
2014-05-02 16:39:45 +00:00
Ralph Castain
e20dae536c Last step under current RFC: OMPI_CHECK_WITHDIR -> OPAL_CHECK_WITHDIR
This commit was SVN r31585.
2014-05-01 15:38:07 +00:00
Ralph Castain
e11eb15518 Next step of RFC: OMPI_CHECK_FUNC_LIB -> OPAL_CHECK_FUNC_LIB
This commit was SVN r31583.
2014-05-01 14:57:43 +00:00
Ralph Castain
3b64c603b4 First stage of RFC to rename OMPI_foo build system support: change OMPI_CHECK_PACKAGE -> OPAL_CHECK_PACKAGE
This commit was SVN r31582.
2014-05-01 14:24:56 +00:00