1
1

hwloc: commit minor bug fix from hwloc git

Bring down 3aa0ed6 from the hwloc v1.7 branch: Stevens says we should
GETFD before we SETFD, so we do

cmr=v1.8.2:reviewer=rhc

This commit was SVN r31683.
Этот коммит содержится в:
Jeff Squyres 2014-05-08 14:29:10 +00:00
родитель cb292b91cd
Коммит 81afb4e18a
2 изменённых файлов: 7 добавлений и 3 удалений

Просмотреть файл

@ -8,3 +8,4 @@ Applied this from the upstream hwloc master, slightly modified for this
local version of v1.7 that we have:
7489287 topology-linux.c: ensure fd is marked as close-on-exec
3aa0ed6 topology-linux.c: Stevens says we should GETFD before we SETFD, so we do

Просмотреть файл

@ -4297,7 +4297,7 @@ hwloc_linux_component_instantiate(struct hwloc_disc_component *component,
struct hwloc_backend *backend;
struct hwloc_linux_backend_data_s *data;
const char * fsroot_path = _data1;
int root = -1;
int flags, root = -1;
backend = hwloc_backend_alloc(component);
if (!backend)
@ -4324,8 +4324,11 @@ hwloc_linux_component_instantiate(struct hwloc_disc_component *component,
goto out_with_data;
/* Since this fd stays open after hwloc returns, mark it as
close-on-exec so that children don't inherit it */
if (fcntl(root, F_SETFD, FD_CLOEXEC) == -1) {
close-on-exec so that children don't inherit it. Stevens says
that we should GETFD before we SETFD, so we do. */
flags = fcntl(root, F_GETFD, 0);
if (-1 == flags ||
-1 == fcntl(root, F_SETFD, FD_CLOEXEC | flags)) {
close(root);
root = -1;
goto out_with_data;