orte_snapc_base_select() wants to know if it is an application

The function

   int orte_snapc_base_select(bool seed, bool app);

wants to know if it called by an application or not. Therefore
it expects as second paremeter 'bool app'. It used to be
'!ORTE_PROC_IS_DAEMON' which is not always correct if it is
a tool or a HNP. This patch changes it to ORTE_PROC_IS_APP, which
has the correct information if it is an application.

This commit was SVN r30404.

orte/mca/ess/base/ess_base_std_app.c

@@ -252,7 +252,7 @@ int orte_ess_base_app_setup(bool db_restrict_local)
         error = "orte_sstore_base_open";
         goto error;
     }
-    if (ORTE_SUCCESS != (ret = orte_snapc_base_select(ORTE_PROC_IS_HNP, !ORTE_PROC_IS_DAEMON))) {
+    if (ORTE_SUCCESS != (ret = orte_snapc_base_select(ORTE_PROC_IS_HNP, ORTE_PROC_IS_APP))) {
         ORTE_ERROR_LOG(ret);
         error = "orte_snapc_base_select";
         goto error;

orte/mca/ess/base/ess_base_std_tool.c

@@ -175,7 +175,7 @@ int orte_ess_base_tool_setup(void)
         error = "orte_snapc_base_open";
         goto error;
     }
-    if (ORTE_SUCCESS != (ret = orte_snapc_base_select(ORTE_PROC_IS_HNP, !ORTE_PROC_IS_DAEMON))) {
+    if (ORTE_SUCCESS != (ret = orte_snapc_base_select(ORTE_PROC_IS_HNP, ORTE_PROC_IS_APP))) {
         ORTE_ERROR_LOG(ret);
         error = "orte_snapc_base_select";
         goto error;

orte/mca/ess/hnp/ess_hnp_module.c

@@ -678,7 +678,7 @@ static int rte_init(void)
         error = "orte_sstore_base_open";
         goto error;
     }
-    if (ORTE_SUCCESS != (ret = orte_snapc_base_select(ORTE_PROC_IS_HNP, !ORTE_PROC_IS_DAEMON))) {
+    if (ORTE_SUCCESS != (ret = orte_snapc_base_select(ORTE_PROC_IS_HNP, ORTE_PROC_IS_APP))) {
         ORTE_ERROR_LOG(ret);
         error = "orte_snapc_base_select";
         goto error;