Roland Illig
c64cec997a
* vfs.c (mc_chdir): Fixed memory leak.
2004-08-26 00:17:36 +00:00
Andrew V. Samoilov
201c30624e
* vfs/extfs/a.in: Quote parameters to calls to system/open that spawn a shell.
...
* vfs/extfs/apt.in: Likewise.
* vfs/extfs/debd.in: Likewise.
* vfs/extfs/dpkg.in: Likewise.
* vfs/extfs/deba.in: Clean up earlier fixes to quotation of parameters.
* vfs/extfs/deb.in: Likewise.
2004-08-24 19:51:41 +00:00
Andrew V. Samoilov
acc5f18cfa
Change e-mail for Leonard den Ottolander
2004-08-24 19:27:01 +00:00
Roland Illig
83c07852e9
* extfs.c (extfs_internal_stat): Fixed memory leaks introduced
...
by my change from 2004-08-16. (extfs_unlink): likewise.
* ftpfs.c (ftpfs_send_command): likewise.
2004-08-24 15:56:24 +00:00
Roland Illig
6bd2914cc1
Added missing ChangeLog entries from 2004-08-16.
2004-08-24 14:01:12 +00:00
Andrew V. Samoilov
76a8893a53
* extfs/urar.in: Fix non-POSIX constructs.
2004-08-22 22:47:15 +00:00
Andrew V. Samoilov
dbedd885e6
* extfs/rpm: Modified workaround for spaces and single quotes in the path name.
2004-08-22 22:38:49 +00:00
Andrew V. Samoilov
8a410cf065
* extfs/rpm: Don't show cpio contents in main rpm view.
...
Also avoids copying files from main view instead of from
inside CONTENTS.cpio. The former is painfully slow as the whole
file is rpm2cpio'd on each copy.
2004-08-22 21:43:18 +00:00
Andrew V. Samoilov
b2706a92c6
Anti-spam protection e-mail address for Leonard den Ottolander
2004-08-22 12:02:14 +00:00
Andrew V. Samoilov
6478efd184
* samba/lib/util.c (tmpdir): Use MC_TMPDIR environment variable.
...
(automount_lookup): More secure code.
2004-08-20 21:05:02 +00:00
Roland Illig
a37fdaca96
* extfs/deb.in (mcdebfs_list): Separated the use of quoted and unquoted variables. (mcdebfs_copyout): likewise. (mcdebfs_run): likewise. From Leonard den Ottolander <leonard@den.ottolander.nl>
2004-08-19 17:37:01 +00:00
Roland Illig
2c4ca680bb
* extfs/deba.in (list): Separated the use of quoted and unquoted variables. (copyout): likewise. (run): likewise. From Leonard den Ottolander <leonard@den.ottolander.nl>
2004-08-19 17:32:31 +00:00
Roland Illig
060898b092
* extfs/deba.in (bt): deleted. (ft): deleted. (fm): deleted. (ls): deleted. (list): correctly quoted shell command arguments. (copyout): likewise. (run): likewise. From Leonard den Ottolander <leonard@den.ottolander.nl>
2004-08-19 15:53:13 +00:00
Roland Illig
c42b447115
Using elsif instead of more expensive if.
2004-08-19 15:43:09 +00:00
Roland Illig
388442cf0c
smbfs.c: Modified smbfs_convert_path based on a patch sent by Andrew V. Samoilov. Adjusted the calls to smbfs_convert_path. Simplified string handling by using free_after from src/util.h. Fixed one memory leak and one accidental modification.
2004-08-19 12:05:54 +00:00
Andrew V. Samoilov
b328811d2a
* extfs/rpm: Command line parameters fix for UPGRADE.
...
Fix mcrpmfs_copyout for INFO/OBSOLETES and INFO/LICENSE
From Leonard den Ottolander <leonard@den.ottolander.nl>
2004-08-18 21:18:07 +00:00
Roland Illig
cdc35124d3
Only use this file if USE_VFS is defined.
2004-08-17 13:00:58 +00:00
Roland Illig
8a0b96bd27
Made name and prefix of vfs_class constant.
2004-08-17 11:19:31 +00:00
Roland Illig
94d1dea0b9
Added more const-ness. Avoided name collisions by shadowing.
2004-08-17 11:18:47 +00:00
Roland Illig
cf1c61cd2a
Added more const-ness. Avoided name collision for netrc.
2004-08-17 11:17:02 +00:00
Roland Illig
c0a173bf7b
Added more const-ness.
2004-08-17 11:14:51 +00:00
Roland Illig
f608bd21f8
Renamed any variable stat into st.
2004-08-17 11:13:55 +00:00
Roland Illig
5689ee5699
Added more const-ness to variables.
2004-08-17 10:26:44 +00:00
Roland Illig
370b29d6f6
Removed duplicate declaration of vfs_file_is_local.
2004-08-17 10:19:44 +00:00
Roland Illig
5a345d5e4d
Const-ified the vfs_find[ug]id functions.
2004-08-17 09:48:15 +00:00
Roland Illig
acd63d7374
Moved the declaration of the init_*fs functions into specialized headers (*fs.h or vfs-impl.h).
2004-08-17 09:17:43 +00:00
Andrew V. Samoilov
b93ffeaa80
Security fix patch. Fix insecure temporary file and directory creations. (CAN-2004-0231).
2004-08-17 08:24:59 +00:00
Roland Illig
a640e5a8e7
Proper handling of getopt.h and PAM.
2004-08-17 00:48:53 +00:00
Roland Illig
8a2b1f0c31
Added vfs-impl.h to the list of headers.
2004-08-17 00:48:28 +00:00
Roland Illig
1105b8e941
Splittet the vfs.h header into a user's part (vfs.h) and an implementor's part (vfs-impl.h).
2004-08-16 23:25:49 +00:00
Roland Illig
34a8088483
Splittet the vfs.h header into a user's part (vfs.h) and an implementor's part (vfs-impl.h).
2004-08-16 23:18:42 +00:00
Roland Illig
3cf53917e1
Const-ified the mc_* functions.
2004-08-16 22:40:31 +00:00
Roland Illig
b17b1ac213
Const-ified the rest of the vfs_class methods.
2004-08-16 22:15:28 +00:00
Roland Illig
e0bf99d516
Made the path argument to vfs->{chmod,chown,utime} constant.
2004-08-16 21:36:39 +00:00
Roland Illig
dc70d154db
Made the buf argument to vfs->write constant.
2004-08-16 21:16:54 +00:00
Roland Illig
789e5e9bcb
Made the path argument to vfs->[l]stat constant. Created a new memory leak, which will be fixed soon.
2004-08-16 20:26:42 +00:00
Roland Illig
b472c18c79
Made the patch argument to vfs->which const.
2004-08-16 19:47:21 +00:00
Roland Illig
a50890b1a4
Added missing function prototypes. Added const-ness. Fixed an "empty-then-clause" bug.
2004-08-16 16:59:43 +00:00
Roland Illig
c5694db1ad
Replaced "-1" by INADDR_NONE.
2004-08-16 16:58:18 +00:00
Roland Illig
1a62b0a598
Added explicit type casting and replaced "-1" by INADDR_NONE.
2004-08-16 16:58:00 +00:00
Roland Illig
db3f21b702
Added a typedef for a function. Added more const-ness to the function arguments.
2004-08-16 16:34:11 +00:00
Roland Illig
8aeea3256f
Added more const-ness to the function arguments.
2004-08-16 15:45:05 +00:00
Roland Illig
a0616a76be
mc_ungetlocalcopy does not free its second argument anymore.
2004-08-16 15:18:18 +00:00
Roland Illig
f17c1f291c
mc_ungetlocalcopy does not free its second argument anymore.
2004-08-16 15:18:17 +00:00
Roland Illig
8e36bb7fe0
Marked the places where the arguments should be passed as "const".
2004-08-16 09:37:00 +00:00
Roland Illig
6d483846cb
Added a type cast to avoid GCC warnings.
2004-08-16 04:27:25 +00:00
Roland Illig
a998d33f7c
Made the implicit conversions explicit to prevent "hidden" bugs.
2004-08-16 04:26:46 +00:00
Andrew V. Samoilov
e9be8219a0
* sfs.c (sfs_init): Fix possible buffer overflows for invalid sfs.ini.
2004-08-14 10:56:09 +00:00
Andrew V. Samoilov
5b290ada65
* extfs.c (extfs_init): Fix possible off-by-one buffer underflow
...
for empty lines in extfs.ini.
2004-08-14 10:51:00 +00:00
Andrew V. Samoilov
622e6a368e
Fix missed name_status() function name.
2004-08-09 14:09:52 +00:00
Pavel Roskin
8ab694ba2d
* tar.c: Eliminate struct hstat, use stack arguments instead.
2004-06-14 16:04:07 +00:00
Andrew V. Samoilov
4208406d7d
* undelfs.c (undelfs_readdir): Eliminate g_snprintf()
2004-03-07 06:52:25 +00:00
Andrew V. Samoilov
ae73b0a065
* configure.ac: Remove AC_STRUCT_ST_RDEV and AC_CHECK_FUNCS (strpbrk).
2004-03-07 06:45:31 +00:00
Andrew V. Samoilov
b55db9788b
* samba/lib/debug.c (Debug1): Don't try to open/create logfile if debugf is empty string.
2004-03-07 06:40:28 +00:00
Andrew V. Samoilov
722f4e684a
* utilvfs.c (vfs_parse_ls_lga): Handle device without whitespace(s)
...
between major and minor.
2004-03-07 06:17:12 +00:00
Andrew V. Samoilov
02db8a9660
* direntry.c (vfs_s_resolve_symlink): Check vfs_s_fullpath()
...
return value to avoid NULL dereference.
Reported by wwp <subscript@free.fr>.
2004-03-07 06:12:49 +00:00
Andrew V. Samoilov
2f7bbc2c31
* vfs.c (mc_def_ungetlocalcopy): Fix missed "%s".
...
* utilvfs.c (vfs_parse_ls_lga): Likewise.
2004-03-07 06:07:43 +00:00
Pavel Roskin
05e6a61834
* smbfs.c (smbfs_reconnect): Revert changes in a translated
...
message.
2004-01-28 00:01:30 +00:00
Pavel Roskin
79b4c398de
* extfs/rpm: Workaround for spaces and single quotes in the path
...
name.
2004-01-24 00:48:46 +00:00
Pavel Roskin
47225c2ff3
Typo fix.
...
From Andrew V. Samoilov <andrew@email.zp.ua>
2004-01-24 00:28:13 +00:00
Pavel Roskin
a8261b28d6
* mcserv.c: Use HAVE_CRYPT instead of USE_CRYPT. Remove
...
references to HAVE_LIBCRYPT and HAVE_LIBCRYPT_I. Reported by
Christian Laubscher <christian.laubscher@tiscalinet.ch>
2004-01-22 08:44:20 +00:00
Pavel Roskin
8db3838b57
* samba/configure.in: Rename to ...
...
* samba/configure.ac: ... this. Adjust dependencies.
2004-01-22 06:30:30 +00:00
Pavel Roskin
fe12438ed6
* fish.c (fish_open_archive_int): Save some stack and place -C
...
flag before host.
2003-12-06 04:24:56 +00:00
Pavel Roskin
c83ab1c1b2
Trivial patches from Andrew V. Samoilov <andrew@email.zp.ua>
2003-12-06 04:05:35 +00:00
Pavel Roskin
e9827066d1
* undelfs.c: Use ext2fs/ext2_fs.h instead of linux/ext2_fs.h
...
when possible.
2003-11-28 06:20:57 +00:00
Pavel Roskin
fc9bf6040f
* gc.c (vfs_ncs_getid): Merge with vfs_getid().
2003-11-26 21:25:30 +00:00
Pavel Roskin
6ffd35bf07
* gc.c: Eliminate all code for timestamping parent filesystems.
...
It's broken and undocumented. Adjust all dependencies.
2003-11-26 21:10:42 +00:00
Pavel Roskin
8ed2cc4594
* direntry.c (vfs_s_resolve_symlink): Eliminate
...
g_strdup_printf().
(vfs_s_fullpath): Likewise.
2003-11-24 20:30:30 +00:00
Pavel Roskin
ffb686bfa9
* ftpfs.c (ftpfs_login_server): Explicit password should have
...
priority over the netrc password and the anonymous password.
Reported by Jindrich Makovicka <makovick@kmlinux.fjfi.cvut.cz>
2003-11-21 06:57:37 +00:00
Pavel Roskin
a128188ae1
Warning fixes for FreeBSD 5.1.
2003-11-21 03:17:18 +00:00
Pavel Roskin
1b2a6186ae
va_list argument should be first for portability.
2003-11-20 19:08:36 +00:00
Pavel Roskin
3ba446981a
Typo fix.
2003-11-20 18:40:11 +00:00
Pavel Roskin
2eeab44b93
* undelfs.c (undelfs_loaddel): Use g_try_malloc()/g_try_relloc()
...
since we want to recover and not abort the program if we don't
have enough memory.
(com_err): Fix implementation.
2003-11-14 21:36:35 +00:00
Pavel Roskin
8147825da3
Typo fixes from Andrew.
2003-11-14 16:55:35 +00:00
Pavel Roskin
54b8c9aaad
* vfs.c (vfs_split): Deconstify.
...
* direntry.c (vfs_s_get_path_mangle): Likewise. "mangle" is in
the name for a reason. Use vfs_s_get_path() instead where the
path should be preserved.
* extfs.c (extfs_get_path_mangle): Likewise.
* sfs.c (sfs_vfmake): Protect against changes in vfs_split().
2003-11-14 08:25:50 +00:00
Pavel Roskin
6a53060842
Constify opendir() and chdir().
2003-11-13 16:47:06 +00:00
Pavel Roskin
30c4bd1b6d
* vfs.h: Constify chdir() and opendir() methods. Adjust all
...
dependencies.
* vfs.c (mc_chdir): Constify, eliminate protection against
broken implementations of chdir() method.
(mc_opendir): Constify.
2003-11-13 08:29:37 +00:00
Pavel Roskin
4b5a2a0b62
* direntry.c (vfs_s_stamp_me): Generalize and move ...
...
* gc.c (vfs_stamp_create): ... here. Use whenever possible.
2003-11-13 08:03:03 +00:00
Pavel Roskin
de12104436
* gc.c: Use NULL instead of -1 for empty vfsid. Adjust all
...
dependencies.
* undelfs.c (undelfs_get_path): Don't shadow static ext2_fname.
(undelfs_getid): Likewise. Use fs for non-empty vfsid.
2003-11-12 23:00:16 +00:00
Pavel Roskin
d2e2f5c544
* cpio.c (cpio_create_entry): Fix possible buffer underflow
...
and memory leak.
2003-11-12 17:10:48 +00:00
Pavel Roskin
4eab382dba
* gc.c: Make getid(), nothingisopen() and free() methods
...
optional. Eliminate trivial implementations.
(vfs_getid): New function - safe wrapper around getid(). Use
it everywhere.
(vfs_ncs_getid): Remove dead code, inprove readability.
2003-11-08 23:53:00 +00:00
Pavel Roskin
b33f2cbb47
* vfs.c: Split garbage collection code into ...
...
* gc.c: ... this.
* vfs.h: Corresponding code moved ...
* gc.h: ... here.
* Makefile.am: Adjustments for the above.
2003-11-07 23:43:55 +00:00
Pavel Roskin
7633c40204
Remove redundant declaration of vfs_translate_url().
2003-11-07 23:29:25 +00:00
Pavel Roskin
106a90ae99
* vfs.c: Eliminate MC_OP. Reorder other MC_* macros for
...
readability.
2003-11-05 06:34:20 +00:00
Pavel Roskin
0318ed5d0b
* vfs.c: Move all parsing code, vfs_die() and vfs_get_password()
...
to utilvfs.c, vfs_print_stats() to direntry.c.
* utilvfs.c (vfs_parse_ls_lga): Disable caching current date,
it's done incorrectly.
2003-11-05 06:08:16 +00:00
Pavel Roskin
0a9c708bec
Fixes for bad strings:
...
"In this cases"
"~/.netrc file has not correct mode"
Reported by Arpad Biro <biro_arpad@yahoo.com>
2003-11-05 00:33:34 +00:00
Pavel Roskin
c468c1b6e9
* vfs.c: Allocate handles dynamically.
...
(get_bucket): Rewrite as vfs_new_handle().
(vfs_op): Make a function.
(vfs_info): Likewise.
(vfs_free_bucket): Replace with vfs_free_handle().
(mc_readdir): Expand, eliminate MC_DIROP.
2003-11-05 00:12:25 +00:00
Pavel Roskin
f613c51eb5
* HACKING: New file - technical documentation for VFS.
...
* Makefile.am: Distribute it.
2003-10-30 06:00:41 +00:00
Pavel Roskin
24dd87b714
* vfs.c (vfs_rmstamp): Rescan the tree after the parents have
...
been removed. Otherwise using old data causes data corruption
in some combinations (e.g. extfs inside tatfs).
2003-10-30 05:58:06 +00:00
Pavel Roskin
6f9f431ae6
Initial version of technical documentation for VFS.
2003-10-30 05:52:35 +00:00
Pavel Roskin
cb2aaf4c16
* extfs.c: Remove current_dir field, its role was purely
...
decorative. Rename names starting with underscore.
2003-10-29 23:16:31 +00:00
Pavel Roskin
f2550b08ee
* extfs.h: Merge ...
...
* extfs.c: ... here.
* Makefile.am: Remove extfs.h.
2003-10-29 23:05:27 +00:00
Pavel Roskin
0ba019a90b
* configure.in: Use AC_CHECK_MEMBERS to check fields of struct
...
stat. Adjust all dependencies.
2003-10-29 17:36:16 +00:00
Pavel Roskin
cea13079c3
* ftpfs.c: Use HAVE_STRUCT_LINGER_L_LINGER instead of
...
HAVE_STRUCT_LINGER.
2003-10-29 17:23:35 +00:00
Pavel Roskin
6b4f397f5b
* Makefile.am: Compile utilvfs.c even without USE_VFS_NET.
...
* utilvfs.c (vfs_split_url): Only compile with USE_NETCODE
defined.
2003-10-29 07:19:25 +00:00
Pavel Roskin
cd644b527c
* fish.c (fish_fh_open): Use vfs_mkstemps() for write buffers as
...
well, since the file can be reopened for reading later.
* ftpfs.c (ftpfs_fh_open): Likewise.
2003-10-29 01:35:36 +00:00
Pavel Roskin
edce41facd
* utilvfs.c (vfs_mkstemps): New function - create temporary file
...
with the name resembling the original, but safe for scripts.
* direntry.c (vfs_s_open): Use it.
(vfs_s_retrieve_file): Likewise.
* extfs.c (extfs_open): Likewise.
* sfs.c (sfs_redirect): Likewise.
2003-10-29 00:50:36 +00:00
Pavel Roskin
77bcdc8127
* vfs.c (mc_ungetlocalcopy): Free local path here, not in class
...
implementations.
* vfs.h (struct vfs_s_class): Constify "local" argument for
ungetlocalcopy. Adjust all implementations.
2003-10-28 21:52:06 +00:00
Pavel Roskin
bb184c9c8b
Typo in the last commit.
2003-10-28 08:47:04 +00:00
Pavel Roskin
67cd859ea3
* direntry.c (vfs_s_init_class): Use our getlocalcopy for remote
...
filesystems that cache files, not for archives.
(vfs_s_getlocalcopy): Corresponding changes.
2003-10-28 08:20:30 +00:00