1
1
Nathan Hjelm f5389cbb03 opal/keyval: fix coverity issues
CID 1292738 Dereference after null check (FORWARD_NULL)

It is an error if NULL is passed for val in add_to_env_str. Removed
the NULL-check @ keyval_parse.c:253 and added a NULL check and an
error return.

CID 1292737 Logically dead code (DEADCODE)

Coverity is correct, the error code at the end of parse_line_new is
never reached. This means we fail to report parsing errors when
parsing -x and -mca lines in keyval files. I moved the error code into
the loop and removed the checks @ keyval_parse.c:314.

I also named the parse state enum type and updated parse_line_new to
use this type.

Signed-off-by: Nathan Hjelm <hjelmn@lanl.gov>
2015-05-28 08:38:09 -06:00
..
2015-05-28 08:38:09 -06:00
2014-02-24 23:18:35 +00:00
2015-03-10 14:37:53 +09:00
2009-08-20 11:42:18 +00:00
2009-08-20 11:42:18 +00:00
2015-05-08 09:48:51 +09:00
2009-08-20 11:42:18 +00:00
2015-02-12 13:41:29 -08:00
2009-08-20 11:42:18 +00:00
2015-05-08 09:48:51 +09:00
2011-11-29 20:39:53 +00:00
2014-12-13 08:09:34 -05:00
2009-08-20 11:42:18 +00:00
2009-08-20 11:42:18 +00:00
2015-02-27 19:19:46 +09:00