CID 1292738 Dereference after null check (FORWARD_NULL)
It is an error if NULL is passed for val in add_to_env_str. Removed
the NULL-check @ keyval_parse.c:253 and added a NULL check and an
error return.
CID 1292737 Logically dead code (DEADCODE)
Coverity is correct, the error code at the end of parse_line_new is
never reached. This means we fail to report parsing errors when
parsing -x and -mca lines in keyval files. I moved the error code into
the loop and removed the checks @ keyval_parse.c:314.
I also named the parse state enum type and updated parse_line_new to
use this type.
Signed-off-by: Nathan Hjelm <hjelmn@lanl.gov>