3e2031e0e3
development trees since last year (had to wait for some intel tests to run yesterday, so I finally took the time to finish this work): * Improve MPI API argument checking by also checking for NULL values (especially helps when invalid Fortran MPI handles are passed, because the various MPI_*f2c functions are supposed to return an "invalid" MPI handle [meaning NULL] when this happens). So now OMPI will generate an MPI exception rather than a segv. * Removed a few redundant DATATYPE_NULL checks. * Also check for some other forms of "invalid" handles (e.g., already been freed, etc.) in some cases. We could probably be a bit more stringent in this regard if we really wanted to. * Change MPI_Get_processor_name to zero out the string up to MPI_MAX_PROCESSOR_NAME characters, because the MPI spec says that the string must be at least that long. We were already passing that length to gethostname(), anyway. This commit was SVN r14100.
114 строки
3.8 KiB
C
114 строки
3.8 KiB
C
/*
|
|
* Copyright (c) 2004-2007 The Trustees of Indiana University and Indiana
|
|
* University Research and Technology
|
|
* Corporation. All rights reserved.
|
|
* Copyright (c) 2004-2005 The University of Tennessee and The University
|
|
* of Tennessee Research Foundation. All rights
|
|
* reserved.
|
|
* Copyright (c) 2004-2005 High Performance Computing Center Stuttgart,
|
|
* University of Stuttgart. All rights reserved.
|
|
* Copyright (c) 2004-2005 The Regents of the University of California.
|
|
* All rights reserved.
|
|
* Copyright (c) 2007 Cisco, Inc. All rights reserved.
|
|
* $COPYRIGHT$
|
|
*
|
|
* Additional copyrights may follow
|
|
*
|
|
* $HEADER$
|
|
*/
|
|
#include "ompi_config.h"
|
|
#include <stdio.h>
|
|
|
|
#include "ompi/mpi/c/bindings.h"
|
|
#include "ompi/mca/topo/topo.h"
|
|
#include "ompi/mca/topo/base/base.h"
|
|
|
|
#if OMPI_HAVE_WEAK_SYMBOLS && OMPI_PROFILING_DEFINES
|
|
#pragma weak MPI_Graph_create = PMPI_Graph_create
|
|
#endif
|
|
|
|
#if OMPI_PROFILING_DEFINES
|
|
#include "ompi/mpi/c/profile/defines.h"
|
|
#endif
|
|
|
|
static const char FUNC_NAME[] = "MPI_Graph_create";
|
|
|
|
|
|
int MPI_Graph_create(MPI_Comm old_comm, int nnodes, int *index,
|
|
int *edges, int reorder, MPI_Comm *comm_graph)
|
|
{
|
|
|
|
int err;
|
|
bool re_order = false;
|
|
|
|
OPAL_CR_TEST_CHECKPOINT_READY();
|
|
|
|
/* check the arguments */
|
|
if (MPI_PARAM_CHECK) {
|
|
OMPI_ERR_INIT_FINALIZE(FUNC_NAME);
|
|
if (ompi_comm_invalid(old_comm)) {
|
|
return OMPI_ERRHANDLER_INVOKE (MPI_COMM_WORLD, MPI_ERR_COMM,
|
|
FUNC_NAME);
|
|
}
|
|
if (OMPI_COMM_IS_INTER(old_comm)) {
|
|
return OMPI_ERRHANDLER_INVOKE (old_comm, MPI_ERR_COMM,
|
|
FUNC_NAME);
|
|
}
|
|
if ( (1 > nnodes) || (NULL == index) || (NULL == edges) ) {
|
|
return OMPI_ERRHANDLER_INVOKE (old_comm, MPI_ERR_ARG,
|
|
FUNC_NAME);
|
|
}
|
|
|
|
if (nnodes > ompi_comm_size(old_comm)) {
|
|
return OMPI_ERRHANDLER_INVOKE (old_comm, MPI_ERR_ARG,
|
|
FUNC_NAME);
|
|
}
|
|
|
|
if ((0 > reorder) || (1 < reorder)) {
|
|
return OMPI_ERRHANDLER_INVOKE (old_comm, MPI_ERR_ARG,
|
|
FUNC_NAME);
|
|
}
|
|
}
|
|
|
|
/*
|
|
* Now we have to check if the topo module exists or not. This has been
|
|
* removed from initialization since most of the MPI calls do not use
|
|
* this module
|
|
*/
|
|
if (!(mca_topo_base_components_opened_valid ||
|
|
mca_topo_base_components_available_valid)) {
|
|
if (OMPI_SUCCESS != (err = mca_topo_base_open())) {
|
|
return OMPI_ERRHANDLER_INVOKE(old_comm, err, FUNC_NAME);
|
|
}
|
|
if (OMPI_SUCCESS !=
|
|
(err = mca_topo_base_find_available(OMPI_ENABLE_PROGRESS_THREADS,
|
|
OMPI_ENABLE_MPI_THREADS))) {
|
|
return OMPI_ERRHANDLER_INVOKE(old_comm, err, FUNC_NAME);
|
|
}
|
|
}
|
|
|
|
/*
|
|
* everything seems to be alright with the communicator, we can go
|
|
* ahead and select a topology module for this purpose and create
|
|
* the new graph communicator
|
|
*/
|
|
|
|
re_order = (1 == reorder) ? true:false;
|
|
|
|
err = ompi_topo_create ((struct ompi_communicator_t *)old_comm,
|
|
nnodes,
|
|
index,
|
|
edges,
|
|
re_order,
|
|
(struct ompi_communicator_t **)comm_graph,
|
|
OMPI_COMM_GRAPH);
|
|
|
|
/* check the error status */
|
|
if (MPI_SUCCESS != err) {
|
|
return OMPI_ERRHANDLER_INVOKE(old_comm, err, FUNC_NAME);
|
|
}
|
|
|
|
/* All done */
|
|
return MPI_SUCCESS;
|
|
}
|