1
1
openmpi/test/class
Ralph Castain 7306b9d7b9 Fix the registry search routine to remove a buffer that wasn't expanding as it should - cause of recent problems observed when spawning larger numbers of processes.
For anyone interested, the problem stemmed from two things:

1. a bug in the ompi_bitmap utility (which I copied to orte_bitmap to avoid unintentionally disturbing something else) that causes the bitmap NOT to expand unless the caller asks for a bit that is more than one byte outside the current array size. The unit test didn't pick it up because it doesn't check that close to the boundary.

2. a "feature" in the ompi_bitmap utility that only expands the array if you try to SET a bit outside the current boundary, but NOT if you try to CLEAR a bit outside the array limit. This appears intentional as the unit test checks for this behavior, but I hadn't been expecting the asymmetry.

The orte_bitmap utility now appropriately expands in both circumstances. I also added a function to expand the array so it "covers" a bit location without setting or clearing it. The function allows you to ensure the array is big enough to handle the specified bit, but leave the bit alone if it already is there (the other functions would set/clear it if it was).

I've tested it with up to 100 processes without problem.

This commit was SVN r5980.
2005-06-08 15:48:38 +00:00
..
Makefile.am Fix the registry search routine to remove a buffer that wasn't expanding as it should - cause of recent problems observed when spawning larger numbers of processes. 2005-06-08 15:48:38 +00:00
ompi_bitmap.c Remove compiler warning 2005-04-05 19:54:56 +00:00
ompi_circular_buffer_fifo.c changed function signitures to match the changes in mpool 2005-06-01 15:25:17 +00:00
ompi_fifo.c changed function signitures to match the changes in mpool 2005-06-01 15:25:17 +00:00
ompi_hash_table.c Make this test compile again 2005-04-05 20:40:22 +00:00
ompi_list.c Don't test for a bad condition 2005-04-13 21:25:25 +00:00
ompi_pointer_array.c 32/64 fixes (ensure that our classes really at 64 bit clean -- and 2005-04-05 20:34:56 +00:00
ompi_rb_tree.c - Added functionality to MPI_Alloc_mem and MPI_Free_mem so that they 2005-05-31 19:07:27 +00:00
ompi_value_array.c Change the test to properly check uint64_t in ompi_value_array -- it's 2005-04-04 17:53:58 +00:00
orte_bitmap.c Fix the registry search routine to remove a buffer that wasn't expanding as it should - cause of recent problems observed when spawning larger numbers of processes. 2005-06-08 15:48:38 +00:00