1
1
openmpi/opal/mca/hwloc
Brian Barrett e9e4d2a4bc Handle asprintf errors with opal_asprintf wrapper
The Open MPI code base assumed that asprintf always behaved like
the FreeBSD variant, where ptr is set to NULL on error.  However,
the C standard (and Linux) only guarantee that the return code will
be -1 on error and leave ptr undefined.  Rather than fix all the
usage in the code, we use opal_asprintf() wrapper instead, which
guarantees the BSD-like behavior of ptr always being set to NULL.
In addition to being correct, this will fix many, many warnings
in the Open MPI code base.

Signed-off-by: Brian Barrett <bbarrett@amazon.com>
2018-10-08 16:43:53 -07:00
..
base Handle asprintf errors with opal_asprintf wrapper 2018-10-08 16:43:53 -07:00
external hwloc: prefer external hwloc component 2018-07-23 09:20:27 +09:00
hwloc201 hwloc201/configure.m4: make it safe when used with hwloc:external 2018-08-11 11:05:23 -07:00
autogen.options hwloc: rename opal/mca/hwloc/hwloc.h -> hwloc-internal.h 2017-02-28 07:48:42 -08:00
configure.m4 hwloc: rename opal/mca/hwloc/hwloc.h -> hwloc-internal.h 2017-02-28 07:48:42 -08:00
hwloc-internal.h Define a new binding method and qualifier 2018-06-20 21:26:09 -07:00
Makefile.am hwloc: re-enable use of autogen.pl in a tarball 2017-03-17 11:41:17 -07:00
README.txt Purge whitespace from the repo 2015-06-23 20:59:57 -07:00

12 Sep 2011

Notes for hwloc component maintainers:

1. There can only be *1* hwloc version component at a time.
   Specifically: if there are multiple hwlocXYZ components (i.e.,
   different versions of hwloc), then they must all be .ompi_ignore'd
   except for 1.  This is because we currently m4_include all of the
   underlying hwloc's .m4 files -- if there are multiple hwlocXYZ
   components, I don't know if m4 will barf at the multiple,
   conflicting AC_DEFUNs, or whether it'll just do something
   completely undefined.

1a. As a consequence, if you're adding a new hwloc version component,
   you'll need to .ompi_ignore all others while you're testing the new
   one.

2. If someone wants to fix #1 someday, we might be able to do what we
   do for libevent: OPAL_CONFIG_SUBDIR (instead of slurping in hwloc's
   .m4 files).