e00c6053dc
handling of invalid Fortran handles. Per MPI-2:4.12.4, if we get an invalid Fortran handle, we should return an invalid C handle. Before this commit, we checked if the fortran handle index was out of range (i.e., <0 or >sizeof(array)). If so, we used to return MPI_*_NULL (i.e., a valid C handle). But to be faithful to MPI-2:4.12.4, we now return NULL (an invalid C handle). If the fortran index is in bounds but is an index for an MPI object that has already been freed, the code already returns NULL because the entry in the array will be NULL (i.e., we already did what MPI-2:4.12.4 said for this case). Hence, this commit makes the handling of invalid fortran handles in the MPI_*_F2C functions be uniform: we always return NULL. Commit 2 of this will be to edit just about every C interface function (!) to ensure that MPI handles are not NULL. Otherwise, if the user calls a fortran interface function with an invalid handle, the fortran interface function will call MPI_*_F2C and blindly pass the result to the back-end C function. The C function will eventually end up trying to dereference it -- segv. Having a run-time check for NULL and invoking an MPI exception is far more social (e.g., the user can get a stack trace out of MPI_ABORT) and consistent (i.e., we're already checking for MPI_*_NULL in the C interface functions). Since all the C interface functions have all the machinery for run-time parameter checking, and they all already check for MPI_*_NULL, it's easy enough to add another check for NULL. This commit was SVN r9560.
55 строки
1.6 KiB
C
55 строки
1.6 KiB
C
/*
|
|
* Copyright (c) 2004-2005 The Trustees of Indiana University and Indiana
|
|
* University Research and Technology
|
|
* Corporation. All rights reserved.
|
|
* Copyright (c) 2004-2005 The University of Tennessee and The University
|
|
* of Tennessee Research Foundation. All rights
|
|
* reserved.
|
|
* Copyright (c) 2004-2005 High Performance Computing Center Stuttgart,
|
|
* University of Stuttgart. All rights reserved.
|
|
* Copyright (c) 2004-2005 The Regents of the University of California.
|
|
* All rights reserved.
|
|
* Copyright (c) 2006 Cisco Systems, Inc. All rights reserved.
|
|
* $COPYRIGHT$
|
|
*
|
|
* Additional copyrights may follow
|
|
*
|
|
* $HEADER$
|
|
*/
|
|
#include "ompi_config.h"
|
|
|
|
#include "ompi/win/win.h"
|
|
#include "ompi/mpi/c/bindings.h"
|
|
#include "ompi/mpi/f77/fint_2_int.h"
|
|
|
|
#if OMPI_HAVE_WEAK_SYMBOLS && OMPI_PROFILING_DEFINES
|
|
#pragma weak MPI_Win_f2c = PMPI_Win_f2c
|
|
#endif
|
|
|
|
#if OMPI_PROFILING_DEFINES
|
|
#include "ompi/mpi/c/profile/defines.h"
|
|
#endif
|
|
|
|
static const char FUNC_NAME[] = "MPI_Win_f2c";
|
|
|
|
|
|
MPI_Win MPI_Win_f2c(MPI_Fint win)
|
|
{
|
|
int o_index= OMPI_FINT_2_INT(win);
|
|
|
|
if (MPI_PARAM_CHECK) {
|
|
OMPI_ERR_INIT_FINALIZE(FUNC_NAME);
|
|
}
|
|
|
|
/* Per MPI-2:4.12.4, do not invoke an error handler if we get an
|
|
invalid fortran handle. If we get an invalid fortran handle,
|
|
return an invalid C handle. */
|
|
|
|
if ( 0 > o_index ||
|
|
o_index >= ompi_pointer_array_get_size(&ompi_mpi_windows)) {
|
|
return NULL;
|
|
}
|
|
|
|
return ompi_pointer_array_get_item(&ompi_mpi_windows, o_index);
|
|
}
|