d7264aa613
This commit fixes several bugs identified by a new multi-threaded RMA benchmarking suite. The following bugs have been identified and fixed: - The code that signaled the actual start of an access epoch changed the eager_send_active flag on a synchronization object without holding the object's lock. This could cause another thread waiting on eager sends to block indefinitely because the entirety of ompi_osc_pt2pt_sync_expected could exectute between the check of eager_send_active and the conditon wait of ompi_osc_pt2pt_sync_wait. - The bookkeeping of fragments could get screwed up when performing long put/accumulate operations from different threads. This was caused by the fragment flush code at the end of both put and accumulate. This code was put in place to avoid sending a large number of unexpected messages to a peer. To fix the bookkeeping issue we now 1) wait for eager sends to be active before stating any large isend's, and 2) keep track of the number of large isends associated with a fragment. If the number of large isends reaches 32 the active fragment is flushed. - Use atomics to update the large receive/send tag counters. This prevents duplicate tags from being used. The tag space has also been updated to use the entire 16-bits of the tag space. These changes should also fix open-mpi/ompi#1299. Signed-off-by: Nathan Hjelm <hjelmn@lanl.gov>
78 строки
3.1 KiB
C
78 строки
3.1 KiB
C
/* -*- Mode: C; c-basic-offset:4 ; indent-tabs-mode:nil -*- */
|
|
/*
|
|
* Copyright (c) 2012 Sandia National Laboratories. All rights reserved.
|
|
* Copyright (c) 2014-2016 Los Alamos National Security, LLC. All rights
|
|
* reserved.
|
|
* Copyright (c) 2015 Research Organization for Information Science
|
|
* and Technology (RIST). All rights reserved.
|
|
* $COPYRIGHT$
|
|
*
|
|
* Additional copyrights may follow
|
|
*
|
|
* $HEADER$
|
|
*/
|
|
|
|
#ifndef OMPI_OSC_PT2PT_REQUEST_H
|
|
#define OMPI_OSC_PT2PT_REQUEST_H
|
|
|
|
#include "osc_pt2pt.h"
|
|
|
|
#include "ompi/request/request.h"
|
|
#include "opal/util/output.h"
|
|
|
|
struct ompi_osc_pt2pt_request_t {
|
|
ompi_request_t super;
|
|
|
|
int type;
|
|
const void *origin_addr;
|
|
int origin_count;
|
|
struct ompi_datatype_t *origin_dt;
|
|
ompi_osc_pt2pt_module_t* module;
|
|
int32_t outstanding_requests;
|
|
bool internal;
|
|
};
|
|
typedef struct ompi_osc_pt2pt_request_t ompi_osc_pt2pt_request_t;
|
|
OBJ_CLASS_DECLARATION(ompi_osc_pt2pt_request_t);
|
|
|
|
/* REQUEST_ALLOC is only called from "top-level" functions (pt2pt_rput,
|
|
pt2pt_rget, etc.), so it's ok to spin here... */
|
|
#define OMPI_OSC_PT2PT_REQUEST_ALLOC(win, req) \
|
|
do { \
|
|
opal_free_list_item_t *item; \
|
|
do { \
|
|
item = opal_free_list_get (&mca_osc_pt2pt_component.requests); \
|
|
if (NULL == item) { \
|
|
opal_progress(); \
|
|
} \
|
|
} while (NULL == item); \
|
|
req = (ompi_osc_pt2pt_request_t*) item; \
|
|
OMPI_REQUEST_INIT(&req->super, false); \
|
|
req->super.req_mpi_object.win = win; \
|
|
req->super.req_complete = false; \
|
|
req->super.req_state = OMPI_REQUEST_ACTIVE; \
|
|
req->module = GET_MODULE(win); \
|
|
req->internal = false; \
|
|
} while (0)
|
|
|
|
#define OMPI_OSC_PT2PT_REQUEST_RETURN(req) \
|
|
do { \
|
|
OMPI_REQUEST_FINI(&(req)->super); \
|
|
(req)->outstanding_requests = 0; \
|
|
opal_free_list_return (&mca_osc_pt2pt_component.requests, \
|
|
(opal_free_list_item_t *) (req)); \
|
|
} while (0)
|
|
|
|
static inline void ompi_osc_pt2pt_request_complete (ompi_osc_pt2pt_request_t *request, int mpi_error)
|
|
{
|
|
if (!request->internal) {
|
|
request->super.req_status.MPI_ERROR = mpi_error;
|
|
|
|
/* mark the request complete at the mpi level */
|
|
ompi_request_complete (&request->super, true);
|
|
} else {
|
|
OMPI_OSC_PT2PT_REQUEST_RETURN (request);
|
|
}
|
|
}
|
|
|
|
#endif /* OMPI_OSC_PT2PT_REQUEST_H */
|