1
1
openmpi/ompi/mca/coll
Jeff Squyres c8258c06e2 In coll_sm, we alloc a huge chunk of shared memory, divvy it into lots
of individual regions (each region is a multiple of page size in
length), and each process claims its own regions by binding it to its
local memory.  Each process would end up membining something like 16
individual regions in the overall shmem segment.

There were two errors in this code relating to the memory affinity
pinning.  Some combination of these two errors would lead to kernel
panics (!) on my RHEL 6.2 x86_64 machines when used with mmap'ed
shared memory (not posix or sysv shared memory, curiously enough):

1. The shared memory segment is initially divided into two regions:
control and data.  The control starts at the beginning of the shmem
segment, the data starts after that.  The data portion, unfortunately,
was ''not'' aligned to a page.  So all the multiple-of-page-size
regions that we divvy up were also not alined on page boundaries.  And
therefore all the regions we tried to membind were not on page
boundaries.

The solution was to ensure that the data portion started on a page
boundary.  Then all of the individual regions were on page boundaries,
too.

That being said, in my tests, Linux mbind() fails gracefully when the
address is not on a page boundary.  So I'm not sure how this worked at
all / led to a kernel panic...

2. There was some bad pointer math that resulted in membinding regions
larger than they should have been, resulting in region overlaps.
There were definitely overlaps between regions in the same process;
it's likely that there were overlaps between regions of multiple
processes, too -- I'm not sure (and don't care to figure out :-) ).

The solution was to fix the pointer math so that each region membinds
exactly only itself and no neighboring/overlapping regions.

cmr:v1.7.2:reviewer=samuel

This commit was SVN r28442.
2013-05-03 12:49:35 +00:00
..
base Update OMPI frameworks to use the MCA framework system. 2013-03-27 21:17:31 +00:00
basic MCA/base: Add new MCA variable system 2013-03-27 21:09:41 +00:00
demo Update OMPI frameworks to use the MCA framework system. 2013-03-27 21:17:31 +00:00
fca MCA/base: Add new MCA variable system 2013-03-27 21:09:41 +00:00
hierarch MCA/base: Add new MCA variable system 2013-03-27 21:09:41 +00:00
inter MCA/base: Add new MCA variable system 2013-03-27 21:09:41 +00:00
libnbc MCA/base: Add new MCA variable system 2013-03-27 21:09:41 +00:00
ml Update OMPI frameworks to use the MCA framework system. 2013-03-27 21:17:31 +00:00
self MCA/base: Add new MCA variable system 2013-03-27 21:09:41 +00:00
sm In coll_sm, we alloc a huge chunk of shared memory, divvy it into lots 2013-05-03 12:49:35 +00:00
tuned MCA/base: Add new MCA variable system 2013-03-27 21:09:41 +00:00
coll.h * Initial merge of the non-blocking collectives interface. No implementation of 2012-06-22 20:54:12 +00:00
Makefile.am Fix mistake that came in via the ompi-agen tree in r23764. The mistake wasn't part of the core autogen upgrade; it was an additional 'bonus' cleanup. Oops. The mistake will always create a set of directories under installdir, even if you do not --with-devel-headers. The set of directories will be empty, but still -- they should not be there at all. This commit fixes that -- the directories are not created at all if you do not --with-devel-headers 2010-09-24 22:53:28 +00:00