3e2031e0e3
development trees since last year (had to wait for some intel tests to run yesterday, so I finally took the time to finish this work): * Improve MPI API argument checking by also checking for NULL values (especially helps when invalid Fortran MPI handles are passed, because the various MPI_*f2c functions are supposed to return an "invalid" MPI handle [meaning NULL] when this happens). So now OMPI will generate an MPI exception rather than a segv. * Removed a few redundant DATATYPE_NULL checks. * Also check for some other forms of "invalid" handles (e.g., already been freed, etc.) in some cases. We could probably be a bit more stringent in this regard if we really wanted to. * Change MPI_Get_processor_name to zero out the string up to MPI_MAX_PROCESSOR_NAME characters, because the MPI spec says that the string must be at least that long. We were already passing that length to gethostname(), anyway. This commit was SVN r14100.
95 строки
3.5 KiB
C
95 строки
3.5 KiB
C
/*
|
|
* Copyright (c) 2004-2007 The Trustees of Indiana University and Indiana
|
|
* University Research and Technology
|
|
* Corporation. All rights reserved.
|
|
* Copyright (c) 2004-2005 The University of Tennessee and The University
|
|
* of Tennessee Research Foundation. All rights
|
|
* reserved.
|
|
* Copyright (c) 2004-2005 High Performance Computing Center Stuttgart,
|
|
* University of Stuttgart. All rights reserved.
|
|
* Copyright (c) 2004-2005 The Regents of the University of California.
|
|
* All rights reserved.
|
|
* Copyright (c) 2006 Cisco Systems, Inc. All rights reserved.
|
|
* $COPYRIGHT$
|
|
*
|
|
* Additional copyrights may follow
|
|
*
|
|
* $HEADER$
|
|
*/
|
|
#include "ompi_config.h"
|
|
#include <stdio.h>
|
|
|
|
#include "ompi/mpi/c/bindings.h"
|
|
#include "ompi/datatype/datatype.h"
|
|
#include "ompi/datatype/convertor.h"
|
|
|
|
#if OMPI_HAVE_WEAK_SYMBOLS && OMPI_PROFILING_DEFINES
|
|
#pragma weak MPI_Pack_external = PMPI_Pack_external
|
|
#endif
|
|
|
|
#if OMPI_PROFILING_DEFINES
|
|
#include "ompi/mpi/c/profile/defines.h"
|
|
#endif
|
|
|
|
static const char FUNC_NAME[] = "MPI_Pack_external";
|
|
|
|
|
|
int MPI_Pack_external(char *datarep, void *inbuf, int incount,
|
|
MPI_Datatype datatype, void *outbuf,
|
|
MPI_Aint outsize, MPI_Aint *position)
|
|
{
|
|
int rc;
|
|
ompi_convertor_t local_convertor;
|
|
struct iovec invec;
|
|
unsigned int iov_count;
|
|
size_t size;
|
|
|
|
OPAL_CR_TEST_CHECKPOINT_READY();
|
|
|
|
if (MPI_PARAM_CHECK) {
|
|
OMPI_ERR_INIT_FINALIZE(FUNC_NAME);
|
|
if ((NULL == outbuf) || (NULL == position)) { /* inbuf can be MPI_BOTTOM */
|
|
return OMPI_ERRHANDLER_INVOKE(MPI_COMM_WORLD, MPI_ERR_ARG, FUNC_NAME);
|
|
} else if (incount < 0) {
|
|
return OMPI_ERRHANDLER_INVOKE(MPI_COMM_WORLD, MPI_ERR_COUNT, FUNC_NAME);
|
|
} else if (outsize < 0) {
|
|
return OMPI_ERRHANDLER_INVOKE(MPI_COMM_WORLD, MPI_ERR_ARG, FUNC_NAME);
|
|
} else if (MPI_DATATYPE_NULL == datatype || NULL == datatype) {
|
|
return OMPI_ERRHANDLER_INVOKE(MPI_COMM_WORLD, MPI_ERR_TYPE, FUNC_NAME);
|
|
}
|
|
}
|
|
|
|
OBJ_CONSTRUCT(&local_convertor, ompi_convertor_t);
|
|
|
|
/* The resulting convertor will be set to the position zero. We have to use
|
|
* CONVERTOR_SEND_CONVERSION in order to force the convertor to do anything
|
|
* more than just packing the data.
|
|
*/
|
|
ompi_convertor_copy_and_prepare_for_send( ompi_mpi_external32_convertor,
|
|
datatype, incount, inbuf,
|
|
CONVERTOR_SEND_CONVERSION,
|
|
&local_convertor );
|
|
|
|
/* Check for truncation */
|
|
ompi_convertor_get_packed_size( &local_convertor, &size );
|
|
if( (*position + size) > (size_t)outsize ) { /* we can cast as we already checked for < 0 */
|
|
OBJ_DESTRUCT( &local_convertor );
|
|
return OMPI_ERRHANDLER_INVOKE( MPI_COMM_WORLD, MPI_ERR_TRUNCATE, FUNC_NAME );
|
|
}
|
|
|
|
/* Prepare the iovec with all informations */
|
|
invec.iov_base = (char*) outbuf + (*position);
|
|
invec.iov_len = size;
|
|
|
|
/* Do the actual packing */
|
|
iov_count = 1;
|
|
rc = ompi_convertor_pack( &local_convertor, &invec, &iov_count, &size );
|
|
*position += size;
|
|
OBJ_DESTRUCT( &local_convertor );
|
|
|
|
/* All done. Note that the convertor returns 1 upon success, not
|
|
OMPI_SUCCESS. */
|
|
OMPI_ERRHANDLER_RETURN((rc == 1) ? OMPI_SUCCESS : OMPI_ERROR,
|
|
MPI_COMM_WORLD, MPI_ERR_UNKNOWN, FUNC_NAME);
|
|
}
|