![Nathan Hjelm](/assets/img/avatar_default.png)
This commit fixes typos on the C side of the request-based RMA binding. We were not returning the request on success but on failure. Thanks to @alazzaro for reporting and @ggouaillardet, and @vondele for tracking this down. Fixes part of open-mpi/ompi#1869 Signed-off-by: Nathan Hjelm <hjelmn@me.com>
107 строки
5.3 KiB
C
107 строки
5.3 KiB
C
/* -*- Mode: C; c-basic-offset:4 ; indent-tabs-mode:nil -*- */
|
|
/*
|
|
* Copyright (c) 2004-2005 The Trustees of Indiana University and Indiana
|
|
* University Research and Technology
|
|
* Corporation. All rights reserved.
|
|
* Copyright (c) 2004-2005 The University of Tennessee and The University
|
|
* of Tennessee Research Foundation. All rights
|
|
* reserved.
|
|
* Copyright (c) 2004-2005 High Performance Computing Center Stuttgart,
|
|
* University of Stuttgart. All rights reserved.
|
|
* Copyright (c) 2004-2005 The Regents of the University of California.
|
|
* All rights reserved.
|
|
* Copyright (c) 2011-2012 Cisco Systems, Inc. All rights reserved.
|
|
* Copyright (c) 2014-2016 Los Alamos National Security, LLC. All rights
|
|
* reserved.
|
|
* Copyright (c) 2015 Research Organization for Information Science
|
|
* and Technology (RIST). All rights reserved.
|
|
* Copyright (c) 2015 FUJITSU LIMITED. All rights reserved.
|
|
* $COPYRIGHT$
|
|
*
|
|
* Additional copyrights may follow
|
|
*
|
|
* $HEADER$
|
|
*/
|
|
|
|
#include "ompi_config.h"
|
|
|
|
#include "ompi/mpi/fortran/mpif-h/bindings.h"
|
|
#include "ompi/mpi/fortran/base/constants.h"
|
|
|
|
|
|
#if OMPI_BUILD_MPI_PROFILING
|
|
#if OPAL_HAVE_WEAK_SYMBOLS
|
|
#pragma weak PMPI_RGET_ACCUMULATE = ompi_rget_accumulate_f
|
|
#pragma weak pmpi_rget_accumulate = ompi_rget_accumulate_f
|
|
#pragma weak pmpi_rget_accumulate_ = ompi_rget_accumulate_f
|
|
#pragma weak pmpi_rget_accumulate__ = ompi_rget_accumulate_f
|
|
|
|
#pragma weak PMPI_Rget_accumulate_f = ompi_rget_accumulate_f
|
|
#pragma weak PMPI_Rget_accumulate_f08 = ompi_rget_accumulate_f
|
|
#else
|
|
OMPI_GENERATE_F77_BINDINGS (PMPI_RGET_ACCUMULATE,
|
|
pmpi_rget_accumulate,
|
|
pmpi_rget_accumulate_,
|
|
pmpi_rget_accumulate__,
|
|
pompi_rget_accumulate_f,
|
|
(char *origin_addr, MPI_Fint *origin_count, MPI_Fint *origin_datatype, char *result_addr, MPI_Fint *result_count, MPI_Fint *result_datatype, MPI_Fint *target_rank, MPI_Aint *target_disp, MPI_Fint *target_count, MPI_Fint *target_datatype, MPI_Fint *op, MPI_Fint *win, MPI_Fint *request, MPI_Fint *ierr),
|
|
(origin_addr, origin_count, origin_datatype, result_addr, result_count, result_datatype, target_rank, target_disp, target_count, target_datatype, op, win, request, ierr) )
|
|
#endif
|
|
#endif
|
|
|
|
#if OPAL_HAVE_WEAK_SYMBOLS
|
|
#pragma weak MPI_RGET_ACCUMULATE = ompi_rget_accumulate_f
|
|
#pragma weak mpi_rget_accumulate = ompi_rget_accumulate_f
|
|
#pragma weak mpi_rget_accumulate_ = ompi_rget_accumulate_f
|
|
#pragma weak mpi_rget_accumulate__ = ompi_rget_accumulate_f
|
|
|
|
#pragma weak MPI_Rget_accumulate_f = ompi_rget_accumulate_f
|
|
#pragma weak MPI_Rget_accumulate_f08 = ompi_rget_accumulate_f
|
|
#else
|
|
#if ! OMPI_BUILD_MPI_PROFILING
|
|
OMPI_GENERATE_F77_BINDINGS (MPI_RGET_ACCUMULATE,
|
|
mpi_rget_accumulate,
|
|
mpi_rget_accumulate_,
|
|
mpi_rget_accumulate__,
|
|
ompi_rget_accumulate_f,
|
|
(char *origin_addr, MPI_Fint *origin_count, MPI_Fint *origin_datatype, char *result_addr, MPI_Fint *result_count, MPI_Fint *result_datatype, MPI_Fint *target_rank, MPI_Aint *target_disp, MPI_Fint *target_count, MPI_Fint *target_datatype, MPI_Fint *op, MPI_Fint *win, MPI_Fint *request, MPI_Fint *ierr),
|
|
(origin_addr, origin_count, origin_datatype, result_addr, result_count, result_datatype, target_rank, target_disp, target_count, target_datatype, op, win, request, ierr) )
|
|
#else
|
|
#define ompi_rget_accumulate_f pompi_rget_accumulate_f
|
|
#endif
|
|
#endif
|
|
|
|
|
|
void ompi_rget_accumulate_f(char *origin_addr, MPI_Fint *origin_count,
|
|
MPI_Fint *origin_datatype, char *result_addr,
|
|
MPI_Fint *result_count, MPI_Fint *result_datatype,
|
|
MPI_Fint *target_rank, MPI_Aint *target_disp,
|
|
MPI_Fint *target_count, MPI_Fint *target_datatype,
|
|
MPI_Fint *op, MPI_Fint *win, MPI_Fint *request,
|
|
MPI_Fint *ierr)
|
|
{
|
|
int c_ierr;
|
|
MPI_Datatype c_origin_datatype = PMPI_Type_f2c(*origin_datatype);
|
|
MPI_Datatype c_result_datatype = PMPI_Type_f2c(*result_datatype);
|
|
MPI_Datatype c_target_datatype = PMPI_Type_f2c(*target_datatype);
|
|
MPI_Win c_win = PMPI_Win_f2c(*win);
|
|
MPI_Op c_op = PMPI_Op_f2c(*op);
|
|
MPI_Request c_req;
|
|
|
|
c_ierr = PMPI_Rget_accumulate(OMPI_F2C_BOTTOM(origin_addr),
|
|
OMPI_FINT_2_INT(*origin_count),
|
|
c_origin_datatype,
|
|
OMPI_F2C_BOTTOM(result_addr),
|
|
OMPI_FINT_2_INT(*result_count),
|
|
c_result_datatype,
|
|
OMPI_FINT_2_INT(*target_rank),
|
|
*target_disp,
|
|
OMPI_FINT_2_INT(*target_count),
|
|
c_target_datatype, c_op, c_win, &c_req);
|
|
if (NULL != ierr) *ierr = OMPI_INT_2_FINT(c_ierr);
|
|
|
|
if (MPI_SUCCESS == c_ierr) {
|
|
*request = PMPI_Request_c2f(c_req);
|
|
}
|
|
}
|