482d84b6e5
The expected sequence of events for processing info during object creation
is that if there's an incoming info arg, it is opal_info_dup()ed into the obj
at obj->s_info first. Then interested components register callbacks for
keys they want to know about using opal_infosubscribe_infosubscribe().
Inside info_subscribe_subscribe() the specified callback() is called with
whatever matching k/v is in the object's info, or with the default. The
return string from the callback goes into the new k/v stored in info, and
the input k/v is saved as __IN_<key>/<val>. It's saved the same way
whether the input came from info or whether it was a default. A null return
from the callback indicates an ignored key/val, and no k/v is stored for
it, but an __IN_<key>/<val> is still kept so we still have access to the
original.
At MPI_*_set_info() time, opal_infosubscribe_change_info() is used. That
function calls the registered callbacks for each item in the provided info.
If the callback returns non-null, the info is updated with that k/v, or if
the callback returns null, that key is deleted from info. An __IN_<key>/<val>
is saved either way, and overwrites any previously saved value.
When MPI_*_get_info() is called, opal_info_dup_mpistandard() is used, which
allows relatively easy changes in interpretation of the standard, by looking
at both the <key>/<val> and __IN_<key>/<val> in info. Right now it does
1. includes system extras, eg k/v defaults not expliclty set by the user
2. omits ignored keys
3. shows input values, not callback modifications, eg not the internal values
Currently the callbacks are doing things like
return some_condition ? "true" : "false"
that is, returning static strings that are not to be freed. If the return
strings start becoming more dynamic in the future I don't see how unallocated
strings could support that, so I'd propose a change for the future that
the callback()s registered with info_subscribe_subscribe() do a strdup on
their return, and we change the callers of callback() to free the strings
it returns (there are only two callers).
Rough outline of the smaller changes spread over the less central files:
comm.c
initialize comm->super.s_info to NULL
copy into comm->super.s_info in comm creation calls that provide info
OBJ_RELEASE comm->super.s_info at free time
comm_init.c
initialize comm->super.s_info to NULL
file.c
copy into file->super.s_info if file creation provides info
OBJ_RELEASE file->super.s_info at free time
win.c
copy into win->super.s_info if win creation provides info
OBJ_RELEASE win->super.s_info at free time
comm_get_info.c
file_get_info.c
win_get_info.c
change_info() if there's no info attached (shouldn't happen if callbacks
are registered)
copy the info for the user
The other category of change is generally addressing compiler warnings where
ompi_info_t and opal_info_t were being used a little too interchangably. An
ompi_info_t* contains an opal_info_t*, at &(ompi_info->super)
Also this commit updates the copyrights.
Signed-off-by: Mark Allen <markalle@us.ibm.com>
110 строки
3.6 KiB
C
110 строки
3.6 KiB
C
/*
|
|
* Copyright (c) 2004-2007 The Trustees of Indiana University and Indiana
|
|
* University Research and Technology
|
|
* Corporation. All rights reserved.
|
|
* Copyright (c) 2004-2013 The University of Tennessee and The University
|
|
* of Tennessee Research Foundation. All rights
|
|
* reserved.
|
|
* Copyright (c) 2004-2005 High Performance Computing Center Stuttgart,
|
|
* University of Stuttgart. All rights reserved.
|
|
* Copyright (c) 2004-2005 The Regents of the University of California.
|
|
* All rights reserved.
|
|
* Copyright (c) 2012-2013 Inria. All rights reserved.
|
|
* Copyright (c) 2015 Research Organization for Information Science
|
|
* and Technology (RIST). All rights reserved.
|
|
* $COPYRIGHT$
|
|
*
|
|
* Additional copyrights may follow
|
|
*
|
|
* $HEADER$
|
|
*/
|
|
|
|
#include "ompi_config.h"
|
|
|
|
#include "ompi/mpi/c/bindings.h"
|
|
#include "ompi/runtime/params.h"
|
|
#include "ompi/communicator/communicator.h"
|
|
#include "ompi/errhandler/errhandler.h"
|
|
#include "ompi/info/info.h"
|
|
#include <stdlib.h>
|
|
#include <string.h>
|
|
|
|
#if OMPI_BUILD_MPI_PROFILING
|
|
#if OPAL_HAVE_WEAK_SYMBOLS
|
|
#pragma weak MPI_Info_set = PMPI_Info_set
|
|
#endif
|
|
#define MPI_Info_set PMPI_Info_set
|
|
#endif
|
|
|
|
static const char FUNC_NAME[] = "MPI_Info_set";
|
|
|
|
|
|
/**
|
|
* MPI_Info_set - Set a (key, value) pair in an 'MPI_Info' object
|
|
*
|
|
* @param key null-terminated character string of the index key
|
|
* @param value null-terminated character string of the value
|
|
* @param info info object (handle)
|
|
*
|
|
* @retval MPI_SUCCESS
|
|
* @retval MPI_ERR_ARG
|
|
* @retval MPI_ERR_INFO_KEY
|
|
* @retval MPI_ERR_INFO_VAL
|
|
* @retval MPI_ERR_INFO_NOKEY
|
|
* @retval MPI_ERR_NO_MEM
|
|
*
|
|
* MPI_Info_set adds the (key,value) pair to info, and overrides
|
|
* the value if for the same key a previsou value was set. key and
|
|
* value must be NULL terminated strings in C. In Fortan, leading
|
|
* and trailing spaces in key and value are stripped. If either
|
|
* key or value is greater than the allowed maxima, MPI_ERR_INFO_KEY
|
|
* and MPI_ERR_INFO_VALUE are raised
|
|
*/
|
|
int MPI_Info_set(MPI_Info info, const char *key, const char *value)
|
|
{
|
|
int err;
|
|
int key_length;
|
|
int value_length;
|
|
|
|
/*
|
|
* Error conditions are
|
|
* - info is NULL
|
|
* - No storage space available for the new value
|
|
* - Key length exceeded MPI_MAX_KEY_VAL
|
|
* - value length exceeded MPI_MAX_KEY_VAL
|
|
*/
|
|
|
|
if (MPI_PARAM_CHECK) {
|
|
OMPI_ERR_INIT_FINALIZE(FUNC_NAME);
|
|
if (NULL == info || MPI_INFO_NULL == info ||
|
|
ompi_info_is_freed(info)) {
|
|
return OMPI_ERRHANDLER_INVOKE (MPI_COMM_WORLD, MPI_ERR_INFO,
|
|
FUNC_NAME);
|
|
}
|
|
|
|
key_length = (key) ? (int)strlen (key) : 0;
|
|
if ((NULL == key) || (0 == key_length) ||
|
|
(MPI_MAX_INFO_KEY <= key_length)) {
|
|
return OMPI_ERRHANDLER_INVOKE (MPI_COMM_WORLD, MPI_ERR_INFO_KEY,
|
|
FUNC_NAME);
|
|
}
|
|
|
|
value_length = (value) ? (int)strlen (value) : 0;
|
|
if ((NULL == value) || (0 == value_length) ||
|
|
(MPI_MAX_INFO_VAL <= value_length)) {
|
|
return OMPI_ERRHANDLER_INVOKE (MPI_COMM_WORLD, MPI_ERR_INFO_VALUE,
|
|
FUNC_NAME);
|
|
}
|
|
}
|
|
|
|
OPAL_CR_ENTER_LIBRARY();
|
|
|
|
/*
|
|
* If all is right with the arguments, then call the back-end
|
|
* allocator.
|
|
*/
|
|
|
|
err = ompi_info_set (info, key, value);
|
|
OMPI_ERRHANDLER_RETURN(err, MPI_COMM_WORLD, err, FUNC_NAME);
|
|
}
|