005c6022e2
There were a number of bugs in the framework/variable code that affected deregistration: - Frameworks could be erroneously closed if seperately registered and opened then subsequently closed. This was a bug in the original design which only reference counted opens but not registrations. This would cause undefined behavior if MPI_T_finalize actually calls ompi_info_close_components as intended. Now both registrations and opens are reference counted and frameworks/components are not torn down until the matching number of close calls have been made. - group_find_by_name did not pass the invalidok flags down to mca_base_var_group_get_internal correctly. - Group deregistration caused the group to be completely reset. This does not match the behavior required by MPI_T as it could reduce the number of variables/subgroups in a group. This commit also updates MPI_T_finalize to call ompi_info_close_components as originally intended. Closes #374 Signed-off-by: Nathan Hjelm <hjelmn@lanl.gov>
47 строки
988 B
C
47 строки
988 B
C
/* -*- Mode: C; c-basic-offset:4 ; indent-tabs-mode:nil -*- */
|
|
/*
|
|
* Copyright (c) 2012-2015 Los Alamos National Security, LLC. All rights
|
|
* reserved.
|
|
* Copyright (c) 2014 Cisco Systems, Inc. All rights reserved.
|
|
* $COPYRIGHT$
|
|
*
|
|
* Additional copyrights may follow
|
|
*
|
|
* $HEADER$
|
|
*/
|
|
|
|
|
|
#include "ompi/mpi/tool/mpit-internal.h"
|
|
|
|
#include "ompi/runtime/ompi_info_support.h"
|
|
#include "opal/include/opal/sys/atomic.h"
|
|
#include "opal/runtime/opal.h"
|
|
|
|
#if OPAL_HAVE_WEAK_SYMBOLS && OMPI_PROFILING_DEFINES
|
|
#pragma weak MPI_T_finalize = PMPI_T_finalize
|
|
#endif
|
|
|
|
#if OMPI_PROFILING_DEFINES
|
|
#include "ompi/mpi/tool/profile/defines.h"
|
|
#endif
|
|
|
|
|
|
int MPI_T_finalize (void)
|
|
{
|
|
mpit_lock ();
|
|
|
|
if (!mpit_is_initialized ()) {
|
|
mpit_unlock ();
|
|
return MPI_T_ERR_NOT_INITIALIZED;
|
|
}
|
|
|
|
if (0 == --mpit_init_count) {
|
|
(void) ompi_info_close_components ();
|
|
(void) opal_finalize_util ();
|
|
}
|
|
|
|
mpit_unlock ();
|
|
|
|
return MPI_SUCCESS;
|
|
}
|