0fe756d416
MPI standard states a user MPI_Op and/or user MPI_Datatype can be free'd after a call to a non blocking collective and before the non-blocking collective completes. Retain user (only) MPI_Op and MPI_Datatype when the non blocking call is invoked, and set a request callback so they are free'd when the MPI_Request completes. Thanks Thomas Ponweiser for reporting this Fixes open-mpi/ompi#2151 Fixes open-mpi/ompi#1304 Signed-off-by: Gilles Gouaillardet <gilles@rist.or.jp>
221 строка
8.4 KiB
C
221 строка
8.4 KiB
C
/* -*- Mode: C; c-basic-offset:4 ; indent-tabs-mode:nil -*- */
|
|
/*
|
|
* Copyright (c) 2004-2007 The Trustees of Indiana University and Indiana
|
|
* University Research and Technology
|
|
* Corporation. All rights reserved.
|
|
* Copyright (c) 2004-2018 The University of Tennessee and The University
|
|
* of Tennessee Research Foundation. All rights
|
|
* reserved.
|
|
* Copyright (c) 2004-2008 High Performance Computing Center Stuttgart,
|
|
* University of Stuttgart. All rights reserved.
|
|
* Copyright (c) 2004-2005 The Regents of the University of California.
|
|
* All rights reserved.
|
|
* Copyright (c) 2006-2012 Cisco Systems, Inc. All rights reserved.
|
|
* Copyright (c) 2012-2013 Los Alamos National Security, LLC. All rights
|
|
* reserved.
|
|
* Copyright (c) 2015-2019 Research Organization for Information Science
|
|
* and Technology (RIST). All rights reserved.
|
|
* $COPYRIGHT$
|
|
*
|
|
* Additional copyrights may follow
|
|
*
|
|
* $HEADER$
|
|
*/
|
|
#include "ompi_config.h"
|
|
#include <stdio.h>
|
|
|
|
#include "ompi/mpi/c/bindings.h"
|
|
#include "ompi/runtime/params.h"
|
|
#include "ompi/communicator/communicator.h"
|
|
#include "ompi/errhandler/errhandler.h"
|
|
#include "ompi/datatype/ompi_datatype.h"
|
|
#include "ompi/mca/coll/base/coll_base_util.h"
|
|
#include "ompi/memchecker.h"
|
|
#include "ompi/runtime/ompi_spc.h"
|
|
|
|
#if OMPI_BUILD_MPI_PROFILING
|
|
#if OPAL_HAVE_WEAK_SYMBOLS
|
|
#pragma weak MPI_Iscatterv = PMPI_Iscatterv
|
|
#endif
|
|
#define MPI_Iscatterv PMPI_Iscatterv
|
|
#endif
|
|
|
|
static const char FUNC_NAME[] = "MPI_Iscatterv";
|
|
|
|
|
|
int MPI_Iscatterv(const void *sendbuf, const int sendcounts[], const int displs[],
|
|
MPI_Datatype sendtype, void *recvbuf, int recvcount,
|
|
MPI_Datatype recvtype, int root, MPI_Comm comm, MPI_Request *request)
|
|
{
|
|
int i, size, err;
|
|
|
|
SPC_RECORD(OMPI_SPC_ISCATTERV, 1);
|
|
|
|
MEMCHECKER(
|
|
ptrdiff_t ext;
|
|
|
|
size = ompi_comm_remote_size(comm);
|
|
ompi_datatype_type_extent(recvtype, &ext);
|
|
|
|
memchecker_comm(comm);
|
|
if(OMPI_COMM_IS_INTRA(comm)) {
|
|
if(ompi_comm_rank(comm) == root) {
|
|
memchecker_datatype(sendtype);
|
|
/* check whether root's send buffer is defined. */
|
|
for (i = 0; i < size; i++) {
|
|
memchecker_call(&opal_memchecker_base_isdefined,
|
|
(char *)(sendbuf)+displs[i]*ext,
|
|
sendcounts[i], sendtype);
|
|
}
|
|
if(MPI_IN_PLACE != recvbuf) {
|
|
memchecker_datatype(recvtype);
|
|
/* check whether receive buffer is addressable. */
|
|
memchecker_call(&opal_memchecker_base_isaddressable, recvbuf, recvcount, recvtype);
|
|
}
|
|
} else {
|
|
memchecker_datatype(recvtype);
|
|
/* check whether receive buffer is addressable. */
|
|
memchecker_call(&opal_memchecker_base_isaddressable, recvbuf, recvcount, recvtype);
|
|
}
|
|
} else {
|
|
if(MPI_ROOT == root) {
|
|
memchecker_datatype(sendtype);
|
|
/* check whether root's send buffer is defined. */
|
|
for (i = 0; i < size; i++) {
|
|
memchecker_call(&opal_memchecker_base_isdefined,
|
|
(char *)(sendbuf)+displs[i]*ext,
|
|
sendcounts[i], sendtype);
|
|
}
|
|
} else if (MPI_PROC_NULL != root) {
|
|
/* check whether receive buffer is addressable. */
|
|
memchecker_call(&opal_memchecker_base_isaddressable, recvbuf, recvcount, recvtype);
|
|
}
|
|
}
|
|
);
|
|
|
|
if (MPI_PARAM_CHECK) {
|
|
err = MPI_SUCCESS;
|
|
OMPI_ERR_INIT_FINALIZE(FUNC_NAME);
|
|
if (ompi_comm_invalid(comm)) {
|
|
return OMPI_ERRHANDLER_INVOKE(MPI_COMM_WORLD, MPI_ERR_COMM,
|
|
FUNC_NAME);
|
|
} else if ((ompi_comm_rank(comm) != root && MPI_IN_PLACE == recvbuf) ||
|
|
(ompi_comm_rank(comm) == root && MPI_IN_PLACE == sendbuf)) {
|
|
return OMPI_ERRHANDLER_INVOKE(comm, MPI_ERR_ARG, FUNC_NAME);
|
|
}
|
|
|
|
/* Errors for intracommunicators */
|
|
|
|
if (OMPI_COMM_IS_INTRA(comm)) {
|
|
|
|
/* Errors for all ranks */
|
|
|
|
if ((root >= ompi_comm_size(comm)) || (root < 0)) {
|
|
return OMPI_ERRHANDLER_INVOKE(comm, MPI_ERR_ROOT, FUNC_NAME);
|
|
}
|
|
|
|
if (MPI_IN_PLACE != recvbuf) {
|
|
if (recvcount < 0) {
|
|
return OMPI_ERRHANDLER_INVOKE(comm, MPI_ERR_COUNT,
|
|
FUNC_NAME);
|
|
}
|
|
|
|
if (MPI_DATATYPE_NULL == recvtype || NULL == recvtype) {
|
|
return OMPI_ERRHANDLER_INVOKE(comm, MPI_ERR_TYPE,
|
|
FUNC_NAME);
|
|
}
|
|
}
|
|
|
|
/* Errors for the root. Some of these could have been
|
|
combined into compound if statements above, but since
|
|
this whole section can be compiled out (or turned off at
|
|
run time) for efficiency, it's more clear to separate
|
|
them out into individual tests. */
|
|
|
|
if (ompi_comm_rank(comm) == root) {
|
|
if (NULL == displs) {
|
|
return OMPI_ERRHANDLER_INVOKE(comm, MPI_ERR_ARG, FUNC_NAME);
|
|
}
|
|
|
|
if (NULL == sendcounts) {
|
|
return OMPI_ERRHANDLER_INVOKE(comm, MPI_ERR_COUNT, FUNC_NAME);
|
|
}
|
|
|
|
size = ompi_comm_size(comm);
|
|
for (i = 0; i < size; ++i) {
|
|
OMPI_CHECK_DATATYPE_FOR_SEND(err, sendtype, sendcounts[i]);
|
|
OMPI_ERRHANDLER_CHECK(err, comm, err, FUNC_NAME);
|
|
}
|
|
}
|
|
}
|
|
|
|
/* Errors for intercommunicators */
|
|
|
|
else {
|
|
if (! ((root >= 0 && root < ompi_comm_remote_size(comm)) ||
|
|
MPI_ROOT == root || MPI_PROC_NULL == root)) {
|
|
return OMPI_ERRHANDLER_INVOKE(comm, MPI_ERR_ROOT, FUNC_NAME);
|
|
}
|
|
|
|
/* Errors for the receivers */
|
|
|
|
if (MPI_ROOT != root && MPI_PROC_NULL != root) {
|
|
if (recvcount < 0) {
|
|
return OMPI_ERRHANDLER_INVOKE(comm, MPI_ERR_COUNT, FUNC_NAME);
|
|
}
|
|
|
|
if (MPI_DATATYPE_NULL == recvtype || NULL == recvtype) {
|
|
return OMPI_ERRHANDLER_INVOKE(comm, MPI_ERR_TYPE, FUNC_NAME);
|
|
}
|
|
}
|
|
|
|
/* Errors for the root. Ditto on the comment above -- these
|
|
error checks could have been combined above, but let's
|
|
make the code easier to read. */
|
|
|
|
else if (MPI_ROOT == root) {
|
|
if (NULL == displs) {
|
|
return OMPI_ERRHANDLER_INVOKE(comm, MPI_ERR_ARG, FUNC_NAME);
|
|
}
|
|
|
|
if (NULL == sendcounts) {
|
|
return OMPI_ERRHANDLER_INVOKE(comm, MPI_ERR_COUNT, FUNC_NAME);
|
|
}
|
|
|
|
size = ompi_comm_remote_size(comm);
|
|
for (i = 0; i < size; ++i) {
|
|
OMPI_CHECK_DATATYPE_FOR_SEND(err, sendtype, sendcounts[i]);
|
|
OMPI_ERRHANDLER_CHECK(err, comm, err, FUNC_NAME);
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
OPAL_CR_ENTER_LIBRARY();
|
|
|
|
/* Invoke the coll component to perform the back-end operation */
|
|
err = comm->c_coll->coll_iscatterv(sendbuf, sendcounts, displs,
|
|
sendtype, recvbuf, recvcount, recvtype, root, comm,
|
|
request, comm->c_coll->coll_iscatterv_module);
|
|
if (OPAL_LIKELY(OMPI_SUCCESS == err)) {
|
|
if (OMPI_COMM_IS_INTRA(comm)) {
|
|
if (MPI_IN_PLACE == recvbuf) {
|
|
recvtype = NULL;
|
|
} else if (ompi_comm_rank(comm) != root) {
|
|
sendtype = NULL;
|
|
}
|
|
} else {
|
|
if (MPI_ROOT == root) {
|
|
recvtype = NULL;
|
|
} else if (MPI_PROC_NULL == root) {
|
|
sendtype = NULL;
|
|
recvtype = NULL;
|
|
} else {
|
|
sendtype = NULL;
|
|
}
|
|
}
|
|
ompi_coll_base_retain_datatypes(*request, sendtype, recvtype);
|
|
}
|
|
OMPI_ERRHANDLER_RETURN(err, comm, err, FUNC_NAME);
|
|
}
|