0fe756d416
MPI standard states a user MPI_Op and/or user MPI_Datatype can be free'd after a call to a non blocking collective and before the non-blocking collective completes. Retain user (only) MPI_Op and MPI_Datatype when the non blocking call is invoked, and set a request callback so they are free'd when the MPI_Request completes. Thanks Thomas Ponweiser for reporting this Fixes open-mpi/ompi#2151 Fixes open-mpi/ompi#1304 Signed-off-by: Gilles Gouaillardet <gilles@rist.or.jp>
124 строки
4.4 KiB
C
124 строки
4.4 KiB
C
/* -*- Mode: C; c-basic-offset:4 ; indent-tabs-mode:nil -*- */
|
|
/*
|
|
* Copyright (c) 2004-2007 The Trustees of Indiana University and Indiana
|
|
* University Research and Technology
|
|
* Corporation. All rights reserved.
|
|
* Copyright (c) 2004-2018 The University of Tennessee and The University
|
|
* of Tennessee Research Foundation. All rights
|
|
* reserved.
|
|
* Copyright (c) 2004-2008 High Performance Computing Center Stuttgart,
|
|
* University of Stuttgart. All rights reserved.
|
|
* Copyright (c) 2004-2005 The Regents of the University of California.
|
|
* All rights reserved.
|
|
* Copyright (c) 2013 Los Alamos National Security, LLC. All rights
|
|
* reserved.
|
|
* Copyright (c) 2015-2019 Research Organization for Information Science
|
|
* and Technology (RIST). All rights reserved.
|
|
* Copyright (c) 2016 IBM Corporation. All rights reserved.
|
|
* $COPYRIGHT$
|
|
*
|
|
* Additional copyrights may follow
|
|
*
|
|
* $HEADER$
|
|
*/
|
|
|
|
#include "ompi_config.h"
|
|
#include <stdio.h>
|
|
|
|
#include "ompi/mpi/c/bindings.h"
|
|
#include "ompi/runtime/params.h"
|
|
#include "ompi/communicator/communicator.h"
|
|
#include "ompi/errhandler/errhandler.h"
|
|
#include "ompi/datatype/ompi_datatype.h"
|
|
#include "ompi/op/op.h"
|
|
#include "ompi/mca/coll/base/coll_base_util.h"
|
|
#include "ompi/memchecker.h"
|
|
#include "ompi/runtime/ompi_spc.h"
|
|
|
|
#if OMPI_BUILD_MPI_PROFILING
|
|
#if OPAL_HAVE_WEAK_SYMBOLS
|
|
#pragma weak MPI_Iallreduce = PMPI_Iallreduce
|
|
#endif
|
|
#define MPI_Iallreduce PMPI_Iallreduce
|
|
#endif
|
|
|
|
static const char FUNC_NAME[] = "MPI_Iallreduce";
|
|
|
|
|
|
int MPI_Iallreduce(const void *sendbuf, void *recvbuf, int count,
|
|
MPI_Datatype datatype, MPI_Op op, MPI_Comm comm, MPI_Request *request)
|
|
{
|
|
int err;
|
|
|
|
SPC_RECORD(OMPI_SPC_IALLREDUCE, 1);
|
|
|
|
MEMCHECKER(
|
|
memchecker_datatype(datatype);
|
|
memchecker_comm(comm);
|
|
|
|
/* check whether receive buffer is defined. */
|
|
memchecker_call(&opal_memchecker_base_isaddressable, recvbuf, count, datatype);
|
|
|
|
/* check whether the actual send buffer is defined. */
|
|
if (MPI_IN_PLACE == sendbuf) {
|
|
memchecker_call(&opal_memchecker_base_isdefined, recvbuf, count, datatype);
|
|
} else {
|
|
memchecker_call(&opal_memchecker_base_isdefined, sendbuf, count, datatype);
|
|
}
|
|
);
|
|
|
|
if (MPI_PARAM_CHECK) {
|
|
char *msg;
|
|
|
|
/* Unrooted operation -- same checks for all ranks on both
|
|
intracommunicators and intercommunicators */
|
|
|
|
err = MPI_SUCCESS;
|
|
OMPI_ERR_INIT_FINALIZE(FUNC_NAME);
|
|
if (ompi_comm_invalid(comm)) {
|
|
return OMPI_ERRHANDLER_INVOKE(MPI_COMM_WORLD, MPI_ERR_COMM,
|
|
FUNC_NAME);
|
|
} else if (MPI_OP_NULL == op) {
|
|
err = MPI_ERR_OP;
|
|
} else if (!ompi_op_is_valid(op, datatype, &msg, FUNC_NAME)) {
|
|
int ret = OMPI_ERRHANDLER_INVOKE(comm, MPI_ERR_OP, msg);
|
|
free(msg);
|
|
return ret;
|
|
} else if ((MPI_IN_PLACE == sendbuf && OMPI_COMM_IS_INTER(comm)) ||
|
|
MPI_IN_PLACE == recvbuf ) {
|
|
return OMPI_ERRHANDLER_INVOKE(MPI_COMM_WORLD, MPI_ERR_BUFFER,
|
|
FUNC_NAME);
|
|
} else if( (sendbuf == recvbuf) &&
|
|
(MPI_BOTTOM != sendbuf) &&
|
|
(count > 1) ) {
|
|
return OMPI_ERRHANDLER_INVOKE(MPI_COMM_WORLD, MPI_ERR_BUFFER,
|
|
FUNC_NAME);
|
|
} else {
|
|
OMPI_CHECK_DATATYPE_FOR_SEND(err, datatype, count);
|
|
}
|
|
OMPI_ERRHANDLER_CHECK(err, comm, err, FUNC_NAME);
|
|
}
|
|
|
|
|
|
/* MPI standard says that reductions have to have a count of at least 1,
|
|
* but some benchmarks (e.g., IMB) calls this function with a count of 0.
|
|
* So handle that case.
|
|
*/
|
|
if (0 == count) {
|
|
*request = &ompi_request_empty;
|
|
return MPI_SUCCESS;
|
|
}
|
|
|
|
OPAL_CR_ENTER_LIBRARY();
|
|
|
|
/* Invoke the coll component to perform the back-end operation */
|
|
|
|
err = comm->c_coll->coll_iallreduce(sendbuf, recvbuf, count, datatype,
|
|
op, comm, request, comm->c_coll->coll_iallreduce_module);
|
|
if (OPAL_LIKELY(OMPI_SUCCESS == err)) {
|
|
ompi_coll_base_retain_op(*request, op, datatype);
|
|
}
|
|
OMPI_ERRHANDLER_RETURN(err, comm, err, FUNC_NAME);
|
|
}
|
|
|