1
1
openmpi/opal/mca/btl/openib
Nathan Hjelm b038eb6434 btl/openib: more coverity fixes
CID 1301390 Dereference before null check (REVERSE_INULL)

endpoint can not be NULL here. Remove NULL check.

CID 1269836 Unintentional integer overflow (OVERFLOW_BEFORE_WIDEN)
CID 1301388 Bad bit shift operation (BAD_SHIFT)

Add ull to integer constants to ensure the math is done in 64-bits not
32.

CID 715749 Explicit null dereferenced (FORWARD_NULL)

As far as I can tell this parser function does not accept a line that
does match key = value. If that is the case then value should never be
NULL. If it is it is a parse error. Updated the code to reflect
this. Also modified the intify function to do something more sane
(strtol vs atoi with hex detection).

CID 1269820 Dereference null return value (NULL_RETURNS)

This is a false positive as strchr will never return NULL here. It
makes sense, though, to quiet the warning by changing the do {} while
() loop to a while () loop.

CID 1269780 Dereference after null check (FORWARD_NULL)

Just return an error if the endpoint's cpc data is NULL.

Signed-off-by: Nathan Hjelm <hjelmn@lanl.gov>
2015-05-28 11:58:17 -06:00
..
connect btl/openib: more coverity fixes 2015-05-28 11:58:17 -06:00
btl_openib_async.c btl/openib: fix more coverity issues 2015-05-28 08:38:10 -06:00
btl_openib_async.h btl/openib: rename OPAL_HAVE_XRCD macro into OPAL_HAVE_CONNECTX_XRC_DOMAINS 2015-01-07 13:27:25 +09:00
btl_openib_atomic.c btl/openib: fix heterogeneous support 2015-03-04 13:53:05 +09:00
btl_openib_component.c btl/openib: more coverity fixes 2015-05-28 11:58:17 -06:00
btl_openib_eager_rdma.h George did the work and deserves all the credit for it. Ralph did the merge, and deserves whatever blame results from errors in it :-) 2014-07-26 00:47:28 +00:00
btl_openib_endpoint.c btl/openib: fix more coverity issues 2015-05-28 08:38:10 -06:00
btl_openib_endpoint.h btl/openib: remove derived btl segment type 2015-03-10 14:41:15 -06:00
btl_openib_failover.c btl/openib: remove derived btl segment type 2015-03-10 14:41:15 -06:00
btl_openib_failover.h George did the work and deserves all the credit for it. Ralph did the merge, and deserves whatever blame results from errors in it :-) 2014-07-26 00:47:28 +00:00
btl_openib_fd.c cleanup dead code caused by the removal of the --with-threads configure option 2015-01-16 19:13:59 +09:00
btl_openib_fd.h George did the work and deserves all the credit for it. Ralph did the merge, and deserves whatever blame results from errors in it :-) 2014-07-26 00:47:28 +00:00
btl_openib_frag.c btl/openib: remove derived btl segment type 2015-03-10 14:41:15 -06:00
btl_openib_frag.h btl/openib: fix more coverity issues 2015-05-28 08:38:10 -06:00
btl_openib_get.c btl/openib: fix heterogeneous support 2015-03-04 13:53:05 +09:00
btl_openib_ini.c btl/openib: more coverity fixes 2015-05-28 11:58:17 -06:00
btl_openib_ini.h George did the work and deserves all the credit for it. Ralph did the merge, and deserves whatever blame results from errors in it :-) 2014-07-26 00:47:28 +00:00
btl_openib_ip.c Cleanup some cruft resulting from the move of the btl's to opal. We had created the ability to delay modex operations, which included a need to delay retrieving hostname info for remote procs. This allowed us to not retrieve the modex info until first message unless required - the hostname is generally only required for debug and error messages. 2014-10-03 16:02:57 -06:00
btl_openib_ip.h George did the work and deserves all the credit for it. Ralph did the merge, and deserves whatever blame results from errors in it :-) 2014-07-26 00:47:28 +00:00
btl_openib_lex.h George did the work and deserves all the credit for it. Ralph did the merge, and deserves whatever blame results from errors in it :-) 2014-07-26 00:47:28 +00:00
btl_openib_lex.l George did the work and deserves all the credit for it. Ralph did the merge, and deserves whatever blame results from errors in it :-) 2014-07-26 00:47:28 +00:00
btl_openib_mca.c btl/openib: fix more coverity issues 2015-05-28 08:38:10 -06:00
btl_openib_mca.h George did the work and deserves all the credit for it. Ralph did the merge, and deserves whatever blame results from errors in it :-) 2014-07-26 00:47:28 +00:00
btl_openib_proc.c Just because the openib BTL can't reach a process doesn't mean it is a job-ending error. If we have other methods for reaching the process (e.g., sm for a local proc), then that's okay. If there is no method for reaching a proc, then that's an error - but the BML will report that situation. 2014-09-10 17:02:16 +00:00
btl_openib_proc.h George did the work and deserves all the credit for it. Ralph did the merge, and deserves whatever blame results from errors in it :-) 2014-07-26 00:47:28 +00:00
btl_openib_put.c btl/openib: fix heterogeneous support 2015-03-04 13:53:05 +09:00
btl_openib_xrc.c btl/openib: rename OPAL_HAVE_XRCD macro into OPAL_HAVE_CONNECTX_XRC_DOMAINS 2015-01-07 13:27:25 +09:00
btl_openib_xrc.h btl/openib: add XRC support with OFED 3.12+ 2015-01-06 15:30:52 +09:00
btl_openib.c btl/openib: fix more coverity issues 2015-05-28 08:38:10 -06:00
btl_openib.h btl/openib: fix heterogeneous support 2015-03-04 13:53:05 +09:00
btl-openib-benchmark George did the work and deserves all the credit for it. Ralph did the merge, and deserves whatever blame results from errors in it :-) 2014-07-26 00:47:28 +00:00
configure.m4 btl/openib: add atomic operation support 2015-02-13 11:46:36 -07:00
help-mpi-btl-openib.txt btl/openib: fix coverity issues 2015-05-28 08:38:09 -06:00
Makefile.am btl/openib: add atomic operation support 2015-02-13 11:46:36 -07:00
mca-btl-openib-device-params.ini openib btl: add Soft iWARP device to the ini file 2014-11-04 14:48:43 -08:00
owner.txt add owner files to opa/ompi/orte mca directories 2015-02-22 15:10:23 -07:00