e9e4d2a4bc
The Open MPI code base assumed that asprintf always behaved like the FreeBSD variant, where ptr is set to NULL on error. However, the C standard (and Linux) only guarantee that the return code will be -1 on error and leave ptr undefined. Rather than fix all the usage in the code, we use opal_asprintf() wrapper instead, which guarantees the BSD-like behavior of ptr always being set to NULL. In addition to being correct, this will fix many, many warnings in the Open MPI code base. Signed-off-by: Brian Barrett <bbarrett@amazon.com>
105 строки
3.0 KiB
C
105 строки
3.0 KiB
C
/*
|
|
* Copyright (c) 2004-2007 The Trustees of the University of Tennessee.
|
|
* All rights reserved.
|
|
* Copyright (c) 2017 IBM Corporation. All rights reserved.
|
|
* Copyright (c) 2018 Amazon.com, Inc. or its affiliates. All Rights reserved.
|
|
* $COPYRIGHT$
|
|
*
|
|
* Additional copyrights may follow
|
|
*
|
|
* $HEADER$
|
|
*/
|
|
|
|
#ifndef PML_V_OUTPUT_H_HAS_BEEN_INCLUDED
|
|
#define PML_V_OUTPUT_H_HAS_BEEN_INCLUDED
|
|
|
|
#include "opal/util/output.h"
|
|
#include "opal/util/printf.h"
|
|
#include "opal_stdint.h"
|
|
#include <stdio.h>
|
|
#include "pml_v.h"
|
|
|
|
BEGIN_C_DECLS
|
|
|
|
int ompi_pml_v_output_open(char *output, int verbosity);
|
|
void ompi_pml_v_output_close(void);
|
|
|
|
static inline void V_OUTPUT_ERR(const char *fmt, ... ) __opal_attribute_format__(__printf__, 1, 2);
|
|
static inline void V_OUTPUT_ERR(const char *fmt, ... )
|
|
{
|
|
va_list list;
|
|
char *str;
|
|
int ret;
|
|
va_start(list, fmt);
|
|
ret = opal_vasprintf(&str, fmt, list);
|
|
assert(-1 != ret);
|
|
(void)ret; // silence compiler warning
|
|
opal_output(0, "%s", str);
|
|
free(str);
|
|
va_end(list);
|
|
}
|
|
|
|
/* Tricky stuff to define V_OUTPUT and V_OUTPUT_VERBOSE with variadic arguments
|
|
*/
|
|
#if defined(ACCEPT_C99)
|
|
# define V_OUTPUT(ARGS...) \
|
|
OPAL_OUTPUT((pml_v_output, __VA_ARGS__))
|
|
# define V_OUTPUT_VERBOSE(V, ARGS...) \
|
|
OPAL_OUTPUT_VERBOSE((V, mca_pml_v.output, __VA_ARGS__))
|
|
|
|
#elif defined(__GNUC__) && !defined(__STDC__)
|
|
# define V_OUTPUT(ARGS...) \
|
|
OPAL_OUTPUT((pml_v_output, ARGS))
|
|
# define V_OUTPUT_VERBOSE(V, ARGS...) \
|
|
OPAL_OUTPUT_VERBOSE((V, mca_pml_v.output, ARGS))
|
|
|
|
#elif OPAL_ENABLE_DEBUG
|
|
/* No variadic macros available... So sad */
|
|
static inline void V_OUTPUT(const char* fmt, ... ) __opal_attribute_format__(__printf__, 1, 2);
|
|
static inline void V_OUTPUT(const char* fmt, ... )
|
|
{
|
|
va_list list;
|
|
char *str;
|
|
int ret;
|
|
va_start(list, fmt);
|
|
ret = opal_vasprintf(&str, fmt, list);
|
|
assert(-1 != ret);
|
|
opal_output(mca_pml_v.output, "%s", str);
|
|
free(str);
|
|
va_end(list);
|
|
}
|
|
static inline void V_OUTPUT_VERBOSE(int V, const char* fmt, ... ) __opal_attribute_format__(__printf__, 2, 3);
|
|
static inline void V_OUTPUT_VERBOSE(int V, const char* fmt, ... ) {
|
|
va_list list;
|
|
char *str;
|
|
int ret;
|
|
va_start(list, fmt);
|
|
ret = opal_vasprintf(&str, fmt, list);
|
|
assert(-1 != ret);
|
|
opal_output_verbose(V, mca_pml_v.output, "%s", str);
|
|
free(str);
|
|
va_end(list);
|
|
}
|
|
|
|
#else /* !DEBUG */
|
|
/* Some compilers complain if we have ... and no corresponding va_start() */
|
|
static inline void V_OUTPUT(const char* fmt, ... ) {
|
|
#if defined(__PGI)
|
|
va_list list;
|
|
va_start(list, fmt);
|
|
va_end(list);
|
|
#endif
|
|
}
|
|
static inline void V_OUTPUT_VERBOSE(int V, const char* fmt, ... ) {
|
|
#if defined(__PGI)
|
|
va_list list;
|
|
va_start(list, fmt);
|
|
va_end(list);
|
|
#endif
|
|
}
|
|
#endif /* DEBUG */
|
|
|
|
END_C_DECLS
|
|
|
|
#endif /* PML_V_OUTPUT_H_HAS_BEEN_INCLUDED */
|