dd82bd3c19
endpoint_rfstart was being initialized from a value which was not yet set. Also ensure that rfstart is a valid index in the range 0..WINDOW_SIZE-1, since it is used as the index into endpoint_rcvd_segs, which has WINDOW_SIZE elements. Without this change there is significant risk of memory corruption or segfaults, resulting in hangs or crashes, if malloc ever returns us a value >=WINDOW_SIZE (4096). Right now we seem to be getting lucky that the malloc is returning zero-pages to us when we are allocating endpoint structures (possibly because the freelist performs a single large allocation for all endpoints). Fixes Cisco bug CSCui88781. Reviewed-by: rfaucett@cisco.com Reviewed-by: jsquyres@cisco.com cmr=v1.7.3:reviewer=jsquyres This commit was SVN r29075. |
||
---|---|---|
.. | ||
btl_usnic_ack.c | ||
btl_usnic_ack.h | ||
btl_usnic_component.c | ||
btl_usnic_endpoint.c | ||
btl_usnic_endpoint.h | ||
btl_usnic_frag.c | ||
btl_usnic_frag.h | ||
btl_usnic_hwloc.c | ||
btl_usnic_hwloc.h | ||
btl_usnic_mca.c | ||
btl_usnic_module.c | ||
btl_usnic_module.h | ||
btl_usnic_proc.c | ||
btl_usnic_proc.h | ||
btl_usnic_recv.c | ||
btl_usnic_recv.h | ||
btl_usnic_send.c | ||
btl_usnic_send.h | ||
btl_usnic_util.c | ||
btl_usnic_util.h | ||
btl_usnic.h | ||
configure.m4 | ||
help-mpi-btl-usnic.txt | ||
Makefile.am | ||
README.txt |
Design notes on usnic BTL ====================================== nomenclature fragment - something the PML asks us to send or put, any size segment - something we can put on the wire in a single packet chunk - a piece of a fragment that fits into one segment a segment can contain either an entire fragment or a chunk of a fragment each segment and fragment has associated descriptor. Each segment data structure has a block of registered memory associated with it which matches MTU for that segment ACK - acks get special small segments with only enough memory for an ACK non-ACK segments always have a parent fragment fragments are either large (> MTU) or small (<= MTU) a small fragment has a segment descriptor embedded within it since it always needs exactly one. a large fragment has no permanently associated segments, but allocates them as needed. ====================================== channels a channel is a queue pair with an associated completion queue each channel has its own MTU and r/w queue entry counts There are 2 channels, command and data command queue is generally for higher priority fragments data queue is for standard data traffic command queue should possibly be called "priority" queue command queue is shorter and has a smaller MTU that the data queue this makes the command queue a lot faster than the data queue, so we hijack it for sending very small fragments (<= tiny_mtu, currently 768 bytes) command queue is used for ACKs and tiny fragments data queue is used for everything else PML fragments marked priority should perhaps use command queue ====================================== sending Normally, all send requests are simply enqueued and then actually posted to the NIC by the routine ompi_btl_usnic_module_progress_sends(). "fastpath" tiny sends are the exception. Each module maintains a queue of endpoints that are ready to send. An endpoint is ready to send if all of the following are met: - the endpoint has fragments to send - the endpoint has send credits - the endpoint's send window is "open" (not full of un-ACKed segments) Each module also maintains a list of segments that need to be retransmitted. Note that the list of pending retrans is per-module, not per-endpoint. send progression first posts any pending retransmissions, always using the data channel. (reason is that if we start getting heavy congestion and there are lots of retransmits, it becomes more important than ever to prioritize ACKs, clogging command channel with retrans data makes things worse, not better) Next, progression loops sending segments to the endpoint at the top of the "endpoints_with_sends" queue. When an endpoint exhausts its send credits or fills its send window or runs out of segments to send, it removes itself from the endpoint_with_sends list. Any pending ACKs will be picked up and piggy-backed on these sends. Finally, any endpoints that still need ACKs whose timer has expired will be sent explicit ACK packets. [double-click fragment sending] The middle part of the progression loop handles both small (single-segment) and large (multi-segment) sends. For small fragments, the verbs descriptor within the embedded segment is updated with length, BTL header is updated, then we call ompi_btl_usnic_endpoint_send_segment() to send the segment. After posting, we make a PML callback if needed. For large fragments, a little more is needed. segments froma large fragment have a slightly larger BTL header which contains a fragment ID, and offset, and a size. The fragment ID is allocated when the first chunk the fragment is sent. A segment gets allocated, next blob of data is copied into this segment, segment is posted. If last chunk of fragment sent, perform callback if needed, then remove fragment from endpoint send queue. [double-click ompi_btl_usnic_endpoint_send_segment()] This is common posting code for large or small segments. It assigns a sequence number to a segment, checks for an ACK to piggy-back, posts the segment to the NIC, and then starts the retransmit timer by checking the segment into hotel. Send credits are consumed here. ====================================== send dataflow PML control messages with no user data are sent via: desc = usnic_alloc(size) usnic_send(desc) user messages less than eager limit and 1st part of larger messages are sent via: desc = usnic_prepare_src(convertor, size) usnic_send(desc) larger msgs desc = usnic_prepare_src(convertor, size) usnic_put(desc) usnic_alloc() currently asserts the length is "small", allocates and fills in a small fragment. src pointer will point to start of associated registered mem + sizeof BTL header, and PML will put its data there. usnic_prepare_src() allocated either a large or small fragment based on size The fragment descriptor is filled in to have 2 SG entries, 1st pointing to place where PML should construct its header. If the data convertor says data is contiguous, 2nd SG entry points to user buffer, else it is null and sf_convertor is filled in with address of convertor. usnic_send() If the fragment being sent is small enough, has contiguous data, and "very few" command queue send WQEs have been consumed, usnic_send() does a fastpath send. This means it posts the segment immediately to the NIC with INLINE flag set. If all of the conditions for fastpath send are not met, and this is a small fragment, the user data is copied into the associated registered memory at this time and the SG list in the descriptor is collapsed to one entry. After the checks above are done, the fragment is enqueued to be sent via ompi_btl_usnic_endpoint_enqueue_frag() usnic_put() PML will have filled in destination address in descriptor. This is saved and the fragment is enqueued for processing. ompi_btl_usnic_endpoint_enqueue_frag() This appends the fragment to the "to be sent" list of the endpoint and conditionally adds the endpoint to the list of endpoints with data to send via ompi_btl_usnic_check_rts() ====================================== receive dataflow BTL packets has one of 3 types in header: frag, chunk, or ack. A frag packet is a full PML fragment. A chunk packet is a piece of a fragment that needs to be reassembled. An ack packet is header only with a sequence number being ACKed. Both frag and chunk packets go through some of the same processing. Both may carry piggy-backed ACKs which may need to be processed. Both have sequence numbers which must be processed and may result in dropping the packet and/or queueing an ACK to the sender. frag packets may be either regular PML fragments or PUT segments. If the "put_addr" field of the BTL header is set, this is a PUT and the data is copied directly to the user buffer. If this field is NULL, the segment is passed up to the PML. The PML is expected to do everything it needs with this packet in the callback, including copying data out if needed. Once the callback is complete, the receive buffer is recycled. chunk packets are parts of a larger fragment. If an active fragment receive for the matching fragment ID cannot be found, and new fragment info descriptor is allocated. If this is not a PUT (put_addr == NULL), we malloc() data to reassemble the fragment into. Each subsequent chunk is copied either into this reassembly buffer or directly into user memory. When the last chunk of a fragment arrives, a PML callback is made for non-PUTs, then the fragment info descriptor is released. ====================================== reliability: every packet has sequence # each endpoint has a "send window" , currently 4096 entries. once a segment is sent, it is saved in window array until ACK is received ACKs acknowledge all packets <= specified sequence # rcvr only ACKs a sequence # when all packets up to that sequence have arrived each pkt has dflt retrans timer of 100ms packet will be scheduled for retrans if timer expires Once a segment is sent, it always has its retransmit timer started. This is accomplished by opal_hotel_checkin() Any time a segment is posted to the NIC for retransmit, it is checked out of the hotel (timer stopped). So, a send segment is always in one of 4 states: - on free list, unallocated - on endpoint to-send list in the case of segment associated with small fragment - posted to NIC and in hotel awaiting ACK - on module re-send list awaiting retransmission rcvr: - if a pkt with seq >= expected seq is received, schedule ack of largest in-order sequence received if not already scheduled. dflt time is 50us - if a packet with seq < expected seq arrives, we send an ACK immediately, as this indicates a lost ACK sender: duplicate ACK triggers immediate retrans if one is not pending for that segment ====================================== Reordering induced by two queues and piggy-backing: ACKs can be reordered- not an issue at all, old ACKs are simply ignored Sends can be reordered- (small send can jump far ahead of large sends) large send followed by lots of small sends could trigger many retrans of the large sends. smalls would have to be paced pretty precisely to keep command queue empty enough and also beat out the large sends. send credits limit how many larges can be queued on the sender, but there could be many on the receiver ====================================== optim: round large buffer alloc up to cache line size? optim: ompi_btl_usnic_endpoint_send_segment() could have stuff removed, moved into shadow of send. ACK piggy-backing could be broken in half, and some moved into shadow. optim: inline ompi_btl_usnic_endpoint_send_segment todo: move small send callback from progress to usnic_send todo: PUTs do not need fragment IDs - each chunk can be standalone, completion is detected on sender by last byte ACKed, not on receiver todo: check warmup impact todo: improve sender lookup mechanism todo: RD WD size weirdness (e.g.:255 good, 256 bad) todo: do not IBV_SEND_SIGNALED every time todo: sf_size redundant with ack_bytes_left ? todo: BW hole in -np 32 Exchange on 32 nodes dip right at eager limit exchange wants different higher limit... todo: odd results with -np 16 Gather -npmin 16 on 16 nodes something changes at 1024 bytes todo: test with packet loss/reording todo: get QA running IMB with .DCHECK todo: do our own 256 process .DCHECK run on 32 nodes todo: registration cache w/o ummunotify todo: reg cache with ummunotify todo: thorough review of retransmission policy vs reordering todo: progression thread? todo: weird startup delay issue with periodic stats enabled todo: maintaining verbs SG list and PML SG list in parallel is awkward probably best to just fill in verbs SG list all at once at last possible moment instead of piecemeal? or always use verbs SG internally? or use compile-time wizardry to make OMPI SG list and verbs SG list be byte compatible? todo: update proc.c:match_modex() to use same kind of IP comparison as in TCP BTL (i.e., subroutine-ize the TCP BTL comparison) todo: implement "wide match" btl_usnic_if_in|exclude (i.e., let a specified mask of 10.0.0.0/8 match an interface with 10.20.0.0/16).