939162ed33
Fixes scoll_basic failures with shmem_verifier, caused by recent changes in handling of zero-size collectives. - Check for zero-size length only for fixed size collect (shmem_fcollect), but not for variable-size collect (shmem_collect) - Add 'nlong_type' parameter to internal broadcast function, to indicate whether the 'nlong' parameter is valid on non-root PEs, since it's used by shmem_collect algorithm. Before this change, some components assumed it's true (scoll_mpi) while others assumed it's false (scoll_basic). - In scoll_basic, if nlong_type==false, do not exit if nlong==0, since this parameter may not be the same on all PEs. - In scoll_mpi, fallback to scoll_basic if nlong_type==false, since MPI requires the 'count' argument of MPI_Bcast to be valid on all ranks. Signed-off-by: Yossi Itigin <yosefe@mellanox.com>
98 строки
3.6 KiB
C
98 строки
3.6 KiB
C
/*
|
|
* Copyright (c) 2013-2018 Mellanox Technologies, Inc.
|
|
* All rights reserved.
|
|
* $COPYRIGHT$
|
|
*
|
|
* Additional copyrights may follow
|
|
*
|
|
* $HEADER$
|
|
*/
|
|
#include "oshmem_config.h"
|
|
|
|
#include "oshmem/constants.h"
|
|
#include "oshmem/include/shmem.h"
|
|
|
|
#include "orte/mca/grpcomm/grpcomm.h"
|
|
|
|
#include "oshmem/runtime/runtime.h"
|
|
|
|
#include "oshmem/mca/scoll/scoll.h"
|
|
|
|
#include "oshmem/proc/proc.h"
|
|
|
|
static void _shmem_broadcast(void *target,
|
|
const void *source,
|
|
size_t nbytes,
|
|
int PE_root,
|
|
int PE_start,
|
|
int logPE_stride,
|
|
int PE_size,
|
|
long *pSync);
|
|
|
|
#define SHMEM_TYPE_BROADCAST(name, element_size) \
|
|
void shmem##name( void *target, \
|
|
const void *source, \
|
|
size_t nelems, \
|
|
int PE_root, \
|
|
int PE_start, \
|
|
int logPE_stride, \
|
|
int PE_size, \
|
|
long *pSync) \
|
|
{ \
|
|
RUNTIME_CHECK_INIT(); \
|
|
RUNTIME_CHECK_ADDR_SIZE(target, nelems); \
|
|
RUNTIME_CHECK_ADDR_SIZE(source, nelems); \
|
|
\
|
|
_shmem_broadcast( target, source, nelems * element_size, \
|
|
PE_root, PE_start, logPE_stride, PE_size, \
|
|
pSync); \
|
|
}
|
|
|
|
static void _shmem_broadcast(void *target,
|
|
const void *source,
|
|
size_t nbytes,
|
|
int PE_root,
|
|
int PE_start,
|
|
int logPE_stride,
|
|
int PE_size,
|
|
long *pSync)
|
|
{
|
|
int rc;
|
|
oshmem_group_t *group;
|
|
|
|
if ((0 <= PE_root) && (PE_root < PE_size)) {
|
|
/* Create group basing PE_start, logPE_stride and PE_size */
|
|
group = oshmem_proc_group_create_nofail(PE_start, 1 << logPE_stride, PE_size);
|
|
if (PE_root >= group->proc_count) {
|
|
rc = OSHMEM_ERROR;
|
|
goto out;
|
|
}
|
|
|
|
/* Define actual PE using relative in active set */
|
|
PE_root = oshmem_proc_pe(group->proc_array[PE_root]);
|
|
|
|
/* Call collective broadcast operation */
|
|
rc = group->g_scoll.scoll_broadcast(group,
|
|
PE_root,
|
|
target,
|
|
source,
|
|
nbytes,
|
|
pSync,
|
|
true,
|
|
SCOLL_DEFAULT_ALG);
|
|
out:
|
|
oshmem_proc_group_destroy(group);
|
|
RUNTIME_CHECK_RC(rc);
|
|
}
|
|
}
|
|
|
|
#if OSHMEM_PROFILING
|
|
#include "oshmem/include/pshmem.h"
|
|
#pragma weak shmem_broadcast32 = pshmem_broadcast32
|
|
#pragma weak shmem_broadcast64 = pshmem_broadcast64
|
|
#include "oshmem/shmem/c/profile/defines.h"
|
|
#endif
|
|
|
|
SHMEM_TYPE_BROADCAST(_broadcast32, sizeof(uint32_t))
|
|
SHMEM_TYPE_BROADCAST(_broadcast64, sizeof(uint64_t))
|