1
1
openmpi/ompi/class/ompi_bitmap.c
Jeff Squyres 33619d6b43 Minor fixes for the ompi_bitmap class that were found while
investivating #817:

 * Remove use of legal_numbits member and always just use the full
   size of the array.  There was a corner case where legal_numbits was
   not an even multiple of the number of bits in the array where bits
   would not get freed properly, ususally causing wasted fortran
   MPI handles, or, as in the case of #817, wasted attribute keyvals
   (i.e., the user freed them, but the bitmap didn't reflect the
   free).
 * Re-order some error checks to ensure that we don't segv (we don't
   currently trigger this problem anywhere; I just noticed it while
   doing the other attribute keyval and legal_numbits work).

Since this change affects all Fortran MPI handles, I ran all the intel
and ibm tests and all still pass with this change.

This commit was SVN r13561.
2007-02-08 18:20:36 +00:00

250 строки
5.5 KiB
C

/*
* Copyright (c) 2004-2005 The Trustees of Indiana University and Indiana
* University Research and Technology
* Corporation. All rights reserved.
* Copyright (c) 2004-2005 The University of Tennessee and The University
* of Tennessee Research Foundation. All rights
* reserved.
* Copyright (c) 2004-2005 High Performance Computing Center Stuttgart,
* University of Stuttgart. All rights reserved.
* Copyright (c) 2004-2005 The Regents of the University of California.
* All rights reserved.
* Copyright (c) 2007 Cisco Systems, Inc. All rights reserved.
* $COPYRIGHT$
*
* Additional copyrights may follow
*
* $HEADER$
*/
#include "ompi_config.h"
#include <stdio.h>
#include "ompi/constants.h"
#include "ompi/class/ompi_bitmap.h"
#define SIZE_OF_CHAR ((int) (sizeof(char) * 8))
static void ompi_bitmap_construct(ompi_bitmap_t *bm);
static void ompi_bitmap_destruct(ompi_bitmap_t *bm);
OBJ_CLASS_INSTANCE(ompi_bitmap_t, opal_object_t,
ompi_bitmap_construct, ompi_bitmap_destruct);
static void
ompi_bitmap_construct(ompi_bitmap_t *bm)
{
bm->array_size = 0;
bm->bitmap = NULL;
}
static void
ompi_bitmap_destruct(ompi_bitmap_t *bm)
{
if (NULL != bm->bitmap) {
free(bm->bitmap);
}
}
int
ompi_bitmap_init(ompi_bitmap_t *bm, int size)
{
int actual_size;
if ((size <= 0) || (size > OMPI_FORTRAN_HANDLE_MAX) || (NULL == bm)) {
return OMPI_ERR_BAD_PARAM;
}
actual_size = size / SIZE_OF_CHAR;
actual_size += (size % SIZE_OF_CHAR == 0) ? 0 : 1;
bm->array_size = actual_size;
bm->bitmap = (unsigned char *) malloc(actual_size);
if (NULL == bm->bitmap) {
return OMPI_ERR_OUT_OF_RESOURCE;
}
ompi_bitmap_clear_all_bits(bm);
return OMPI_SUCCESS;
}
int
ompi_bitmap_set_bit(ompi_bitmap_t *bm, int bit)
{
int index, offset, new_size, i;
size_t new_size_large;
if ((bit < 0) || (bit > OMPI_FORTRAN_HANDLE_MAX) || (NULL == bm)) {
return OMPI_ERR_BAD_PARAM;
}
index = bit / SIZE_OF_CHAR;
offset = bit % SIZE_OF_CHAR;
if (index >= bm->array_size) {
/* If we're already full, return "No vacancy!" */
if (bm->array_size >= OMPI_FORTRAN_HANDLE_MAX) {
return OMPI_ERR_OUT_OF_RESOURCE;
}
/* We need to allocate more space for the bitmap, since we are
out of range. We don't throw any error here, because this is
valid and we simply expand the bitmap */
new_size_large = (index / bm->array_size + 1 ) * bm->array_size;
/* Check to be sure that we still have less than
OMPI_FORTRAN_HANDLE_MAX bits */
if (new_size_large > OMPI_FORTRAN_HANDLE_MAX) {
new_size_large = OMPI_FORTRAN_HANDLE_MAX;
}
/* Note that new_size is guaranteed to be <=
OMPI_FORTRAN_HANDLE_MAX, which is guaranteed to fit in a
[signed] int. */
new_size = (int) new_size_large;
/* New size is just a multiple of the original size to fit in
the index. */
bm->bitmap = (unsigned char *) realloc(bm->bitmap, (int) new_size);
if (NULL == bm->bitmap) {
return OMPI_ERR_OUT_OF_RESOURCE;
}
/* zero out the new elements */
for (i = bm->array_size; i < new_size; ++i) {
bm->bitmap[i] = 0;
}
/* Update the array_size */
bm->array_size = new_size;
}
/* Now set the bit */
bm->bitmap[index] |= (1 << offset);
return OMPI_SUCCESS;
}
int
ompi_bitmap_clear_bit(ompi_bitmap_t *bm, int bit)
{
int index, offset;
if ((bit < 0) || NULL == bm || (bit >= (bm->array_size * SIZE_OF_CHAR))) {
return OMPI_ERR_BAD_PARAM;
}
index = bit / SIZE_OF_CHAR;
offset = bit % SIZE_OF_CHAR;
if (index >= bm->array_size) {
return OMPI_ERR_BAD_PARAM;
}
bm->bitmap[index] &= ~(1 << offset);
return OMPI_SUCCESS;
}
int
ompi_bitmap_is_set_bit(ompi_bitmap_t *bm, int bit)
{
int index, offset;
if ((bit < 0) || NULL == bm || (bit >= (bm->array_size * SIZE_OF_CHAR))) {
return OMPI_ERR_BAD_PARAM;
}
index = bit / SIZE_OF_CHAR;
offset = bit % SIZE_OF_CHAR;
if (index >= bm->array_size) {
return OMPI_ERR_BAD_PARAM;
}
if (0 != (bm->bitmap[index] & (1 << offset))) {
return (int) true;
}
return (int) false;
}
int
ompi_bitmap_clear_all_bits(ompi_bitmap_t *bm)
{
if (NULL == bm) {
return OMPI_ERR_BAD_PARAM;
}
memset(bm->bitmap, 0, bm->array_size);
return OMPI_SUCCESS;
}
int
ompi_bitmap_set_all_bits(ompi_bitmap_t *bm)
{
int i;
if (NULL == bm) {
return OMPI_ERR_BAD_PARAM;
}
for (i = 0; i < bm->array_size; ++i) {
bm->bitmap[i] = ~((char) 0);
}
return OMPI_SUCCESS;
}
int
ompi_bitmap_find_and_set_first_unset_bit(ompi_bitmap_t *bm, int *position)
{
int i = 0;
unsigned char temp;
unsigned char all_ones = 0xff;
if (NULL == bm) {
return OMPI_ERR_BAD_PARAM;
}
/* Neglect all which don't have an unset bit */
*position = 0;
while((i < bm->array_size) && (bm->bitmap[i] == all_ones)) {
++i;
}
if (i == bm->array_size) {
/* increase the bitmap size then */
*position = bm->array_size * SIZE_OF_CHAR;
return ompi_bitmap_set_bit(bm, *position);
}
/* This one has an unset bit, find its bit number */
temp = bm->bitmap[i];
while (temp & 0x1) {
++(*position);
temp >>= 1;
}
/* Now set the bit number */
bm->bitmap[i] |= (bm->bitmap[i] + 1);
(*position) += i * SIZE_OF_CHAR;
return OMPI_SUCCESS;
}