f4af1848c9
As indicated in the MPI3.2 document 14.3.10 page 599 line 1, the only MPI error code possible is MPI_SUCCESS. All other errors must be in the error class MPI_T_ERR*. Fix the return of few pvar/cvar function that failed to correctly convert to an MPI error code. Signed-off-by: George Bosilca <bosilca@icl.utk.edu>
60 строки
1.6 KiB
C
60 строки
1.6 KiB
C
/* -*- Mode: C; c-basic-offset:4 ; indent-tabs-mode:nil -*- */
|
|
/*
|
|
* Copyright (c) 2012-2013 Los Alamos National Security, LLC. All rights
|
|
* reserved.
|
|
* Copyright (c) 2014 Cisco Systems, Inc. All rights reserved.
|
|
* Copyright (c) 2017 IBM Corporation. All rights reserved.
|
|
* Copyright (c) 2020 The University of Tennessee and The University
|
|
* of Tennessee Research Foundation. All rights
|
|
* reserved.
|
|
* $COPYRIGHT$
|
|
*
|
|
* Additional copyrights may follow
|
|
*
|
|
* $HEADER$
|
|
*/
|
|
|
|
#include "ompi/mpi/tool/mpit-internal.h"
|
|
|
|
#if OPAL_HAVE_WEAK_SYMBOLS && OMPI_PROFILING_DEFINES
|
|
#pragma weak MPI_T_pvar_handle_free = PMPI_T_pvar_handle_free
|
|
#endif
|
|
|
|
#if OMPI_PROFILING_DEFINES
|
|
#include "ompi/mpi/tool/profile/defines.h"
|
|
#endif
|
|
|
|
|
|
int MPI_T_pvar_handle_free(MPI_T_pvar_session session, MPI_T_pvar_handle *handle)
|
|
{
|
|
int ret = MPI_SUCCESS;
|
|
|
|
if (!mpit_is_initialized ()) {
|
|
return MPI_T_ERR_NOT_INITIALIZED;
|
|
}
|
|
|
|
ompi_mpit_lock ();
|
|
|
|
do {
|
|
/* Check that this is a valid handle */
|
|
if (MPI_T_PVAR_HANDLE_NULL == *handle ||
|
|
MPI_T_PVAR_ALL_HANDLES == *handle) {
|
|
/* As of MPI 3.0 MPI_T_PVAR_ALL_HANDLES is not a valid handle for
|
|
MPI_T_pvar_handle_free */
|
|
ret = MPI_T_ERR_INVALID_HANDLE;
|
|
break;
|
|
}
|
|
|
|
ret = mca_base_pvar_handle_free (*handle);
|
|
if (OPAL_SUCCESS != ret) {
|
|
ret = MPI_T_ERR_INVALID;
|
|
}
|
|
|
|
*handle = MPI_T_PVAR_HANDLE_NULL;
|
|
} while (0);
|
|
|
|
ompi_mpit_unlock ();
|
|
|
|
return ret;
|
|
}
|