3e2031e0e3
development trees since last year (had to wait for some intel tests to run yesterday, so I finally took the time to finish this work): * Improve MPI API argument checking by also checking for NULL values (especially helps when invalid Fortran MPI handles are passed, because the various MPI_*f2c functions are supposed to return an "invalid" MPI handle [meaning NULL] when this happens). So now OMPI will generate an MPI exception rather than a segv. * Removed a few redundant DATATYPE_NULL checks. * Also check for some other forms of "invalid" handles (e.g., already been freed, etc.) in some cases. We could probably be a bit more stringent in this regard if we really wanted to. * Change MPI_Get_processor_name to zero out the string up to MPI_MAX_PROCESSOR_NAME characters, because the MPI spec says that the string must be at least that long. We were already passing that length to gethostname(), anyway. This commit was SVN r14100.
134 строки
4.5 KiB
C
134 строки
4.5 KiB
C
/*
|
|
* Copyright (c) 2004-2007 The Trustees of Indiana University and Indiana
|
|
* University Research and Technology
|
|
* Corporation. All rights reserved.
|
|
* Copyright (c) 2004-2005 The University of Tennessee and The University
|
|
* of Tennessee Research Foundation. All rights
|
|
* reserved.
|
|
* Copyright (c) 2004-2005 High Performance Computing Center Stuttgart,
|
|
* University of Stuttgart. All rights reserved.
|
|
* Copyright (c) 2004-2005 The Regents of the University of California.
|
|
* All rights reserved.
|
|
* Copyright (c) 2006-2007 Cisco Systems, Inc. All rights reserved.
|
|
* $COPYRIGHT$
|
|
*
|
|
* Additional copyrights may follow
|
|
*
|
|
* $HEADER$
|
|
*/
|
|
#include "ompi_config.h"
|
|
#include <stdio.h>
|
|
|
|
#include "ompi/mpi/c/bindings.h"
|
|
#include "ompi/datatype/datatype.h"
|
|
|
|
#if OMPI_HAVE_WEAK_SYMBOLS && OMPI_PROFILING_DEFINES
|
|
#pragma weak MPI_Gather = PMPI_Gather
|
|
#endif
|
|
|
|
#if OMPI_PROFILING_DEFINES
|
|
#include "ompi/mpi/c/profile/defines.h"
|
|
#endif
|
|
|
|
static const char FUNC_NAME[] = "MPI_Gather";
|
|
|
|
|
|
int MPI_Gather(void *sendbuf, int sendcount, MPI_Datatype sendtype,
|
|
void *recvbuf, int recvcount, MPI_Datatype recvtype,
|
|
int root, MPI_Comm comm)
|
|
{
|
|
int err;
|
|
|
|
OPAL_CR_TEST_CHECKPOINT_READY();
|
|
|
|
if (MPI_PARAM_CHECK) {
|
|
err = MPI_SUCCESS;
|
|
OMPI_ERR_INIT_FINALIZE(FUNC_NAME);
|
|
if (ompi_comm_invalid(comm)) {
|
|
return OMPI_ERRHANDLER_INVOKE(MPI_COMM_WORLD, MPI_ERR_COMM,
|
|
FUNC_NAME);
|
|
} else if ((ompi_comm_rank(comm) != root && MPI_IN_PLACE == sendbuf) ||
|
|
(ompi_comm_rank(comm) == root && MPI_IN_PLACE == recvbuf)) {
|
|
return OMPI_ERRHANDLER_INVOKE(comm, MPI_ERR_ARG, FUNC_NAME);
|
|
}
|
|
|
|
/* Errors for intracommunicators */
|
|
|
|
if (OMPI_COMM_IS_INTRA(comm)) {
|
|
|
|
/* Errors for all ranks */
|
|
|
|
if ((root >= ompi_comm_size(comm)) || (root < 0)) {
|
|
return OMPI_ERRHANDLER_INVOKE(comm, MPI_ERR_ROOT, FUNC_NAME);
|
|
}
|
|
|
|
if (MPI_IN_PLACE != sendbuf) {
|
|
OMPI_CHECK_DATATYPE_FOR_SEND(err, sendtype, sendcount);
|
|
}
|
|
OMPI_ERRHANDLER_CHECK(err, comm, err, FUNC_NAME);
|
|
|
|
/* Errors for the root. Some of these could have been
|
|
combined into compound if statements above, but since
|
|
this whole section can be compiled out (or turned off at
|
|
run time) for efficiency, it's more clear to separate
|
|
them out into individual tests. */
|
|
|
|
if (ompi_comm_rank(comm) == root) {
|
|
if (MPI_DATATYPE_NULL == recvtype || NULL == recvtype) {
|
|
return OMPI_ERRHANDLER_INVOKE(comm, MPI_ERR_TYPE, FUNC_NAME);
|
|
}
|
|
|
|
if (recvcount < 0) {
|
|
return OMPI_ERRHANDLER_INVOKE(comm, MPI_ERR_COUNT, FUNC_NAME);
|
|
}
|
|
}
|
|
}
|
|
|
|
/* Errors for intercommunicators */
|
|
|
|
else {
|
|
if (! ((root >= 0 && root < ompi_comm_remote_size(comm)) ||
|
|
MPI_ROOT == root || MPI_PROC_NULL == root)) {
|
|
return OMPI_ERRHANDLER_INVOKE(comm, MPI_ERR_ROOT, FUNC_NAME);
|
|
}
|
|
|
|
/* Errors for the senders */
|
|
|
|
if (MPI_ROOT != root && MPI_PROC_NULL != root) {
|
|
OMPI_CHECK_DATATYPE_FOR_SEND(err, sendtype, sendcount);
|
|
OMPI_ERRHANDLER_CHECK(err, comm, err, FUNC_NAME);
|
|
}
|
|
|
|
/* Errors for the root. Ditto on the comment above -- these
|
|
error checks could have been combined above, but let's
|
|
make the code easier to read. */
|
|
|
|
else if (MPI_ROOT == root) {
|
|
if (recvcount < 0) {
|
|
return OMPI_ERRHANDLER_INVOKE(comm, MPI_ERR_COUNT, FUNC_NAME);
|
|
}
|
|
|
|
if (MPI_DATATYPE_NULL == recvtype || NULL == recvtype) {
|
|
return OMPI_ERRHANDLER_INVOKE(comm, MPI_ERR_TYPE, FUNC_NAME);
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
/* Do we need to do anything? */
|
|
|
|
if ((0 == sendcount &&
|
|
(ompi_comm_rank(comm) != root ||
|
|
(ompi_comm_rank(comm) == root && MPI_IN_PLACE != sendbuf))) ||
|
|
(ompi_comm_rank(comm) == root && MPI_IN_PLACE == sendbuf &&
|
|
0 == recvcount)) {
|
|
return MPI_SUCCESS;
|
|
}
|
|
|
|
/* Invoke the coll component to perform the back-end operation */
|
|
|
|
err = comm->c_coll.coll_gather(sendbuf, sendcount, sendtype, recvbuf,
|
|
recvcount, recvtype, root, comm);
|
|
OMPI_ERRHANDLER_RETURN(err, comm, err, FUNC_NAME);
|
|
}
|