6b68d1cfc8
The current versions of these functions have a fatal flaw. If a errhandler set and free call is made by another thread while the thread calling get is between the cmpset and retain then we will retain an invalid object. Fixing this by just using locking. This is not a critical path so this should be ok. Signed-off-by: Nathan Hjelm <hjelmn@lanl.gov>
76 строки
2.5 KiB
C
76 строки
2.5 KiB
C
/* -*- Mode: C; c-basic-offset:4 ; indent-tabs-mode:nil -*- */
|
|
/*
|
|
* Copyright (c) 2004-2007 The Trustees of Indiana University and Indiana
|
|
* University Research and Technology
|
|
* Corporation. All rights reserved.
|
|
* Copyright (c) 2004-2005 The University of Tennessee and The University
|
|
* of Tennessee Research Foundation. All rights
|
|
* reserved.
|
|
* Copyright (c) 2004-2005 High Performance Computing Center Stuttgart,
|
|
* University of Stuttgart. All rights reserved.
|
|
* Copyright (c) 2004-2005 The Regents of the University of California.
|
|
* All rights reserved.
|
|
* Copyright (c) 2008 Cisco Systems, Inc. All rights reserved.
|
|
* Copyright (c) 2015 Research Organization for Information Science
|
|
* and Technology (RIST). All rights reserved.
|
|
* Copyright (c) 2016-2017 Los Alamos National Security, LLC. All rights
|
|
* reserved.
|
|
* $COPYRIGHT$
|
|
*
|
|
* Additional copyrights may follow
|
|
*
|
|
* $HEADER$
|
|
*/
|
|
|
|
#include "ompi_config.h"
|
|
|
|
#include "ompi/mpi/c/bindings.h"
|
|
#include "ompi/runtime/params.h"
|
|
#include "ompi/communicator/communicator.h"
|
|
#include "ompi/errhandler/errhandler.h"
|
|
#include "ompi/file/file.h"
|
|
|
|
#if OMPI_BUILD_MPI_PROFILING
|
|
#if OPAL_HAVE_WEAK_SYMBOLS
|
|
#pragma weak MPI_File_get_errhandler = PMPI_File_get_errhandler
|
|
#endif
|
|
#define MPI_File_get_errhandler PMPI_File_get_errhandler
|
|
#endif
|
|
|
|
static const char FUNC_NAME[] = "MPI_File_get_errhandler";
|
|
|
|
|
|
int MPI_File_get_errhandler( MPI_File file, MPI_Errhandler *errhandler)
|
|
{
|
|
OPAL_CR_NOOP_PROGRESS();
|
|
|
|
/* Error checking */
|
|
|
|
if (MPI_PARAM_CHECK) {
|
|
OMPI_ERR_INIT_FINALIZE(FUNC_NAME);
|
|
|
|
/* Note that MPI-2:9.7 (p265 in the ps; 261 in the pdf) explicitly
|
|
says that you are allowed to set the error handler on
|
|
MPI_FILE_NULL */
|
|
|
|
if (NULL == file) {
|
|
return OMPI_ERRHANDLER_INVOKE(MPI_COMM_WORLD, MPI_ERR_FILE,
|
|
"MPI_File_get_errhandler");
|
|
} else if (NULL == errhandler) {
|
|
return OMPI_ERRHANDLER_INVOKE(MPI_COMM_WORLD, MPI_ERR_ARG,
|
|
"MPI_File_get_errhandler");
|
|
}
|
|
}
|
|
|
|
opal_mutex_lock (&file->f_mutex);
|
|
/* Retain the errhandler, corresponding to object refcount
|
|
decrease in errhandler_free.c. */
|
|
*errhandler = file->error_handler;
|
|
OBJ_RETAIN(file->error_handler);
|
|
opal_mutex_unlock (&file->f_mutex);
|
|
|
|
/* All done */
|
|
|
|
return MPI_SUCCESS;
|
|
}
|