6c5532072a
OMPI and a language agnostic part in OPAL. The convertor is completely moved into OPAL. This offers several benefits as described in RFC http://www.open-mpi.org/community/lists/devel/2009/07/6387.php namely: - Fewer basic types (int* and float* types, boolean and wchar - Fixing naming scheme to ompi-nomenclature. - Usability outside of the ompi-layer. - Due to the fixed nature of simple opal types, their information is completely known at compile time and therefore constified - With fewer datatypes (22), the actual sizes of bit-field types may be reduced from 64 to 32 bits, allowing reorganizing the opal_datatype structure, eliminating holes and keeping data required in convertor (upon send/recv) in one cacheline... This has implications to the convertor-datastructure and other parts of the code. - Several performance tests have been run, the netpipe latency does not change with this patch on Linux/x86-64 on the smoky cluster. - Extensive tests have been done to verify correctness (no new regressions) using: 1. mpi_test_suite on linux/x86-64 using clean ompi-trunk and ompi-ddt: a. running both trunk and ompi-ddt resulted in no differences (except for MPI_SHORT_INT and MPI_TYPE_MIX_LB_UB do now run correctly). b. with --enable-memchecker and running under valgrind (one buglet when run with static found in test-suite, commited) 2. ibm testsuite on linux/x86-64 using clean ompi-trunk and ompi-ddt: all passed (except for the dynamic/ tests failed!! as trunk/MTT) 3. compilation and usage of HDF5 tests on Jaguar using PGI and PathScale compilers. 4. compilation and usage on Scicortex. - Please note, that for the heterogeneous case, (-m32 compiled binaries/ompi), neither ompi-trunk, nor ompi-ddt branch would successfully launch. This commit was SVN r21641.
103 строки
3.7 KiB
C
103 строки
3.7 KiB
C
/* -*- Mode: C; c-basic-offset:4 ; -*- */
|
|
|
|
/*
|
|
* Copyright (c) 2004-2007 The Trustees of Indiana University and Indiana
|
|
* University Research and Technology
|
|
* Corporation. All rights reserved.
|
|
* Copyright (c) 2004-2005 The University of Tennessee and The University
|
|
* of Tennessee Research Foundation. All rights
|
|
* reserved.
|
|
* Copyright (c) 2004-2008 High Performance Computing Center Stuttgart,
|
|
* University of Stuttgart. All rights reserved.
|
|
* Copyright (c) 2004-2005 The Regents of the University of California.
|
|
* All rights reserved.
|
|
* Copyright (c) 2006 Cisco Systems, Inc. All rights reserved.
|
|
* $COPYRIGHT$
|
|
*
|
|
* Additional copyrights may follow
|
|
*
|
|
* $HEADER$
|
|
*/
|
|
#include "ompi_config.h"
|
|
#include <stdio.h>
|
|
|
|
#include "ompi/mpi/c/bindings.h"
|
|
#include "ompi/runtime/params.h"
|
|
#include "ompi/communicator/communicator.h"
|
|
#include "ompi/errhandler/errhandler.h"
|
|
#include "ompi/datatype/ompi_datatype.h"
|
|
#include "opal/datatype/opal_convertor.h"
|
|
#include "ompi/memchecker.h"
|
|
|
|
#if OPAL_HAVE_WEAK_SYMBOLS && OMPI_PROFILING_DEFINES
|
|
#pragma weak MPI_Pack = PMPI_Pack
|
|
#endif
|
|
|
|
#if OMPI_PROFILING_DEFINES
|
|
#include "ompi/mpi/c/profile/defines.h"
|
|
#endif
|
|
|
|
static const char FUNC_NAME[] = "MPI_Pack";
|
|
|
|
|
|
int MPI_Pack(void *inbuf, int incount, MPI_Datatype datatype,
|
|
void *outbuf, int outsize, int *position, MPI_Comm comm)
|
|
{
|
|
int rc;
|
|
opal_convertor_t local_convertor;
|
|
struct iovec invec;
|
|
unsigned int iov_count;
|
|
size_t size;
|
|
|
|
MEMCHECKER(
|
|
memchecker_datatype(datatype);
|
|
memchecker_call(&opal_memchecker_base_isdefined, inbuf, incount, datatype);
|
|
memchecker_comm(comm);
|
|
);
|
|
|
|
if (MPI_PARAM_CHECK) {
|
|
OMPI_ERR_INIT_FINALIZE(FUNC_NAME);
|
|
if (ompi_comm_invalid(comm)) {
|
|
return OMPI_ERRHANDLER_INVOKE(MPI_COMM_WORLD, MPI_ERR_COMM, FUNC_NAME);
|
|
} else if ((NULL == outbuf) || (NULL == position)) { /* inbuf can be MPI_BOTTOM */
|
|
return OMPI_ERRHANDLER_INVOKE(comm, MPI_ERR_ARG, FUNC_NAME);
|
|
} else if (incount < 0) {
|
|
return OMPI_ERRHANDLER_INVOKE(comm, MPI_ERR_COUNT, FUNC_NAME);
|
|
} else if (outsize < 0) {
|
|
return OMPI_ERRHANDLER_INVOKE(comm, MPI_ERR_ARG, FUNC_NAME);
|
|
} else if (MPI_DATATYPE_NULL == datatype || NULL == datatype) {
|
|
return OMPI_ERRHANDLER_INVOKE(comm, MPI_ERR_TYPE, FUNC_NAME);
|
|
}
|
|
}
|
|
|
|
OPAL_CR_ENTER_LIBRARY();
|
|
|
|
OBJ_CONSTRUCT( &local_convertor, opal_convertor_t );
|
|
/* the resulting convertor will be set to the position ZERO */
|
|
opal_convertor_copy_and_prepare_for_send( ompi_mpi_local_convertor, &(datatype->super),
|
|
incount, inbuf, 0, &local_convertor );
|
|
|
|
/* Check for truncation */
|
|
opal_convertor_get_packed_size( &local_convertor, &size );
|
|
if( (*position + size) > (unsigned int)outsize ) { /* we can cast as we already checked for < 0 */
|
|
OBJ_DESTRUCT( &local_convertor );
|
|
OPAL_CR_EXIT_LIBRARY();
|
|
return OMPI_ERRHANDLER_INVOKE(comm, MPI_ERR_TRUNCATE, FUNC_NAME);
|
|
}
|
|
|
|
/* Prepare the iovec with all informations */
|
|
invec.iov_base = (char*) outbuf + (*position);
|
|
invec.iov_len = size;
|
|
|
|
/* Do the actual packing */
|
|
iov_count = 1;
|
|
rc = opal_convertor_pack( &local_convertor, &invec, &iov_count, &size );
|
|
*position += size;
|
|
OBJ_DESTRUCT( &local_convertor );
|
|
|
|
/* All done. Note that the convertor returns 1 upon success, not
|
|
OMPI_SUCCESS. */
|
|
OMPI_ERRHANDLER_RETURN((rc == 1) ? OMPI_SUCCESS : OMPI_ERROR,
|
|
comm, MPI_ERR_UNKNOWN, FUNC_NAME);
|
|
}
|