27fecda12c
be applied. Correct the MPI validation process of the MPI_Accumulate arguments. Fix another potential problem not yet reported. If we convert the MPI datatypes direclty into OPAL datatypes, we will restrict their number to the locally different types. Which might not be identical on the remote node, if we are in a heterogeneous environment. So, for MPI One sided only deal with MPI level types, never simplify them on OPAL types (at least on the args). The unfortunate outcome is that we need to create the args for all datatypes. This commit was SVN r24466.
138 строки
5.7 KiB
C
138 строки
5.7 KiB
C
/*
|
|
* Copyright (c) 2004-2007 The Trustees of Indiana University and Indiana
|
|
* University Research and Technology
|
|
* Corporation. All rights reserved.
|
|
* Copyright (c) 2004-2005 The University of Tennessee and The University
|
|
* of Tennessee Research Foundation. All rights
|
|
* reserved.
|
|
* Copyright (c) 2004-2008 High Performance Computing Center Stuttgart,
|
|
* University of Stuttgart. All rights reserved.
|
|
* Copyright (c) 2004-2005 The Regents of the University of California.
|
|
* All rights reserved.
|
|
* Copyright (c) 2009 Sun Microsystmes, Inc. All rights reserved.
|
|
* $COPYRIGHT$
|
|
*
|
|
* Additional copyrights may follow
|
|
*
|
|
* $HEADER$
|
|
*/
|
|
#include "ompi_config.h"
|
|
#include <stdio.h>
|
|
#include "ompi/mpi/c/bindings.h"
|
|
#include "ompi/runtime/params.h"
|
|
#include "ompi/communicator/communicator.h"
|
|
#include "ompi/errhandler/errhandler.h"
|
|
#include "ompi/win/win.h"
|
|
#include "ompi/mca/osc/osc.h"
|
|
#include "ompi/op/op.h"
|
|
#include "ompi/datatype/ompi_datatype.h"
|
|
#include "ompi/datatype/ompi_datatype_internal.h"
|
|
#include "ompi/memchecker.h"
|
|
|
|
#if OPAL_HAVE_WEAK_SYMBOLS && OMPI_PROFILING_DEFINES
|
|
#pragma weak MPI_Accumulate = PMPI_Accumulate
|
|
#endif
|
|
|
|
#if OMPI_PROFILING_DEFINES
|
|
#include "ompi/mpi/c/profile/defines.h"
|
|
#endif
|
|
|
|
static const char FUNC_NAME[] = "MPI_Accumlate";
|
|
|
|
int MPI_Accumulate(void *origin_addr, int origin_count, MPI_Datatype origin_datatype,
|
|
int target_rank, MPI_Aint target_disp, int target_count,
|
|
MPI_Datatype target_datatype, MPI_Op op, MPI_Win win)
|
|
{
|
|
int rc;
|
|
ompi_win_t *ompi_win = (ompi_win_t*) win;
|
|
|
|
MEMCHECKER(
|
|
memchecker_datatype(origin_datatype);
|
|
memchecker_datatype(target_datatype);
|
|
memchecker_call(&opal_memchecker_base_isdefined, origin_addr, origin_count, origin_datatype);
|
|
);
|
|
|
|
if (MPI_PARAM_CHECK) {
|
|
rc = OMPI_SUCCESS;
|
|
|
|
OMPI_ERR_INIT_FINALIZE(FUNC_NAME);
|
|
|
|
if (ompi_win_invalid(win)) {
|
|
return OMPI_ERRHANDLER_INVOKE(MPI_COMM_WORLD, MPI_ERR_WIN, FUNC_NAME);
|
|
} else if (origin_count < 0 || target_count < 0) {
|
|
rc = MPI_ERR_COUNT;
|
|
} else if (ompi_win_peer_invalid(win, target_rank) &&
|
|
(MPI_PROC_NULL != target_rank)) {
|
|
rc = MPI_ERR_RANK;
|
|
} else if (MPI_OP_NULL == op) {
|
|
rc = MPI_ERR_OP;
|
|
} else if (!ompi_op_is_intrinsic(op)) {
|
|
rc = MPI_ERR_OP;
|
|
} else if (!ompi_win_comm_allowed(win)) {
|
|
rc = MPI_ERR_RMA_SYNC;
|
|
} else if ( target_disp < 0 ) {
|
|
rc = MPI_ERR_DISP;
|
|
} else {
|
|
OMPI_CHECK_DATATYPE_FOR_ONE_SIDED(rc, origin_datatype, origin_count);
|
|
if (OMPI_SUCCESS == rc) {
|
|
OMPI_CHECK_DATATYPE_FOR_ONE_SIDED(rc, target_datatype, target_count);
|
|
}
|
|
if (OMPI_SUCCESS == rc) {
|
|
/* While technically the standard probably requires that the
|
|
datatypes used with MPI_REPLACE conform to all the rules
|
|
for other reduction operators, we don't require such
|
|
behavior, as checking for it is expensive here and we don't
|
|
care in implementation.. */
|
|
if (op != &ompi_mpi_op_replace.op) {
|
|
ompi_datatype_t *op_check_dt, *origin_check_dt;
|
|
char *msg;
|
|
|
|
/* ACCUMULATE, unlike REDUCE, can use with derived
|
|
datatypes with predefinied operations, with some
|
|
restrictions outlined in MPI-2:6.3.4. The derived
|
|
datatype must be composed entierly from one predefined
|
|
datatype (so you can do all the construction you want,
|
|
but at the bottom, you can only use one datatype, say,
|
|
MPI_INT). If the datatype at the target isn't
|
|
predefined, then make sure it's composed of only one
|
|
datatype, and check that datatype against
|
|
ompi_op_is_valid(). */
|
|
origin_check_dt = ompi_datatype_get_single_predefined_type_from_args(origin_datatype);
|
|
op_check_dt = ompi_datatype_get_single_predefined_type_from_args(target_datatype);
|
|
|
|
if( !((origin_check_dt == op_check_dt) & (NULL != op_check_dt)) ) {
|
|
OMPI_ERRHANDLER_RETURN(MPI_ERR_ARG, win, MPI_ERR_ARG, FUNC_NAME);
|
|
}
|
|
|
|
/* check to make sure primitive type is valid for
|
|
reduction. Should do this on the target, but
|
|
then can't get the errcode back for this
|
|
call */
|
|
if (!ompi_op_is_valid(op, op_check_dt, &msg, FUNC_NAME)) {
|
|
int ret = OMPI_ERRHANDLER_INVOKE(win, MPI_ERR_OP, msg);
|
|
free(msg);
|
|
return ret;
|
|
}
|
|
}
|
|
}
|
|
}
|
|
OMPI_ERRHANDLER_CHECK(rc, win, rc, FUNC_NAME);
|
|
}
|
|
|
|
if (MPI_PROC_NULL == target_rank) {
|
|
return MPI_SUCCESS;
|
|
}
|
|
|
|
OPAL_CR_ENTER_LIBRARY();
|
|
|
|
rc = ompi_win->w_osc_module->osc_accumulate(origin_addr,
|
|
origin_count,
|
|
origin_datatype,
|
|
target_rank,
|
|
target_disp,
|
|
target_count,
|
|
target_datatype,
|
|
op, win);
|
|
OMPI_ERRHANDLER_RETURN(rc, win, rc, FUNC_NAME);
|
|
}
|