9e56ef0da9
CID 70622 Dereference before null check (REVERSE_INULL) CID 70459 Logically dead code (DEADCODE) Cleanup some cludgy code which (among other things) reimplemented strcat, strdup, and strchr. In the process this resolved two outstanding coverity issues. CID 70631 Dereference before null check (REVERSE_INULL) best_module can not be NULL in this code path. Remove NULL check and unnecessary goto statements. Signed-off-by: Nathan Hjelm <hjelmn@lanl.gov>
79 строки
2.4 KiB
C
79 строки
2.4 KiB
C
/* -*- Mode: C; c-basic-offset:4 ; indent-tabs-mode:nil -*- */
|
|
/*
|
|
* Copyright (c) 2004-2010 The Trustees of Indiana University.
|
|
* All rights reserved.
|
|
* Copyright (c) 2004-2005 The Trustees of the University of Tennessee.
|
|
* All rights reserved.
|
|
* Copyright (c) 2004-2005 High Performance Computing Center Stuttgart,
|
|
* University of Stuttgart. All rights reserved.
|
|
* Copyright (c) 2004-2005 The Regents of the University of California.
|
|
* All rights reserved.
|
|
* Copyright (c) 2007 Evergrid, Inc. All rights reserved.
|
|
* Copyright (c) 2015 Los Alamos National Security, LLC. All rights
|
|
* reserved.
|
|
*
|
|
* $COPYRIGHT$
|
|
*
|
|
* Additional copyrights may follow
|
|
*
|
|
* $HEADER$
|
|
*/
|
|
|
|
#include "opal_config.h"
|
|
|
|
#ifdef HAVE_UNISTD_H
|
|
#include "unistd.h"
|
|
#endif
|
|
|
|
#include "opal/constants.h"
|
|
#include "opal/util/output.h"
|
|
#include "opal/mca/mca.h"
|
|
#include "opal/mca/base/base.h"
|
|
#include "opal/mca/crs/crs.h"
|
|
#include "opal/mca/crs/base/base.h"
|
|
|
|
bool opal_crs_base_do_not_select = false;
|
|
|
|
int opal_crs_base_select(void)
|
|
{
|
|
opal_crs_base_component_t *best_component = NULL;
|
|
opal_crs_base_module_t *best_module = NULL;
|
|
int ret;
|
|
|
|
if( !opal_cr_is_enabled ) {
|
|
opal_output_verbose(10, opal_crs_base_framework.framework_output,
|
|
"crs:select: FT is not enabled, skipping!");
|
|
return OPAL_SUCCESS;
|
|
}
|
|
|
|
if( opal_crs_base_do_not_select ) {
|
|
opal_output_verbose(10, opal_crs_base_framework.framework_output,
|
|
"crs:select: Not selecting at this time!");
|
|
return OPAL_SUCCESS;
|
|
}
|
|
|
|
/*
|
|
* Select the best component
|
|
*/
|
|
if( OPAL_SUCCESS != mca_base_select("crs", opal_crs_base_framework.framework_output,
|
|
&opal_crs_base_framework.framework_components,
|
|
(mca_base_module_t **) &best_module,
|
|
(mca_base_component_t **) &best_component) ) {
|
|
/* This will only happen if no component was selected */
|
|
return OPAL_ERROR;
|
|
}
|
|
|
|
/* best_module and best_component should not be NULL here */
|
|
|
|
/* Save the winner */
|
|
opal_crs_base_selected_component = *best_component;
|
|
opal_crs = *best_module;
|
|
|
|
/* Initialize the winner */
|
|
if (OPAL_SUCCESS != (ret = opal_crs.crs_init()) ) {
|
|
return ret;
|
|
}
|
|
|
|
return OPAL_SUCCESS;
|
|
}
|