1
1
openmpi/ompi/mpi/cxx
Jeff Squyres 0a28212392 This is a workaround to bug in the Intel C++ compiler, version 9.1
(all versions up to and including 20060925).  The issue has been
reported to Intel, along with a small [non-MPI] test program that
reproduces the problem (the test program and the OMPI C++ bindings
work fine with Intel C++ 9.0 and many other C++ compilers).

In short, a static initializer for a global variable (i.e., its
constructor is fired before main()) that takes as an argument a
reference to a typedef'd type will simply get the wrong value in the
argument.  Specifically:

{{{
namespace MPI {
    Intracomm COMM_WORLD(MPI_COMM_WORLD);
}
}}}

The constructor for MPI::Intracomm should get the value of
&ompi_mpi_comm_world.  It does not; it seems to get a random value.

As mandated by MPI-2, annex B.13.4, for C/C++ interoperability, the
prototype for this constructor is:

{{{
class Intracomm {
public:
    Intracomm(const MPI_Comm& data);
};
}}}

Experiments with icpc 9.1/20060925 have shown that removing the
reference from the prototype makes it work (!).  After lots of
discussions about this issue with a C++ expert (Doug Gregor from IU),
we decided the following (cut-n-paste from an e-mail):

-----
> So here's my question: given that OMPI's MPI_<CLASS> types are all
> pointers, is there any legal MPI program that adheres to the above
> bindings that would fail to compile or work properly if we simply
> removed the "&" from the second binding, above?

I don't know of any way that a program could detect this change. FWIW,
the C++ committee has agreed that implementation of the C++ standard
library are allowed to decide arbitrarily between const& and by-value.
If they don't care, MPI users won't care.

When you remove the '&', I suggest also removing the "const". It is
redundant, but can trigger some strange name mangling in Sun's C++
compiler.
-----

So with this change:

 * we now work again with the Intel 9.1 compiler
 * our C++ bindings do not exactly conform to the MPI-2 spec, but
   valid/legal MPI C++ apps cannot tell the difference (i.e., the
   functionality is the same)

This commit was SVN r12514.
2006-11-09 17:34:12 +00:00
..
comm_inln.h The bool type on Windows is not an integer. Therefore just casting an 2006-08-28 18:51:09 +00:00
comm.cc Next step in the project split, mainly source code re-arranging 2006-02-12 01:33:29 +00:00
comm.h This is a workaround to bug in the Intel C++ compiler, version 9.1 2006-11-09 17:34:12 +00:00
constants.h Implement MPI::SEEK_{SET, END, POS} for the C++ bindings, working around 2006-10-15 23:50:24 +00:00
datatype_inln.h The bool type on Windows is not an integer. Therefore just casting an 2006-08-28 18:51:09 +00:00
datatype.h This is a workaround to bug in the Intel C++ compiler, version 9.1 2006-11-09 17:34:12 +00:00
errhandler_inln.h Update the copyright notices for IU and UTK. 2005-11-05 19:57:48 +00:00
errhandler.h This is a workaround to bug in the Intel C++ compiler, version 9.1 2006-11-09 17:34:12 +00:00
exception.h Update the copyright notices for IU and UTK. 2005-11-05 19:57:48 +00:00
file_inln.h The bool type on Windows is not an integer. Therefore just casting an 2006-08-28 18:51:09 +00:00
file.h This is a workaround to bug in the Intel C++ compiler, version 9.1 2006-11-09 17:34:12 +00:00
functions_inln.h The bool type on Windows is not an integer. Therefore just casting an 2006-08-28 18:51:09 +00:00
functions.h * implement missing MPI::Is_finalized() function 2006-06-22 19:40:54 +00:00
group_inln.h It appears that most versions of the IBM XL compiler (including the latest 2006-08-19 22:55:59 +00:00
group.h This is a workaround to bug in the Intel C++ compiler, version 9.1 2006-11-09 17:34:12 +00:00
info_inln.h The bool type on Windows is not an integer. Therefore just casting an 2006-08-28 18:51:09 +00:00
info.h This is a workaround to bug in the Intel C++ compiler, version 9.1 2006-11-09 17:34:12 +00:00
intercepts.cc Fixes trac:580 2006-11-06 18:42:00 +00:00
intercomm_inln.h Since all of the collectives (except scan and exscan) are defined on 2005-12-21 21:12:52 +00:00
intercomm.h This is a workaround to bug in the Intel C++ compiler, version 9.1 2006-11-09 17:34:12 +00:00
intracomm_inln.h This is a workaround to bug in the Intel C++ compiler, version 9.1 2006-11-09 17:34:12 +00:00
intracomm.h This is a workaround to bug in the Intel C++ compiler, version 9.1 2006-11-09 17:34:12 +00:00
Makefile.am Update the copyright notices for IU and UTK. 2005-11-05 19:57:48 +00:00
mpicxx.cc Implement MPI::SEEK_{SET, END, POS} for the C++ bindings, working around 2006-10-15 23:50:24 +00:00
mpicxx.h Fixes trac:580 2006-11-06 18:42:00 +00:00
op_inln.h This is a workaround to bug in the Intel C++ compiler, version 9.1 2006-11-09 17:34:12 +00:00
op.h This is a workaround to bug in the Intel C++ compiler, version 9.1 2006-11-09 17:34:12 +00:00
request_inln.h Fixes trac:580 2006-11-06 18:42:00 +00:00
request.h This is a workaround to bug in the Intel C++ compiler, version 9.1 2006-11-09 17:34:12 +00:00
status_inln.h After review with Rolf, decided to be a bit more safe and instead of 2006-11-07 20:49:31 +00:00
status.h Fixes trac:580 2006-11-06 18:42:00 +00:00
topology_inln.h The bool type on Windows is not an integer. Therefore just casting an 2006-08-28 18:51:09 +00:00
topology.h Update the copyright notices for IU and UTK. 2005-11-05 19:57:48 +00:00
win_inln.h The bool type on Windows is not an integer. Therefore just casting an 2006-08-28 18:51:09 +00:00
win.h This is a workaround to bug in the Intel C++ compiler, version 9.1 2006-11-09 17:34:12 +00:00