6c5532072a
OMPI and a language agnostic part in OPAL. The convertor is completely moved into OPAL. This offers several benefits as described in RFC http://www.open-mpi.org/community/lists/devel/2009/07/6387.php namely: - Fewer basic types (int* and float* types, boolean and wchar - Fixing naming scheme to ompi-nomenclature. - Usability outside of the ompi-layer. - Due to the fixed nature of simple opal types, their information is completely known at compile time and therefore constified - With fewer datatypes (22), the actual sizes of bit-field types may be reduced from 64 to 32 bits, allowing reorganizing the opal_datatype structure, eliminating holes and keeping data required in convertor (upon send/recv) in one cacheline... This has implications to the convertor-datastructure and other parts of the code. - Several performance tests have been run, the netpipe latency does not change with this patch on Linux/x86-64 on the smoky cluster. - Extensive tests have been done to verify correctness (no new regressions) using: 1. mpi_test_suite on linux/x86-64 using clean ompi-trunk and ompi-ddt: a. running both trunk and ompi-ddt resulted in no differences (except for MPI_SHORT_INT and MPI_TYPE_MIX_LB_UB do now run correctly). b. with --enable-memchecker and running under valgrind (one buglet when run with static found in test-suite, commited) 2. ibm testsuite on linux/x86-64 using clean ompi-trunk and ompi-ddt: all passed (except for the dynamic/ tests failed!! as trunk/MTT) 3. compilation and usage of HDF5 tests on Jaguar using PGI and PathScale compilers. 4. compilation and usage on Scicortex. - Please note, that for the heterogeneous case, (-m32 compiled binaries/ompi), neither ompi-trunk, nor ompi-ddt branch would successfully launch. This commit was SVN r21641.
160 строки
6.0 KiB
C
160 строки
6.0 KiB
C
/*
|
|
* Copyright (c) 2004-2005 The Trustees of Indiana University and Indiana
|
|
* University Research and Technology
|
|
* Corporation. All rights reserved.
|
|
* Copyright (c) 2004-2009 The University of Tennessee and The University
|
|
* of Tennessee Research Foundation. All rights
|
|
* reserved.
|
|
* Copyright (c) 2004-2005 High Performance Computing Center Stuttgart,
|
|
* University of Stuttgart. All rights reserved.
|
|
* Copyright (c) 2004-2005 The Regents of the University of California.
|
|
* All rights reserved.
|
|
* $COPYRIGHT$
|
|
*
|
|
* Additional copyrights may follow
|
|
*
|
|
* $HEADER$
|
|
*/
|
|
|
|
#include "ompi_config.h"
|
|
#include "coll_tuned.h"
|
|
|
|
#include "mpi.h"
|
|
#include "ompi/constants.h"
|
|
#include "ompi/datatype/ompi_datatype.h"
|
|
#include "ompi/communicator/communicator.h"
|
|
#include "ompi/mca/coll/base/coll_tags.h"
|
|
#include "ompi/mca/pml/pml.h"
|
|
#include "coll_tuned_util.h"
|
|
|
|
int ompi_coll_tuned_sendrecv_actual( void* sendbuf, int scount,
|
|
ompi_datatype_t* sdatatype,
|
|
int dest, int stag,
|
|
void* recvbuf, int rcount,
|
|
ompi_datatype_t* rdatatype,
|
|
int source, int rtag,
|
|
struct ompi_communicator_t* comm,
|
|
ompi_status_public_t* status )
|
|
|
|
{ /* post receive first, then send, then waitall... should be fast (I hope) */
|
|
int err, line = 0;
|
|
ompi_request_t* reqs[2];
|
|
ompi_status_public_t statuses[2];
|
|
|
|
/* post new irecv */
|
|
err = MCA_PML_CALL(irecv( recvbuf, rcount, rdatatype, source, rtag,
|
|
comm, &reqs[0]));
|
|
if (err != MPI_SUCCESS) { line = __LINE__; goto error_handler; }
|
|
|
|
/* send data to children */
|
|
err = MCA_PML_CALL(isend( sendbuf, scount, sdatatype, dest, stag,
|
|
MCA_PML_BASE_SEND_STANDARD, comm, &reqs[1]));
|
|
if (err != MPI_SUCCESS) { line = __LINE__; goto error_handler; }
|
|
|
|
err = ompi_request_wait_all( 2, reqs, statuses );
|
|
if (err != MPI_SUCCESS) { line = __LINE__; goto error_handler_waitall; }
|
|
|
|
if (MPI_STATUS_IGNORE != status) {
|
|
*status = statuses[0];
|
|
}
|
|
|
|
return (MPI_SUCCESS);
|
|
|
|
error_handler_waitall:
|
|
/* As we use wait_all we will get MPI_ERR_IN_STATUS which is not an error
|
|
* code that we can propagate up the stack. Instead, look for the real
|
|
* error code from the MPI_ERROR in the status.
|
|
*/
|
|
if( MPI_ERR_IN_STATUS == err ) {
|
|
/* At least we know he error was detected during the wait_all */
|
|
int err_index = 0;
|
|
if( MPI_SUCCESS != statuses[1].MPI_ERROR ) {
|
|
err_index = 1;
|
|
}
|
|
if (MPI_STATUS_IGNORE != status) {
|
|
*status = statuses[err_index];
|
|
}
|
|
err = statuses[err_index].MPI_ERROR;
|
|
OPAL_OUTPUT ((ompi_coll_tuned_stream, "%s:%d: Error %d occurred (req index %d)\n",
|
|
__FILE__, line, err, err_index));
|
|
} else {
|
|
error_handler:
|
|
/* Error discovered during the posting of the irecv or isend,
|
|
* and no status is available.
|
|
*/
|
|
OPAL_OUTPUT ((ompi_coll_tuned_stream, "%s:%d: Error %d occurred\n",
|
|
__FILE__, line, err));
|
|
if (MPI_STATUS_IGNORE != status) {
|
|
status->MPI_ERROR = err;
|
|
}
|
|
}
|
|
return (err);
|
|
}
|
|
|
|
/*
|
|
* localcompleted version that makes sure the send has completed locally
|
|
* Currently this is a sync call, but will change to locally completed
|
|
* version when available
|
|
*/
|
|
|
|
int ompi_coll_tuned_sendrecv_actual_localcompleted( void* sendbuf, int scount,
|
|
ompi_datatype_t* sdatatype,
|
|
int dest, int stag,
|
|
void* recvbuf, int rcount,
|
|
ompi_datatype_t* rdatatype,
|
|
int source, int rtag,
|
|
struct ompi_communicator_t* comm,
|
|
ompi_status_public_t* status )
|
|
|
|
{ /* post receive first, then [local] sync send, then wait... should be fast (I hope) */
|
|
int err, line = 0;
|
|
ompi_request_t* req[2];
|
|
ompi_status_public_t statuses[2];
|
|
|
|
/* post new irecv */
|
|
err = MCA_PML_CALL(irecv( recvbuf, rcount, rdatatype, source, rtag,
|
|
comm, &(req[0])));
|
|
if (err != MPI_SUCCESS) { line = __LINE__; goto error_handler; }
|
|
|
|
/* send data to children */
|
|
err = MCA_PML_CALL(isend( sendbuf, scount, sdatatype, dest, stag,
|
|
MCA_PML_BASE_SEND_SYNCHRONOUS, comm, &(req[1])));
|
|
if (err != MPI_SUCCESS) { line = __LINE__; goto error_handler; }
|
|
|
|
err = ompi_request_wait_all( 2, req, statuses );
|
|
if (err != MPI_SUCCESS) { line = __LINE__; goto error_handler; }
|
|
|
|
if (MPI_STATUS_IGNORE != status) {
|
|
*status = statuses[0];
|
|
}
|
|
|
|
return (MPI_SUCCESS);
|
|
|
|
error_handler:
|
|
/* As we use wait_all we will get MPI_ERR_IN_STATUS which is not an error
|
|
* code that we can propagate up the stack. Instead, look for the real
|
|
* error code from the MPI_ERROR in the status.
|
|
*/
|
|
if( MPI_ERR_IN_STATUS == err ) {
|
|
int err_index = 0;
|
|
if( MPI_SUCCESS != statuses[1].MPI_ERROR ) {
|
|
err_index = 1;
|
|
}
|
|
if (MPI_STATUS_IGNORE != status) {
|
|
*status = statuses[err_index];
|
|
}
|
|
err = statuses[err_index].MPI_ERROR;
|
|
OPAL_OUTPUT ((ompi_coll_tuned_stream, "%s:%d: Error %d occurred (req index %d)\n",
|
|
__FILE__,line,err, err_index));
|
|
} else {
|
|
OPAL_OUTPUT ((ompi_coll_tuned_stream, "%s:%d: Error %d occurred\n",
|
|
__FILE__,line,err));
|
|
if (MPI_STATUS_IGNORE != status) {
|
|
status->MPI_ERROR = err;
|
|
}
|
|
}
|
|
|
|
return (err);
|
|
}
|
|
|