1
1
openmpi/ompi/mca/coll
Jeff Squyres 533633b8cb Fixes trac:1988. The little bug that turned out to be huge. Yoinks.
* Various cosmetic/style updates in the btl sm
 * Clean up concept of mpool module (I think that code was written way
   back when the concept of "modules" was fuzzy)
 * Bring over some old fixes from the /tmp/timattox-sm-coll/ tree to
   fix potential segv's when mmap'ed regions were at different
   addresses in different processes (thanks Tim!).
 * Change sm coll to no longer use mpool as its main source of shmem;
   rather, just mmap its own segment (because it's fixed size --
   there was nothing to be gained by using mpool; shedding the use of
   mpool saved a lot of complexity in the sm coll setup).  This
   effectively made Tim's fixes moot (because now everything is an
   offset into the mmap that is computed locally; there are no global
   pointers).  :-)
 * Slightly updated common/sm to allow making mmap's for a specific
   set of procs (vs. ''all'' procs in the process).  This potentially
   allows for same-host-inter-proc mmaps -- yay!
 * Fixed many, many things in the coll sm (particularly in reduce):
   * Fixed handling of MPI_IN_PLACE in reduce and allreduce
   * Fixed handling of non-contiguous datatypes in reduce
   * Changed the order of reductions to go from process (n-1)'s data
     to process 0's data, because that's how all other OMPI coll
     components work
   * Fixed lots of usage of ddt functions
   * When using a non-contiguous datatype, if the root process is not
     (n-1), now we used a 2nd convertor to copy from shmem to the rbuf
     (saves a memory copy vs. what was done before)
   * Lots and lots of little cleanups, clarifications, and minor
     optimizations (although still more could be done -- e.g., I think
     the use of write memory barriers is fairly sub-optimal; they
     could be ganged together at the root, for example)

I'm marking this as "fixes trac:1988" and closing the ticket; if something
is still broken, we can re-open the ticket.

This commit was SVN r21967.

The following Trac tickets were found above:
  Ticket 1988 --> https://svn.open-mpi.org/trac/ompi/ticket/1988
2009-09-15 00:25:21 +00:00
..
base ... Delayed due to notifier commits earlier this day ... 2009-04-29 01:32:14 +00:00
basic Update related .windows files with proper compiling properties, in order to have a successful DSO build. 2009-08-12 08:55:58 +00:00
demo ... Delayed due to notifier commits earlier this day ... 2009-04-29 01:32:14 +00:00
hierarch Update related .windows files with proper compiling properties, in order to have a successful DSO build. 2009-08-12 08:55:58 +00:00
inter - Split the datatype engine into two parts: an MPI specific part in 2009-07-13 04:56:31 +00:00
self Update related .windows files with proper compiling properties, in order to have a successful DSO build. 2009-08-12 08:55:58 +00:00
sm Fixes trac:1988. The little bug that turned out to be huge. Yoinks. 2009-09-15 00:25:21 +00:00
sm2 - Split the datatype engine into two parts: an MPI specific part in 2009-07-13 04:56:31 +00:00
sync Update related .windows files with proper compiling properties, in order to have a successful DSO build. 2009-08-12 08:55:58 +00:00
tuned - Replace combinations of 2009-08-20 11:42:18 +00:00
coll.h Two major things in this commit: 2009-01-14 23:44:31 +00:00
Makefile.am Clean up a couple of configure things: 2007-05-15 04:23:48 +00:00