0fe756d416
MPI standard states a user MPI_Op and/or user MPI_Datatype can be free'd after a call to a non blocking collective and before the non-blocking collective completes. Retain user (only) MPI_Op and MPI_Datatype when the non blocking call is invoked, and set a request callback so they are free'd when the MPI_Request completes. Thanks Thomas Ponweiser for reporting this Fixes open-mpi/ompi#2151 Fixes open-mpi/ompi#1304 Signed-off-by: Gilles Gouaillardet <gilles@rist.or.jp>
100 строки
2.9 KiB
C
100 строки
2.9 KiB
C
/*
|
|
* Copyright (c) 2012 Oak Rigde National Laboratory. All rights reserved.
|
|
* Copyright (c) 2015-2019 Research Organization for Information Science
|
|
* and Technology (RIST). All rights reserved.
|
|
* Copyright (c) 2017-2018 The University of Tennessee and The University
|
|
* of Tennessee Research Foundation. All rights
|
|
* reserved.
|
|
* $COPYRIGHT$
|
|
*
|
|
* Additional copyrights may follow
|
|
*
|
|
* $HEADER$
|
|
*/
|
|
#include "ompi_config.h"
|
|
#include <stdio.h>
|
|
|
|
#include "ompi/mpi/c/bindings.h"
|
|
#include "ompi/runtime/params.h"
|
|
#include "ompi/communicator/communicator.h"
|
|
#include "ompi/errhandler/errhandler.h"
|
|
#include "ompi/datatype/ompi_datatype.h"
|
|
#include "ompi/mca/coll/base/coll_base_util.h"
|
|
#include "ompi/memchecker.h"
|
|
#include "ompi/runtime/ompi_spc.h"
|
|
|
|
#if OMPI_BUILD_MPI_PROFILING
|
|
#if OPAL_HAVE_WEAK_SYMBOLS
|
|
#pragma weak MPI_Ibcast = PMPI_Ibcast
|
|
#endif
|
|
#define MPI_Ibcast PMPI_Ibcast
|
|
#endif
|
|
|
|
static const char FUNC_NAME[] = "MPI_Ibcast";
|
|
|
|
|
|
int MPI_Ibcast(void *buffer, int count, MPI_Datatype datatype,
|
|
int root, MPI_Comm comm, MPI_Request *request)
|
|
{
|
|
int err;
|
|
|
|
SPC_RECORD(OMPI_SPC_IBCAST, 1);
|
|
|
|
MEMCHECKER(
|
|
memchecker_datatype(datatype);
|
|
memchecker_call(&opal_memchecker_base_isdefined, buffer, count, datatype);
|
|
memchecker_comm(comm);
|
|
);
|
|
|
|
if (MPI_PARAM_CHECK) {
|
|
err = MPI_SUCCESS;
|
|
OMPI_ERR_INIT_FINALIZE(FUNC_NAME);
|
|
if (ompi_comm_invalid(comm)) {
|
|
return OMPI_ERRHANDLER_INVOKE(MPI_COMM_WORLD, MPI_ERR_COMM,
|
|
FUNC_NAME);
|
|
}
|
|
|
|
/* Errors for all ranks */
|
|
|
|
OMPI_CHECK_DATATYPE_FOR_SEND(err, datatype, count);
|
|
OMPI_ERRHANDLER_CHECK(err, comm, err, FUNC_NAME);
|
|
if (MPI_IN_PLACE == buffer) {
|
|
return OMPI_ERRHANDLER_INVOKE(comm, MPI_ERR_ARG, FUNC_NAME);
|
|
}
|
|
|
|
/* Errors for intracommunicators */
|
|
|
|
if (OMPI_COMM_IS_INTRA(comm)) {
|
|
if ((root >= ompi_comm_size(comm)) || (root < 0)) {
|
|
return OMPI_ERRHANDLER_INVOKE(comm, MPI_ERR_ROOT, FUNC_NAME);
|
|
}
|
|
}
|
|
|
|
/* Errors for intercommunicators */
|
|
|
|
else {
|
|
if (! ((root >= 0 && root < ompi_comm_remote_size(comm)) ||
|
|
MPI_ROOT == root || MPI_PROC_NULL == root)) {
|
|
return OMPI_ERRHANDLER_INVOKE(comm, MPI_ERR_ROOT, FUNC_NAME);
|
|
}
|
|
}
|
|
}
|
|
|
|
OPAL_CR_ENTER_LIBRARY();
|
|
|
|
/* Invoke the coll component to perform the back-end operation */
|
|
|
|
err = comm->c_coll->coll_ibcast(buffer, count, datatype, root, comm,
|
|
request,
|
|
comm->c_coll->coll_ibcast_module);
|
|
if (OPAL_LIKELY(OMPI_SUCCESS == err)) {
|
|
if (!OMPI_COMM_IS_INTRA(comm)) {
|
|
if (MPI_PROC_NULL == root) {
|
|
datatype = NULL;
|
|
}
|
|
}
|
|
ompi_coll_base_retain_datatypes(*request, datatype, NULL);
|
|
}
|
|
OMPI_ERRHANDLER_RETURN(err, comm, err, FUNC_NAME);
|
|
}
|