1
1
Nathan Hjelm 4d4fa28f75 opal: fix coverity issues
Fix CID 1345825 (1 of 1): Dereference before null check (REVERSE_INULL):

ib_proc should not be NULL in this case. Removed the check and added a
check for NULL after OBJ_NEW.

CID 1269821 (1 of 1): Dereference null return value (NULL_RETURNS):

I labeled this one as a false positive (which it is) but the code in
question could stand be be cleaned up.

Fix CID 1356424 (1 of 1): Argument cannot be negative (NEGATIVE_RETURNS):

While trying to silence another Coverity issue another was
flagged. Protect the close of fd with if (fd >= 0).

CID 70772 (1 of 1): Dereference null return value (NULL_RETURNS):
CID 70773 (1 of 1): Dereference null return value (NULL_RETURNS):
CID 70774 (1 of 1): Dereference null return value (NULL_RETURNS):

None of these are errors and are intentional but now that we have a
list release function use that to make these go away. The cleanup is
similar to CID 1269821.

Signed-off-by: Nathan Hjelm <hjelmn@lanl.gov>
2016-03-18 15:56:08 -06:00
..
2015-06-23 20:59:57 -07:00
2015-06-23 20:59:57 -07:00
2015-06-23 20:59:57 -07:00
2014-12-04 15:30:02 -07:00
2016-03-18 15:56:08 -06:00
2015-06-23 20:59:57 -07:00
2015-06-25 10:14:13 -06:00
2015-06-23 20:59:57 -07:00
2015-06-23 20:59:57 -07:00
2015-06-23 20:59:57 -07:00
2015-06-23 20:59:57 -07:00