ports/openmpi
ports/openmpi
1
1
Форкнуть 0
Код Релизы Активность
26705efad0
openmpi/opal/util/sys_limits.c
Mark Allen 655a06f559 IB fork 
The key change was in btl_openib_connect_udcm.c where a buffer was
being pinned with size 65664 (whether openib was being used or not).
The start of the buffer was page aligned, but because of the size
the end wasn't. That makes it too easy for a forked child to accidentally
touch pinned memory on the same page as the end of that buffer.

So this change increases the size of the allocated buffer to use the
rest of the page.

I inspected the rest of the ibv_reg_mr() calls and changed one other
place to page align its buffer too, although I think the above is
the one that really matters.

Signed-off-by: Mark Allen <markalle@us.ibm.com>
2017-04-05 17:35:52 -04:00

255 строки
8.1 KiB
C
Исходник Ответственный История

/* -*- Mode: C; c-basic-offset:4 ; indent-tabs-mode:nil -*- */
/*
* Copyright (c) 2004-2005 The Trustees of Indiana University and Indiana
* University Research and Technology
* Corporation. All rights reserved.
* Copyright (c) 2004-2005 The University of Tennessee and The University
* of Tennessee Research Foundation. All rights
* reserved.
* Copyright (c) 2004-2005 High Performance Computing Center Stuttgart,
* University of Stuttgart. All rights reserved.
* Copyright (c) 2004-2005 The Regents of the University of California.
* All rights reserved.
* Copyright (c) 2007 Cisco Systems, Inc. All rights reserved.
* Copyright (c) 2013-2015 Los Alamos National Security, LLC. All rights
* reserved.
* Copyright (c) 2014 Intel, Inc. All rights reserved.
* Copyright (c) 2015 Research Organization for Information Science
* and Technology (RIST). All rights reserved.
* $COPYRIGHT$
*
* Additional copyrights may follow
*
* $HEADER$
*/
#include "opal_config.h"
#include <string.h>
#include <errno.h>
#ifdef HAVE_SYS_TYPES_H
#include <sys/types.h>
#endif
#ifdef HAVE_SYS_TIME_H
#include <sys/time.h>
#endif
#ifdef HAVE_SYS_RESOURCE_H
#include <sys/resource.h>
#endif
#ifdef HAVE_UNISTD_H
#include <unistd.h>
#endif
#include "opal/constants.h"
#include "opal/runtime/opal_params.h"
#include "opal/util/sys_limits.h"
#include "opal/util/show_help.h"
#include "opal/util/output.h"
#include "opal/util/argv.h"
/*
* Create and initialize storage for the system limits
*/
OPAL_DECLSPEC opal_sys_limits_t opal_sys_limits = {
/* initialized = */ false,
/* num_files = */ -1,
/* num_procs = */ -1,
/* file_size = */ 0
};
static int opal_setlimit(int resource, char *value, rlim_t *out)
{
struct rlimit rlim, rlim_set;
rlim_t maxlim;
rlim.rlim_cur = 0;
if (0 == strcmp(value, "max")) {
maxlim = -1;
} else if (0 == strncmp(value, "unlimited", strlen(value))) {
maxlim = RLIM_INFINITY;
} else {
maxlim = strtol(value, NULL, 10);
}
if (0 <= getrlimit(resource, &rlim)) {
if (rlim.rlim_max < maxlim) {
rlim_set.rlim_cur = rlim.rlim_cur;
rlim_set.rlim_max = rlim.rlim_max;
} else {
rlim_set.rlim_cur = maxlim;
rlim_set.rlim_max = maxlim;
}
if (0 <= setrlimit(resource, &rlim_set)) {
rlim.rlim_cur = rlim_set.rlim_cur;
} else if (RLIM_INFINITY == maxlim) {
/* if unlimited wasn't allowed, try to set
* to max allowed
*/
rlim_set.rlim_cur = rlim.rlim_max;
rlim_set.rlim_max = rlim.rlim_max;
if (0 <= setrlimit(resource, &rlim_set)) {
rlim.rlim_cur = rlim_set.rlim_cur;
} else {
return OPAL_ERROR;
}
} else {
return OPAL_ERROR;
}
} else {
return OPAL_ERROR;
}
*out = rlim.rlim_cur;
return OPAL_SUCCESS;
}
int opal_util_init_sys_limits(char **errmsg)
{
char **lims, **lim=NULL, *setlim;
int i, rc = OPAL_ERROR;
rlim_t value;
/* if limits were not given, then nothing to do */
if (NULL == opal_set_max_sys_limits) {
return OPAL_SUCCESS;
}
/* parse the requested limits to set */
lims = opal_argv_split(opal_set_max_sys_limits, ',');
if (NULL == lims) {
return OPAL_ERR_OUT_OF_RESOURCE;
}
/* each limit is expressed as a "param:value" pair */
for (i=0; NULL != lims[i]; i++) {
lim = opal_argv_split(lims[i], ':');
if (1 == opal_argv_count(lim)) {
setlim = "max";
} else {
setlim = lim[1];
}
/* for historical reasons, a value of "1" means
* that we set the limits on #files, #children,
* and max file size
*/
if (0 == strcmp(lim[0], "1")) {
#if HAVE_DECL_RLIMIT_NOFILE
if (OPAL_SUCCESS !=
opal_setlimit(RLIMIT_NOFILE, "max", &value)) {
*errmsg = opal_show_help_string("help-opal-util.txt", "sys-limit-failed", true, "openfiles", "max");
goto out;
}
opal_sys_limits.num_files = value;
#endif
#if HAVE_DECL_RLIMIT_NPROC
if (OPAL_SUCCESS != opal_setlimit(RLIMIT_NPROC, "max", &value)) {
*errmsg = opal_show_help_string("help-opal-util.txt", "sys-limit-failed", true, "maxchildren", "max");
goto out;
}
opal_sys_limits.num_procs = value;
#endif
#if HAVE_DECL_RLIMIT_FSIZE
if (OPAL_SUCCESS !=
opal_setlimit(RLIMIT_FSIZE, "max", &value)) {
*errmsg = opal_show_help_string("help-opal-util.txt", "sys-limit-failed", true, "filesize", "max");
goto out;
}
opal_sys_limits.file_size = value;
#endif
break;
} else if (0 == strcmp(lim[0], "0")) {
/* user didn't want anything set */
break;
}
/* process them separately */
if (0 == strcmp(lim[0], "core")) {
#if HAVE_DECL_RLIMIT_CORE
if (OPAL_SUCCESS != opal_setlimit(RLIMIT_CORE, setlim, &value)) {
*errmsg = opal_show_help_string("help-opal-util.txt", "sys-limit-failed", true, "openfiles", setlim);
goto out;
}
#endif
} else if (0 == strcmp(lim[0], "filesize")) {
#if HAVE_DECL_RLIMIT_FSIZE
if (OPAL_SUCCESS != opal_setlimit(RLIMIT_FSIZE, setlim, &value)) {
*errmsg = opal_show_help_string("help-opal-util.txt", "sys-limit-failed", true, "filesize", setlim);
goto out;
}
opal_sys_limits.file_size = value;
#endif
} else if (0 == strcmp(lim[0], "maxmem")) {
#if HAVE_DECL_RLIMIT_AS
if (OPAL_SUCCESS != opal_setlimit(RLIMIT_AS, setlim, &value)) {
*errmsg = opal_show_help_string("help-opal-util.txt", "sys-limit-failed", true, "maxmem", setlim);
goto out;
}
#endif
} else if (0 == strcmp(lim[0], "openfiles")) {
#if HAVE_DECL_RLIMIT_NOFILE
if (OPAL_SUCCESS != opal_setlimit(RLIMIT_NOFILE, setlim, &value)) {
*errmsg = opal_show_help_string("help-opal-util.txt", "sys-limit-failed", true, "openfiles", setlim);
goto out;
}
opal_sys_limits.num_files = value;
#endif
} else if (0 == strcmp(lim[0], "stacksize")) {
#if HAVE_DECL_RLIMIT_STACK
if (OPAL_SUCCESS != opal_setlimit(RLIMIT_STACK, setlim, &value)) {
*errmsg = opal_show_help_string("help-opal-util.txt", "sys-limit-failed", true, "stacksize", setlim);
goto out;
}
#endif
} else if (0 == strcmp(lim[0], "maxchildren")) {
#if HAVE_DECL_RLIMIT_NPROC
if (OPAL_SUCCESS != opal_setlimit(RLIMIT_NPROC, setlim, &value)) {
*errmsg = opal_show_help_string("help-opal-util.txt", "sys-limit-failed", true, "maxchildren", setlim);
goto out;
}
opal_sys_limits.num_procs = value;
#endif
} else {
*errmsg = opal_show_help_string("help-opal-util.txt", "sys-limit-unrecognized", true, lim[0], setlim);
goto out;
}
opal_argv_free(lim);
lim = NULL;
}
/* indicate we initialized the limits structure */
opal_sys_limits.initialized = true;
rc = OPAL_SUCCESS;
out:
opal_argv_free(lims);
if (NULL != lim) {
opal_argv_free(lim);
}
return rc;
}
int opal_getpagesize(void)
{
static int page_size = -1;
if (page_size != -1) {
// testing in a loop showed sysconf() took ~5 usec vs ~0.3 usec with it cached
return page_size;
}
#ifdef HAVE_GETPAGESIZE
return page_size = getpagesize();
#elif defined(_SC_PAGESIZE )
return page_size = sysconf(_SC_PAGESIZE);
#elif defined(_SC_PAGE_SIZE)
return page_size = sysconf(_SC_PAGE_SIZE);
#else
return page_size = 65536; /* safer to overestimate than under */
#endif
}
Показать git blame Копировать постоянную ссылку