e9e4d2a4bc
The Open MPI code base assumed that asprintf always behaved like the FreeBSD variant, where ptr is set to NULL on error. However, the C standard (and Linux) only guarantee that the return code will be -1 on error and leave ptr undefined. Rather than fix all the usage in the code, we use opal_asprintf() wrapper instead, which guarantees the BSD-like behavior of ptr always being set to NULL. In addition to being correct, this will fix many, many warnings in the Open MPI code base. Signed-off-by: Brian Barrett <bbarrett@amazon.com>
138 строки
3.0 KiB
C
138 строки
3.0 KiB
C
/*
|
|
* Copyright (c) 2004-2010 The Trustees of Indiana University.
|
|
* All rights reserved.
|
|
* Copyright (c) 2015 Research Organization for Information Science
|
|
* and Technology (RIST). All rights reserved.
|
|
*
|
|
* Copyright (c) 2018 Amazon.com, Inc. or its affiliates. All Rights reserved.
|
|
* $COPYRIGHT$
|
|
*
|
|
* Additional copyrights may follow
|
|
*
|
|
* $HEADER$
|
|
*/
|
|
|
|
#include "opal_config.h"
|
|
|
|
#include <string.h>
|
|
#include <sys/wait.h>
|
|
#if HAVE_SYS_TYPES_H
|
|
#include <sys/types.h>
|
|
#endif
|
|
#if HAVE_UNISTD_H
|
|
#include <unistd.h>
|
|
#endif
|
|
#ifdef HAVE_FCNTL_H
|
|
#include <fcntl.h>
|
|
#endif /* HAVE_FCNTL_H */
|
|
#ifdef HAVE_SYS_STAT_H
|
|
#include <sys/stat.h>
|
|
#endif
|
|
|
|
#include "opal/mca/mca.h"
|
|
#include "opal/mca/base/base.h"
|
|
#include "opal/include/opal/constants.h"
|
|
#include "opal/util/os_dirpath.h"
|
|
#include "opal/util/output.h"
|
|
#include "opal/util/argv.h"
|
|
#include "opal/util/printf.h"
|
|
|
|
#include "opal/mca/compress/compress.h"
|
|
#include "opal/mca/compress/base/base.h"
|
|
|
|
/******************
|
|
* Local Function Defs
|
|
******************/
|
|
|
|
/******************
|
|
* Object stuff
|
|
******************/
|
|
|
|
int opal_compress_base_tar_create(char ** target)
|
|
{
|
|
int exit_status = OPAL_SUCCESS;
|
|
char *tar_target = NULL;
|
|
char **argv = NULL;
|
|
pid_t child_pid = 0;
|
|
int status = 0;
|
|
|
|
opal_asprintf(&tar_target, "%s.tar", *target);
|
|
|
|
child_pid = fork();
|
|
if( 0 == child_pid ) { /* Child */
|
|
char *cmd;
|
|
opal_asprintf(&cmd, "tar -cf %s %s", tar_target, *target);
|
|
|
|
argv = opal_argv_split(cmd, ' ');
|
|
status = execvp(argv[0], argv);
|
|
|
|
opal_output(0, "compress:base: Tar:: Failed to exec child [%s] status = %d\n", cmd, status);
|
|
exit(OPAL_ERROR);
|
|
}
|
|
else if(0 < child_pid) {
|
|
waitpid(child_pid, &status, 0);
|
|
|
|
if( !WIFEXITED(status) ) {
|
|
exit_status = OPAL_ERROR;
|
|
goto cleanup;
|
|
}
|
|
|
|
free(*target);
|
|
*target = strdup(tar_target);
|
|
}
|
|
else {
|
|
exit_status = OPAL_ERROR;
|
|
goto cleanup;
|
|
}
|
|
|
|
cleanup:
|
|
if( NULL != tar_target ) {
|
|
free(tar_target);
|
|
}
|
|
|
|
return exit_status;
|
|
}
|
|
|
|
int opal_compress_base_tar_extract(char ** target)
|
|
{
|
|
int exit_status = OPAL_SUCCESS;
|
|
char **argv = NULL;
|
|
pid_t child_pid = 0;
|
|
int status = 0;
|
|
|
|
child_pid = fork();
|
|
if( 0 == child_pid ) { /* Child */
|
|
char *cmd;
|
|
opal_asprintf(&cmd, "tar -xf %s", *target);
|
|
|
|
argv = opal_argv_split(cmd, ' ');
|
|
status = execvp(argv[0], argv);
|
|
|
|
opal_output(0, "compress:base: Tar:: Failed to exec child [%s] status = %d\n", cmd, status);
|
|
exit(OPAL_ERROR);
|
|
}
|
|
else if(0 < child_pid) {
|
|
waitpid(child_pid, &status, 0);
|
|
|
|
if( !WIFEXITED(status) ) {
|
|
exit_status = OPAL_ERROR;
|
|
goto cleanup;
|
|
}
|
|
|
|
/* Strip off the '.tar' */
|
|
(*target)[strlen(*target)-4] = '\0';
|
|
}
|
|
else {
|
|
exit_status = OPAL_ERROR;
|
|
goto cleanup;
|
|
}
|
|
|
|
cleanup:
|
|
|
|
return exit_status;
|
|
}
|
|
|
|
/******************
|
|
* Local Functions
|
|
******************/
|