7b8094aac1
as reported by Coverity with CIDs 1363349-1363362
Offset temporary buffer when a non zero lower bound datatype is used.
Thanks Hristo Iliev for the report
(cherry picked from commit 0e393195d9)
99 строки
3.2 KiB
C
99 строки
3.2 KiB
C
/*
|
|
* Copyright (c) 2004-2005 The Trustees of Indiana University and Indiana
|
|
* University Research and Technology
|
|
* Corporation. All rights reserved.
|
|
* Copyright (c) 2004-2005 The University of Tennessee and The University
|
|
* of Tennessee Research Foundation. All rights
|
|
* reserved.
|
|
* Copyright (c) 2004-2005 High Performance Computing Center Stuttgart,
|
|
* University of Stuttgart. All rights reserved.
|
|
* Copyright (c) 2004-2005 The Regents of the University of California.
|
|
* All rights reserved.
|
|
* Copyright (c) 2006-2008 University of Houston. All rights reserved.
|
|
* Copyright (c) 2015-2016 Research Organization for Information Science
|
|
* and Technology (RIST). All rights reserved.
|
|
* $COPYRIGHT$
|
|
*
|
|
* Additional copyrights may follow
|
|
*
|
|
* $HEADER$
|
|
*/
|
|
|
|
#include "ompi_config.h"
|
|
#include "coll_inter.h"
|
|
|
|
#include "mpi.h"
|
|
#include "ompi/constants.h"
|
|
#include "ompi/datatype/ompi_datatype.h"
|
|
#include "ompi/mca/coll/coll.h"
|
|
#include "ompi/mca/coll/base/coll_tags.h"
|
|
#include "ompi/mca/pml/pml.h"
|
|
|
|
/*
|
|
* scatter_inter
|
|
*
|
|
* Function: - scatter operation
|
|
* Accepts: - same arguments as MPI_Scatter()
|
|
* Returns: - MPI_SUCCESS or error code
|
|
*/
|
|
int
|
|
mca_coll_inter_scatter_inter(const void *sbuf, int scount,
|
|
struct ompi_datatype_t *sdtype,
|
|
void *rbuf, int rcount,
|
|
struct ompi_datatype_t *rdtype,
|
|
int root, struct ompi_communicator_t *comm,
|
|
mca_coll_base_module_t *module)
|
|
{
|
|
int rank, size, err;
|
|
|
|
/* Initialize */
|
|
|
|
rank = ompi_comm_rank(comm);
|
|
size = ompi_comm_remote_size(comm);
|
|
|
|
if (MPI_PROC_NULL == root) {
|
|
/* do nothing */
|
|
err = OMPI_SUCCESS;
|
|
} else if (MPI_ROOT != root) {
|
|
/* First process receives the data from root */
|
|
char *ptmp_free = NULL, *ptmp = NULL;
|
|
if(0 == rank) {
|
|
int size_local;
|
|
ptrdiff_t gap, span;
|
|
|
|
size_local = ompi_comm_size(comm->c_local_comm);
|
|
span = opal_datatype_span(&rdtype->super, (int64_t)rcount*(int64_t)size_local, &gap);
|
|
ptmp_free = malloc(span);
|
|
if (NULL == ptmp_free) {
|
|
return OMPI_ERR_OUT_OF_RESOURCE;
|
|
}
|
|
ptmp = ptmp_free - gap;
|
|
|
|
err = MCA_PML_CALL(recv(ptmp, rcount*size_local, rdtype,
|
|
root, MCA_COLL_BASE_TAG_SCATTER,
|
|
comm, MPI_STATUS_IGNORE));
|
|
if (OMPI_SUCCESS != err) {
|
|
return err;
|
|
}
|
|
}
|
|
/* Perform the scatter locally with the first process as root */
|
|
err = comm->c_local_comm->c_coll.coll_scatter(ptmp, rcount, rdtype,
|
|
rbuf, rcount, rdtype,
|
|
0, comm->c_local_comm,
|
|
comm->c_local_comm->c_coll.coll_scatter_module);
|
|
if (NULL != ptmp_free) {
|
|
free(ptmp_free);
|
|
}
|
|
} else {
|
|
/* Root sends data to the first process in the remote group */
|
|
err = MCA_PML_CALL(send(sbuf, scount*size, sdtype, 0,
|
|
MCA_COLL_BASE_TAG_SCATTER,
|
|
MCA_PML_BASE_SEND_STANDARD, comm));
|
|
if (OMPI_SUCCESS != err) {
|
|
return err;
|
|
}
|
|
}
|
|
|
|
return err;
|
|
}
|