35438ae9b5
Per MPI-3.1:8.7.1 p361:11-13, it's valid for MPI_FINALIZED to be invoked during an attribute destruction callback (e.g., during the destruction of keyvals on MPI_COMM_SELF during the very beginning of MPI_FINALIZE). In such cases, MPI_FINALIZED must return "false". Prior to this commit, we hung in FINALIZED if it were invoked during a COMM_SELF attribute destruction callback in FINALIZE. See https://github.com/open-mpi/ompi/issues/5084. This commit converts the MPI_INITIALIZED / MPI_FINALIZED infrastructure to use a single enum (ompi_mpi_state, set atomically) to represent the state of MPI: - not initialized - init started - init completed - finalize started - finalize past COMM_SELF destruction - finalize completed The "finalize past COMM_SELF destruction" state is what allows us to return "false" from MPI_FINALIZED before COMM_SELF has been fully destroyed / all attribute callbacks have been invoked. Since this state is checked at nearly every MPI API call (to see if we're outside of the INIT/FINALIZE epoch), care was taken to use atomics to *set* the ompi_mpi_state value in ompi_mpi_init() and ompi_mpi_finalize(), but performance-critical code paths can simply read the variable without needing to use a slow call to an opal_atomic_*() function. Thanks to @AndrewGaspar for reporting the issue. Signed-off-by: Jeff Squyres <jsquyres@cisco.com>
59 строки
1.5 KiB
C
59 строки
1.5 KiB
C
/* -*- Mode: C; c-basic-offset:4 ; indent-tabs-mode:nil -*- */
|
|
/*
|
|
* Copyright (c) 2012-2015 Los Alamos National Security, LLC. All rights
|
|
* reserved.
|
|
* Copyright (c) 2014-2018 Cisco Systems, Inc. All rights reserved
|
|
* Copyright (c) 2017 IBM Corporation. All rights reserved.
|
|
* $COPYRIGHT$
|
|
*
|
|
* Additional copyrights may follow
|
|
*
|
|
* $HEADER$
|
|
*/
|
|
|
|
|
|
#include "ompi/mpi/tool/mpit-internal.h"
|
|
|
|
#include "ompi/runtime/ompi_info_support.h"
|
|
#include "opal/include/opal/sys/atomic.h"
|
|
#include "opal/runtime/opal.h"
|
|
|
|
#if OPAL_HAVE_WEAK_SYMBOLS && OMPI_PROFILING_DEFINES
|
|
#pragma weak MPI_T_finalize = PMPI_T_finalize
|
|
#endif
|
|
|
|
#if OMPI_PROFILING_DEFINES
|
|
#include "ompi/mpi/tool/profile/defines.h"
|
|
#endif
|
|
|
|
|
|
int MPI_T_finalize (void)
|
|
{
|
|
ompi_mpit_lock ();
|
|
|
|
if (!mpit_is_initialized ()) {
|
|
ompi_mpit_unlock ();
|
|
return MPI_T_ERR_NOT_INITIALIZED;
|
|
}
|
|
|
|
if (0 == --ompi_mpit_init_count) {
|
|
(void) ompi_info_close_components ();
|
|
|
|
int32_t state = ompi_mpi_state;
|
|
if ((state < OMPI_MPI_STATE_INIT_COMPLETED ||
|
|
state >= OMPI_MPI_STATE_FINALIZE_PAST_COMM_SELF_DESTRUCT) &&
|
|
(NULL != ompi_mpi_main_thread)) {
|
|
/* we are not between MPI_Init and MPI_Finalize so we
|
|
* have to free the ompi_mpi_main_thread */
|
|
OBJ_RELEASE(ompi_mpi_main_thread);
|
|
ompi_mpi_main_thread = NULL;
|
|
}
|
|
|
|
(void) opal_finalize_util ();
|
|
}
|
|
|
|
ompi_mpit_unlock ();
|
|
|
|
return MPI_SUCCESS;
|
|
}
|